[GitHub] [airflow] kaxil commented on a change in pull request #7948: Make BaseSecretsBackend.build_path generic

[GitBox <gi...@apache.org>]

kaxil commented on a change in pull request #7948: Make BaseSecretsBackend.build_path generic
URL: https://github.com/apache/airflow/pull/7948#discussion_r399654369
 
 

 ##########
 File path: airflow/providers/hashicorp/secrets/vault.py
 ##########
 @@ -150,7 +150,7 @@ def get_conn_uri(self, conn_id: str) -> Optional[str]:
         :param conn_id: connection id
         :type conn_id: str
         """
-        secret_path = self.build_path(connections_prefix=self.connections_path, conn_id=conn_id)
+        secret_path = self.build_path(self.connections_path, conn_id)
 
 Review comment:
   It is a separate method for SecretsBackend **Meta** class so that each Backend can implement it as they all have a separate and all have a prefix and a path.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services