You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "sunbufu (GitHub)" <gi...@apache.org> on 2019/01/22 13:33:02 UTC

[GitHub] [incubator-dubbo-ops] sunbufu opened pull request #268: unit test

Hi, this PR commit 2 files for unit test.
+ CoderUtilTest
+ RegistryServerSyncTest

[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/268 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] lovepoem commented on pull request #268: unit test

Posted by "lovepoem (GitHub)" <gi...@apache.org>.
remove *

[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/268 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] codecov-io commented on issue #268: unit test

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/268?src=pr&el=h1) Report
> Merging [#268](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/268?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/incubator-dubbo-ops/commit/a762a0f65aecdbb2e9d1a96974c07b898f13c0d5?src=pr&el=desc) will **increase** coverage by `0.4%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/268/graphs/tree.svg?width=650&token=fYsc8RuDGB&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/268?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             develop     #268     +/-   ##
============================================
+ Coverage      21.58%   21.99%   +0.4%     
- Complexity       295      305     +10     
============================================
  Files             85       85             
  Lines           3456     3456             
  Branches         547      547             
============================================
+ Hits             746      760     +14     
+ Misses          2628     2613     -15     
- Partials          82       83      +1
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/268?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/dubbo/admin/service/RegistryServerSync.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/268/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vc2VydmljZS9SZWdpc3RyeVNlcnZlclN5bmMuamF2YQ==) | `94.02% <0%> (+4.47%)` | `24% <0%> (+4%)` | :arrow_up: |
| [.../java/org/apache/dubbo/admin/common/util/Tool.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/268/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29tbW9uL3V0aWwvVG9vbC5qYXZh) | `26.31% <0%> (+10.52%)` | `2% <0%> (+1%)` | :arrow_up: |
| [.../org/apache/dubbo/admin/common/util/CoderUtil.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/268/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29tbW9uL3V0aWwvQ29kZXJVdGlsLmphdmE=) | `83.33% <0%> (+30%)` | `10% <0%> (+5%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/268?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/268?src=pr&el=footer). Last update [a762a0f...1945405](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/268?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/268 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] nzomkxia closed pull request #268: unit test

Posted by "nzomkxia (GitHub)" <gi...@apache.org>.
[ pull request closed by nzomkxia ]

[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/268 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] biyuhao commented on pull request #268: unit test

Posted by "biyuhao (GitHub)" <gi...@apache.org>.
Apache license announcement is required here.

[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/268 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] codecov-io commented on issue #268: unit test

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/268?src=pr&el=h1) Report
> Merging [#268](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/268?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/incubator-dubbo-ops/commit/a762a0f65aecdbb2e9d1a96974c07b898f13c0d5?src=pr&el=desc) will **increase** coverage by `0.4%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/268/graphs/tree.svg?width=650&token=fYsc8RuDGB&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/268?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             develop     #268     +/-   ##
============================================
+ Coverage      21.58%   21.99%   +0.4%     
- Complexity       295      305     +10     
============================================
  Files             85       85             
  Lines           3456     3456             
  Branches         547      547             
============================================
+ Hits             746      760     +14     
+ Misses          2628     2613     -15     
- Partials          82       83      +1
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/268?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/dubbo/admin/service/RegistryServerSync.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/268/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vc2VydmljZS9SZWdpc3RyeVNlcnZlclN5bmMuamF2YQ==) | `94.02% <0%> (+4.47%)` | `24% <0%> (+4%)` | :arrow_up: |
| [.../java/org/apache/dubbo/admin/common/util/Tool.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/268/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29tbW9uL3V0aWwvVG9vbC5qYXZh) | `26.31% <0%> (+10.52%)` | `2% <0%> (+1%)` | :arrow_up: |
| [.../org/apache/dubbo/admin/common/util/CoderUtil.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/268/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29tbW9uL3V0aWwvQ29kZXJVdGlsLmphdmE=) | `83.33% <0%> (+30%)` | `10% <0%> (+5%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/268?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/268?src=pr&el=footer). Last update [a762a0f...989b222](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/268?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/268 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] sunbufu commented on pull request #268: unit test

Posted by "sunbufu (GitHub)" <gi...@apache.org>.
ok

[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/268 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] codecov-io commented on issue #268: unit test

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/268?src=pr&el=h1) Report
> Merging [#268](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/268?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/incubator-dubbo-ops/commit/a762a0f65aecdbb2e9d1a96974c07b898f13c0d5?src=pr&el=desc) will **increase** coverage by `0.4%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/268/graphs/tree.svg?width=650&token=fYsc8RuDGB&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/268?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             develop     #268     +/-   ##
============================================
+ Coverage      21.58%   21.99%   +0.4%     
- Complexity       295      305     +10     
============================================
  Files             85       85             
  Lines           3456     3456             
  Branches         547      547             
============================================
+ Hits             746      760     +14     
+ Misses          2628     2613     -15     
- Partials          82       83      +1
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/268?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/dubbo/admin/service/RegistryServerSync.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/268/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vc2VydmljZS9SZWdpc3RyeVNlcnZlclN5bmMuamF2YQ==) | `94.02% <0%> (+4.47%)` | `24% <0%> (+4%)` | :arrow_up: |
| [.../java/org/apache/dubbo/admin/common/util/Tool.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/268/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29tbW9uL3V0aWwvVG9vbC5qYXZh) | `26.31% <0%> (+10.52%)` | `2% <0%> (+1%)` | :arrow_up: |
| [.../org/apache/dubbo/admin/common/util/CoderUtil.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/268/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29tbW9uL3V0aWwvQ29kZXJVdGlsLmphdmE=) | `83.33% <0%> (+30%)` | `10% <0%> (+5%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/268?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/268?src=pr&el=footer). Last update [a762a0f...1945405](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/268?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/268 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] biyuhao commented on pull request #268: unit test

Posted by "biyuhao (GitHub)" <gi...@apache.org>.
Please add Apache License announcement at the head of new files.
You can copy it from any other sourcecode.

[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/268 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] sunbufu commented on pull request #268: unit test

Posted by "sunbufu (GitHub)" <gi...@apache.org>.
ok

[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/268 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] sunbufu commented on pull request #268: unit test

Posted by "sunbufu (GitHub)" <gi...@apache.org>.
ok

[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/268 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org