You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by michalsenkyr <gi...@git.apache.org> on 2017/01/03 23:17:03 UTC

[GitHub] spark pull request #16240: [SPARK-16792][SQL] Dataset containing a Case Clas...

Github user michalsenkyr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16240#discussion_r94504343
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetPrimitiveSuite.scala ---
    @@ -130,6 +130,30 @@ class DatasetPrimitiveSuite extends QueryTest with SharedSQLContext {
         checkDataset(Seq(Array(Tuple1(1))).toDS(), Array(Tuple1(1)))
       }
     
    +  test("arbitrary sequences") {
    --- End diff --
    
    I added some sequence-product combination tests.
    Nested sequences were never supported (tried on master and 2.0.2).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org