You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "ThomasJLLN (via GitHub)" <gi...@apache.org> on 2026/09/16 10:04:57 UTC
[PR] fix(helm): allow unknown top-level values [superset-kubernetes-operator]
ThomasJLLN opened a new pull request, #366:
URL: https://github.com/apache/superset-kubernetes-operator/pull/366
## Summary
`charts/superset-operator/values.schema.json` sets `"additionalProperties": false` on the root object. Helm validates the fully coalesced values against this schema, so installing the chart fails whenever anything supplies a top-level value the chart does not itself declare:
```
$ helm install superset-operator charts/superset-operator -f shared-values.yaml
Error: values don't meet the specifications of the schema(s) in the following chart(s):
superset-operator:
- at '': additional properties 'clusterName' not allowed
```
The chart owns none of those keys and ignores them at render time, so rejecting them is strictly a loss. Three common workflows are affected:
1. **Shared values files.** A single org-wide `common-values.yaml` applied across several charts in one pipeline makes the chart fail.
2. **CD tooling that injects release metadata.** Deployers commonly `--set` a small block of cluster/environment identity into every release.
3. **`--set appVersion=<build>`**, a widespread convention, fails.
This PR removes `additionalProperties: false` from the root object only. The nested`additionalProperties: false` constraints are unchanged, so everything that catches real mistakes still fires.
## Details
There is already precedent for this reasoning in the same file. `global` is declared as a bare permissive object:
```json
"global": {
"type": "object",
"description": "Helm-injected global values (present when installed as a dependency)."
}
```
That is the schema conceding that something outside the chart injects keys there and that those keys should not be validated against the chart's own vocabulary. Top-level injection is the same situation with the same answer. Widely used chart families (e.g. Bitnami) ship `values.schema.json` files with no `additionalProperties` constraints at all.
### Trade-off
A misspelled top-level key (`servicAccount:`, `imagee:`) becomes a silent but every misspelling *inside* a value block is still caught.
## Testing
- `make helm-test`
- Added a chart unit test asserting the chart renders when an undeclared top-level value
is supplied.
- `make helm-values-covered` unaffected — no new `values.yaml` knob.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(helm): allow unknown top-level values [superset-kubernetes-operator]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #366:
URL: https://github.com/apache/superset-kubernetes-operator/pull/366#issuecomment-5701850234
## [Codecov](https://app.codecov.io/gh/apache/superset-kubernetes-operator/pull/366?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 93.27%. Comparing base ([`ea2d200`](https://app.codecov.io/gh/apache/superset-kubernetes-operator/commit/ea2d200e9f910d00559622fb0504aa9e6a2730a1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`9995698`](https://app.codecov.io/gh/apache/superset-kubernetes-operator/commit/9995698282694881b855994ea4ce0c2bc5f48879?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset-kubernetes-operator/pull/366?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(helm): allow unknown top-level values [superset-kubernetes-operator]
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro merged PR #366:
URL: https://github.com/apache/superset-kubernetes-operator/pull/366
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(helm): allow unknown top-level values [superset-kubernetes-operator]
Posted by "ThomasJLLN (via GitHub)" <gi...@apache.org>.
ThomasJLLN commented on PR #366:
URL: https://github.com/apache/superset-kubernetes-operator/pull/366#issuecomment-5712353603
Hello @villebro, thank you for your review. I added your note (which is good for me) to the chart's README.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(helm): allow unknown top-level values [superset-kubernetes-operator]
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #366:
URL: https://github.com/apache/superset-kubernetes-operator/pull/366#issuecomment-5735985277
> Hello @villebro, thank you for your review. I added your note (which is good for me) to the chart's README.
Thanks @ThomasJLLN - kicked off CI, restamped and will merge when green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org