You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "Yicong-Huang (via GitHub)" <gi...@apache.org> on 2026/07/05 00:16:38 UTC
[PR] refactor(amber): rename execution coordinators to managers [texera]
Yicong-Huang opened a new pull request, #6123:
URL: https://github.com/apache/texera/pull/6123
### What changes were proposed in this PR?
Pure mechanical rename of the two region-scheduling classes, freeing the "Coordinator" name for the upcoming Controller → Coordinator rename (#6122):
| Before | After |
| --- | --- |
| `WorkflowExecutionCoordinator` | `WorkflowExecutionManager` |
| `RegionExecutionCoordinator` | `RegionExecutionManager` |
| `RegionCoordinatorTestSupport` | `RegionExecutionManagerTestSupport` |
The Manager suffix mirrors the `WorkflowExecution` / `RegionExecution` state objects each class owns and drives, following existing precedent (`GlobalReplayManager`, `OutputManager`). Variables (`workflowExecutionCoordinator`, `regionExecutionCoordinators`, `unfinishedRegionCoordinators`, …), comments (including two `RegionExecutionCoordintor` typos), and cross-references in Python comments were updated together. Files moved with `git mv`; no behavior change.
### Any related issues, documentation, discussions?
Closes #6121. Prerequisite for #6122.
### How was this PR tested?
Refactor with no behavior change — the existing specs were renamed along with the classes and stay green with no assertion edits:
```
sbt "WorkflowExecutionService/testOnly org.apache.texera.amber.engine.architecture.scheduling.WorkflowExecutionManagerSpec org.apache.texera.amber.engine.architecture.scheduling.RegionExecutionManagerSpec"
```
`grep -riE 'ExecutionCoordinator|RegionCoordinator|Coordintor'` over the repo returns no matches after the rename.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Fable 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(amber): rename execution coordinators to managers [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6123:
URL: https://github.com/apache/texera/pull/6123#issuecomment-4884236660
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@Ma77Ball`, `@aglinxinyuan`, `@kunwp1`
You can notify them by mentioning `@Ma77Ball`, `@aglinxinyuan`, `@kunwp1` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(amber): rename execution coordinators to managers [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang merged PR #6123:
URL: https://github.com/apache/texera/pull/6123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(amber): rename execution coordinators to managers [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6123:
URL: https://github.com/apache/texera/pull/6123#issuecomment-4884244039
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/6123?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 59.12%. Comparing base ([`908a61f`](https://app.codecov.io/gh/apache/texera/commit/908a61f08ae521c461ca6c1b7095fc4b99140219?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f61cacb`](https://app.codecov.io/gh/apache/texera/commit/f61cacbd507ba09701e1f6ff3f1b4dc72c117ddd?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #6123 +/- ##
============================================
- Coverage 59.12% 59.12% -0.01%
+ Complexity 3197 3195 -2
============================================
Files 1132 1132
Lines 43681 43673 -8
Branches 4734 4734
============================================
- Hits 25828 25821 -7
+ Misses 16419 16418 -1
Partials 1434 1434
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/6123/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/6123/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.00% <ø> (ø)` | | Carriedforward from [908a61f](https://app.codecov.io/gh/apache/texera/commit/908a61f08ae521c461ca6c1b7095fc4b99140219?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/6123/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.59% <ø> (ø)` | | Carriedforward from [908a61f](https://app.codecov.io/gh/apache/texera/commit/908a61f08ae521c461ca6c1b7095fc4b99140219?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/6123/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.07% <ø> (-0.02%)` | :arrow_down: | Carriedforward from [908a61f](https://app.codecov.io/gh/apache/texera/commit/908a61f08ae521c461ca6c1b7095fc4b99140219?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/6123/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | | Carriedforward from [908a61f](https://app.codecov.io/gh/apache/texera/commit/908a61f08ae521c461ca6c1b7095fc4b99140219?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/6123/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `52.30% <ø> (ø)` | | Carriedforward from [908a61f](https://app.codecov.io/gh/apache/texera/commit/908a61f08ae521c461ca6c1b7095fc4b99140219?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/6123/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `62.81% <ø> (ø)` | | Carriedforward from [908a61f](https://app.codecov.io/gh/apache/texera/commit/908a61f08ae521c461ca6c1b7095fc4b99140219?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/6123/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `51.37% <ø> (ø)` | | Carriedforward from [908a61f](https://app.codecov.io/gh/apache/texera/commit/908a61f08ae521c461ca6c1b7095fc4b99140219?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/6123/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.57% <ø> (ø)` | | Carriedforward from [908a61f](https://app.codecov.io/gh/apache/texera/commit/908a61f08ae521c461ca6c1b7095fc4b99140219?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/6123/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `91.19% <ø> (ø)` | | |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/6123/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.14% <ø> (ø)` | | Carriedforward from [908a61f](https://app.codecov.io/gh/apache/texera/commit/908a61f08ae521c461ca6c1b7095fc4b99140219?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/6123?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(amber): rename execution coordinators to managers [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6123:
URL: https://github.com/apache/texera/pull/6123#issuecomment-4884251071
<!-- texera-benchmarks-comment -->
## ⚠️ Benchmark changes need a look
🟢 2 better · 🔴 3 worse · ⚪ 10 noise (<±5%) · 0 without baseline
> Compared against main `6de8a48` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
[Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/28724129109)
| | config | throughput | MB/s | latency | max Δ latest / 7d |
|---|---|---:|---:|---:|---:|
| 🔴 | bs=10 sw=10 sl=64 | 368 | 0.224 | 26,041/38,465/38,465 us | 🔴 +12.2% / 🔴 +154.0% |
| ⚪ | bs=100 sw=10 sl=64 | 789 | 0.481 | 128,112/143,903/143,903 us | ⚪ within ±5% / 🔴 +33.3% |
| ⚪ | bs=1000 sw=10 sl=64 | 902 | 0.551 | 1,103,668/1,146,532/1,146,532 us | ⚪ within ±5% / 🔴 +11.5% |
<details><summary>Baseline details</summary>
Latest main `6de8a48` from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---:|---:|---:|---:|---:|
| bs=10 sw=10 sl=64 | throughput | 368 tuples/sec | 392 tuples/sec | 776.36 tuples/sec | -6.1% | -52.6% |
| bs=10 sw=10 sl=64 | MB/s | 0.224 MB/s | 0.239 MB/s | 0.474 MB/s | -6.3% | -52.7% |
| bs=10 sw=10 sl=64 | p50 | 26,041 us | 23,218 us | 12,636 us | +12.2% | +106.1% |
| bs=10 sw=10 sl=64 | p95 | 38,465 us | 40,750 us | 15,143 us | -5.6% | +154.0% |
| bs=10 sw=10 sl=64 | p99 | 38,465 us | 40,750 us | 18,954 us | -5.6% | +102.9% |
| bs=100 sw=10 sl=64 | throughput | 789 tuples/sec | 809 tuples/sec | 985.33 tuples/sec | -2.5% | -19.9% |
| bs=100 sw=10 sl=64 | MB/s | 0.481 MB/s | 0.494 MB/s | 0.601 MB/s | -2.6% | -20.0% |
| bs=100 sw=10 sl=64 | p50 | 128,112 us | 123,142 us | 101,671 us | +4.0% | +26.0% |
| bs=100 sw=10 sl=64 | p95 | 143,903 us | 140,743 us | 107,939 us | +2.2% | +33.3% |
| bs=100 sw=10 sl=64 | p99 | 143,903 us | 140,743 us | 113,798 us | +2.2% | +26.5% |
| bs=1000 sw=10 sl=64 | throughput | 902 tuples/sec | 913 tuples/sec | 1,016 tuples/sec | -1.2% | -11.3% |
| bs=1000 sw=10 sl=64 | MB/s | 0.551 MB/s | 0.557 MB/s | 0.62 MB/s | -1.1% | -11.2% |
| bs=1000 sw=10 sl=64 | p50 | 1,103,668 us | 1,098,730 us | 989,693 us | +0.4% | +11.5% |
| bs=1000 sw=10 sl=64 | p95 | 1,146,532 us | 1,125,489 us | 1,028,327 us | +1.9% | +11.5% |
| bs=1000 sw=10 sl=64 | p99 | 1,146,532 us | 1,125,489 us | 1,059,969 us | +1.9% | +8.2% |
</details>
<details><summary>Raw CSV</summary>
```csv
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,543.92,200,128000,368,0.224,26040.86,38464.75,38464.75
1,100,10,64,20,2535.95,2000,1280000,789,0.481,128111.99,143902.86,143902.86
2,1000,10,64,20,22172.85,20000,12800000,902,0.551,1103667.50,1146532.06,1146532.06
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org