[GitHub] [spark] skonto commented on a change in pull request #24796: [SPARK-27900][CORE] Add uncaught exception handler to the driver

[GitBox <gi...@apache.org>]

skonto commented on a change in pull request #24796: [SPARK-27900][CORE] Add uncaught exception handler to the driver
URL: https://github.com/apache/spark/pull/24796#discussion_r290494397
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
 ##########
 @@ -861,6 +861,16 @@ private[spark] class SparkSubmit extends Logging {
    * running cluster deploy mode or python applications.
    */
   private def runMain(args: SparkSubmitArguments, uninitLog: Boolean): Unit = {
+    // set the handler as early as possible
+    // we need the driver check because spark-submit is used by mesos to launch
+    // executors (via the SparkLauncher)
+    val isExecutor = args.childArgs.contains("--executor-id")
 
 Review comment:
   no the best but at this point this is what is available (the alternative is to add it at the SparkContext side)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org