You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "szetszwo (via GitHub)" <gi...@apache.org> on 2025/09/20 19:38:23 UTC

[PR] RATIS-2261. Intermittent failure in TestRaftSnapshotWithGrpc.testInstallSnapshotDuringBootstrap. [ratis]

szetszwo opened a new pull request, #1287:
URL: https://github.com/apache/ratis/pull/1287

   See RATIS-2261.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] RATIS-2261. Intermittent failure in TestRaftSnapshotWithGrpc.testInstallSnapshotDuringBootstrap. [ratis]

Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 commented on code in PR #1287:
URL: https://github.com/apache/ratis/pull/1287#discussion_r2365973032


##########
ratis-server/src/test/java/org/apache/ratis/statemachine/RaftSnapshotBaseTest.java:
##########
@@ -237,9 +227,8 @@ public void testBasicInstallSnapshot() throws Exception {
       }
 
       // add two more peers
-      String[] newPeers = new String[]{"s3", "s4"};
-      MiniRaftCluster.PeerChanges change = cluster.addNewPeers(
-          newPeers, true, false);
+      final String[] newPeers = new String[]{"new0"};

Review Comment:
   Thank you for the changes! I think it might be better if the new peer’s name also starts with s, since that would be more consistent with the existing naming. Also, the comment above should be updated accordingly.



##########
ratis-server/src/test/java/org/apache/ratis/statemachine/RaftSnapshotBaseTest.java:
##########
@@ -237,9 +227,8 @@ public void testBasicInstallSnapshot() throws Exception {
       }
 
       // add two more peers
-      String[] newPeers = new String[]{"s3", "s4"};
-      MiniRaftCluster.PeerChanges change = cluster.addNewPeers(
-          newPeers, true, false);
+      final String[] newPeers = new String[]{"new0"};

Review Comment:
   Thank you for the changes! I think it might be better if the new peer’s name also starts with `s`, since that would be more consistent with the existing naming. Also, the comment above should be updated accordingly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] RATIS-2261. Intermittent failure in TestRaftSnapshotWithGrpc.testInstallSnapshotDuringBootstrap. [ratis]

Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on PR #1287:
URL: https://github.com/apache/ratis/pull/1287#issuecomment-3320247213

   > Should I create a new bug for TestInstallSnapshotNotificationWithGrpc, ...
   
   Let's fix it separately.  We probably should set empty peer list when starting a new server for all the cases.  Let me try.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] RATIS-2261. Intermittent failure in TestRaftSnapshotWithGrpc.testInstallSnapshotDuringBootstrap. [ratis]

Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on PR #1287:
URL: https://github.com/apache/ratis/pull/1287#issuecomment-3320269893

   @adoroszlai , @OneSizeFitsQuorum , thanks a lot for reviewing this!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] RATIS-2261. Intermittent failure in TestRaftSnapshotWithGrpc.testInstallSnapshotDuringBootstrap. [ratis]

Posted by "OneSizeFitsQuorum (via GitHub)" <gi...@apache.org>.
OneSizeFitsQuorum commented on PR #1287:
URL: https://github.com/apache/ratis/pull/1287#issuecomment-3320026775

   Take a try at https://github.com/OneSizeFitsQuorum/ratis/tree/test_ci_rebase to disable majority add for TestInstallSnapshotNotificationWithGrpc with this patch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] RATIS-2261. Intermittent failure in TestRaftSnapshotWithGrpc.testInstallSnapshotDuringBootstrap. [ratis]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #1287:
URL: https://github.com/apache/ratis/pull/1287#issuecomment-3317203612

   Thanks @szetszwo for working on this.  Sorry, it seems I have confused `testInstallSnapshotDuringBootstrap` in two different test classes:
   
   1. RATIS-2261 initially reported `TestRaftSnapshotWithGrpc`.
   2. For my recent [comment](https://issues.apache.org/jira/browse/RATIS-2261?focusedCommentId=18020902&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-18020902) about more frequent failures I was testing `TestInstallSnapshotNotificationWithGrpc`.  It is still [failing](https://github.com/adoroszlai/ratis/actions/runs/17897369206) with this patch.
   
   Should I create a new bug for `TestInstallSnapshotNotificationWithGrpc`, or is it better fixed as part of this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] RATIS-2261. Intermittent failure in TestRaftSnapshotWithGrpc.testInstallSnapshotDuringBootstrap. [ratis]

Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on code in PR #1287:
URL: https://github.com/apache/ratis/pull/1287#discussion_r2366427621


##########
ratis-server/src/test/java/org/apache/ratis/statemachine/RaftSnapshotBaseTest.java:
##########
@@ -237,9 +227,8 @@ public void testBasicInstallSnapshot() throws Exception {
       }
 
       // add two more peers
-      String[] newPeers = new String[]{"s3", "s4"};
-      MiniRaftCluster.PeerChanges change = cluster.addNewPeers(
-          newPeers, true, false);
+      final String[] newPeers = new String[]{"new0"};

Review Comment:
   @slfan1989 , thanks for reviewing this!  Let's use the method with the number of new peers.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] RATIS-2261. Intermittent failure in TestRaftSnapshotWithGrpc.testInstallSnapshotDuringBootstrap. [ratis]

Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo merged PR #1287:
URL: https://github.com/apache/ratis/pull/1287


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org