You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/14 16:41:03 UTC

[GitHub] [pulsar-client-go] crossoverJie commented on pull request #808: [Issue 387] fix goroutine leak for closing consumers.

crossoverJie commented on PR #808:
URL: https://github.com/apache/pulsar-client-go/pull/808#issuecomment-1184660129

   > Is there any chance that c.messageCh can be nil? Just wondering if we need a nil check around closing it since trying to close a nil channel can cause a panic. Otherwise LGTM
   
   Thanks for the reminder.
   https://github.com/apache/pulsar-client-go/blob/6a8e7f39aac100a285a2c190186e38b73a5c9d34/pulsar/consumer_impl.go#L101
   Initialization is done when the consumer is created.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org