You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/08/13 17:42:12 UTC

[jira] [Commented] (THRIFT-2662) python bindings generate incorrect indentation for functions after a oneway function

    [ https://issues.apache.org/jira/browse/THRIFT-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14095610#comment-14095610 ] 

ASF GitHub Bot commented on THRIFT-2662:
----------------------------------------

GitHub user virtuald opened a pull request:

    https://github.com/apache/thrift/pull/186

    THRIFT-2662 Fix incorrect indentation when oneway function is used

    https://issues.apache.org/jira/browse/THRIFT-2662

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/virtuald/thrift mainline_fix_indent

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/186.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #186
    
----
commit 2a848652c35ae2083059d23ed7155352a39cd611
Author: Dustin Spicuzza <du...@virtualroadside.com>
Date:   2014-08-12T21:48:44Z

    Fix incorrect indentation when oneway function is used

----


> python bindings generate incorrect indentation for functions after a oneway function
> ------------------------------------------------------------------------------------
>
>                 Key: THRIFT-2662
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2662
>             Project: Thrift
>          Issue Type: Bug
>          Components: Python - Compiler
>    Affects Versions: 0.9.1
>            Reporter: Dustin Spicuzza
>
> The following interface is generated incorrectly by the python bindings.
> {code}
> service RPC {
>    oneway void put(1:string topic),
>    binary get(1:string topic),
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)