[jira] [Resolved] (PROTON-663) codec.c pni_inspect_atom uses the wrong format for case PN_CHAR

["Fraser Adams (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/PROTON-663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Fraser Adams resolved PROTON-663.
---------------------------------
    Resolution: Fixed

Changed to

  case PN_CHAR:
    return pn_string_addf(str, "%c",  atom->u.as_char);

Now compiles cleanly with both gcc and Clang

> codec.c pni_inspect_atom uses the wrong format for case PN_CHAR
> ---------------------------------------------------------------
>
>                 Key: PROTON-663
>                 URL: https://issues.apache.org/jira/browse/PROTON-663
>             Project: Qpid Proton
>          Issue Type: Bug
>            Reporter: Fraser Adams
>
> In codec.c pni_inspect_atom
> case PN_CHAR
> Clang reports the following
> warning: 
>       format specifies type 'wint_t' (aka 'int') but the argument has type
>       'pn_char_t' (aka 'unsigned int') [-Wformat]
>     return pn_string_addf(str, "%lc",  atom->u.as_char);
>                                 ~~~    ^~~~~~~~~~~~~~~
>                                 %c
> The line should read 
>   case PN_CHAR:
>     return pn_string_addf(str, "%c",  atom->u.as_char);



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)