You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by GitBox <gi...@apache.org> on 2020/04/30 15:26:07 UTC
[GitHub] [jena] afs opened a new pull request #738: JENA-1891: Correct StrMin and StrMax messages
afs opened a new pull request #738:
URL: https://github.com/apache/jena/pull/738
[JENA-1891](https://issues.apache.org/jira/browse/JENA-1891)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] lrncfly commented on a change in pull request #738: JENA-1891: Correct StrMin and StrMax messages
Posted by GitBox <gi...@apache.org>.
lrncfly commented on a change in pull request #738:
URL: https://github.com/apache/jena/pull/738#discussion_r418300056
##########
File path: jena-shacl/src/main/java/org/apache/jena/shacl/engine/constraint/StrMinLengthConstraint.java
##########
@@ -45,7 +45,7 @@ public ReportItem validate(ValidationContext vCxt, Node n) {
String str = NodeFunctions.str(n);
if ( str.length() >= minLength )
return null;
- String msg = toString()+": String too long: "+str;
+ String msg = toString()+": String not long enough: "+str;
Review comment:
`String too short` would be better in my opinion
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on pull request #738: JENA-1891: Correct StrMin and StrMax messages
Posted by GitBox <gi...@apache.org>.
afs commented on pull request #738:
URL: https://github.com/apache/jena/pull/738#issuecomment-622386297
Closed in favour of #739.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org