[GitHub] [tvm] areusch commented on a change in pull request #9018: [microTVM][autoTVM] Follow up fixes to #9003

[GitBox <gi...@apache.org>]

areusch commented on a change in pull request #9018:
URL: https://github.com/apache/tvm/pull/9018#discussion_r710209423



##########
File path: src/runtime/rpc/rpc_endpoint.cc
##########
@@ -692,12 +692,12 @@ void RPCEndpoint::Init() {
  */
 std::shared_ptr<RPCEndpoint> RPCEndpoint::Create(std::unique_ptr<RPCChannel> channel,
                                                  std::string name, std::string remote_key,
-                                                 TypedPackedFunc<void()> fshutdown) {
+                                                 TypedPackedFunc<void()> fcleanup) {

Review comment:
       can you add fcleanup to the docs above?

##########
File path: src/runtime/crt/host/Makefile
##########
@@ -38,7 +42,7 @@ CRT_LIBS = $(patsubst %, $(BUILD_DIR)/crt/lib%.a, $(CRT_LIB_NAMES))
 CRT_INCLUDES = $(glob crt/include/**)
 
 $(BUILD_DIR)/crt/lib%.a: $(glob crt/src/runtime/%/*.c)
-	${QUIET}cd crt && $(MAKE) \
+	${QUIET}cd crt && $(MAKE) -s \

Review comment:
       do you need this and verbose?

##########
File path: python/tvm/micro/session.py
##########
@@ -144,8 +146,10 @@ def __exit__(self, exc_type, exc_value, exc_traceback):
         """Tear down this session and associated RPC session resources."""
         self.transport.__exit__(exc_type, exc_value, exc_traceback)
 
-    def _shutdown(self):
-        self.__exit__(None, None, None)
+    def _cleanup(self):
+        if not self._exit_called:

Review comment:
       can we move this conditional inside `__exit__`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org