[GitHub] [airflow] potiuk commented on pull request #16754: Only allow webserver to request from the worker log server

[GitBox <gi...@apache.org>]

potiuk commented on pull request #16754:
URL: https://github.com/apache/airflow/pull/16754#issuecomment-882102892


   > Edit: I thought you meant fernet key by secret key. I understood that you actually meant AIRFLOW__WEBSERVER__SECRET_KEY. It's kind of tough to understand which components need the same configuration.
   
   All components of Airflow needs exactly the same configuration. FULL CONFIGURATION. Correct me please, if I am wrong but nowhere in documentation it is stated otherwise. This is the default mode for Airflow and it's always been like that.
   
   I think it is pretty brave (and completely unnecessary) to decide on having some parts of configuration available here and unavailable there without fully realising the consequences. 
   
   By default you should have:
   
   * the same images for all airflow components
   * the same dependencies for all Airflow components
   * the same configuration for all Airlfow components
   
   If you try to approach it differently, you might hit all kinds of problems and unless you exactly know what you are doing, you should avoid it (and even that you open-up to future changes that might - like in this case - base on the assumptions that your configuration is the same for all components.
   
   Just wondering @tunix  - where the idea that different components should have different configuration came from? Is this something implied? Or something that you found in the documentation? Should we make it very explicit in our documentation that you are not supposed to selectively set some configuration parameters on some components?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org