You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by DaanHoogland <gi...@git.apache.org> on 2015/06/29 15:10:43 UTC
[GitHub] cloudstack pull request: findbugs: impossible cast(s) fixed by cha...
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/538
findbugs: impossible cast(s) fixed by changing field types
By model of Laszlo's earlier changes, this one was bothering me as the model was a litle more complex at first sight. Turns out it is exactly the same as for instance details in CreateSecondaryStagingStoreCmd
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DaanHoogland/cloudstack findbugs-BC
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/538.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #538
----
commit 044fcf4c18c284fad505187d5769b2a15929ac10
Author: Daan Hoogland <da...@gmail.com>
Date: 2015-06-29T13:07:34Z
findbugs: impossible cast(s) fixed by changing field types
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: findbugs: impossible cast(s) fixed by cha...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/538#issuecomment-118848745
LGTM.
Please proceed with merge
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: findbugs: impossible cast(s) fixed by cha...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/538#issuecomment-117022539
Changes looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: findbugs: impossible cast(s) fixed by cha...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/538
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: findbugs: impossible cast(s) fixed by cha...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/538#issuecomment-117444046
Hi @DaanHoogland
@K0zka als added a unit tests to cover his changes. Check this class: CreateSecondaryStagingStoreCmdTest
Any chance to get one to cover your changes as well?
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---