You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by jackylk <gi...@git.apache.org> on 2017/09/10 01:37:23 UTC

[GitHub] carbondata pull request #1344: [BUGFIX] Fix incorrect type cast

GitHub user jackylk opened a pull request:

    https://github.com/apache/carbondata/pull/1344

    [BUGFIX] Fix incorrect type cast

    Fix incorrect type cast for date filter

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jackylk/incubator-carbondata patch-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1344.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1344
    
----
commit ae7da06d9e36ccf56d147b4f6a60ed67191a47b4
Author: Jacky Li <ja...@huawei.com>
Date:   2017-09-10T01:32:15Z

    [BUGFIX] Fix incorrect type cast
    
    Fix incorrect type cast for date filter

----


---

[GitHub] carbondata issue #1344: [BUGFIX] Fix incorrect type cast

Posted by ravipesala <gi...@git.apache.org>.

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1344
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/635/



---

[GitHub] carbondata pull request #1344: [BUGFIX] Fix incorrect type cast

Posted by jackylk <gi...@git.apache.org>.

Github user jackylk closed the pull request at:

    https://github.com/apache/carbondata/pull/1344


---

[GitHub] carbondata pull request #1344: [BUGFIX] Fix incorrect type cast

Posted by ravipesala <gi...@git.apache.org>.

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1344#discussion_r137939432
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/expression/ExpressionResult.java ---
    @@ -187,7 +187,7 @@ public String getString() throws FilterIllegalMemberException {
                 }
                 return parser.format(new Timestamp((long) value));
               } else if (value instanceof Integer) {
    -            return parser.format(new java.sql.Date((long)value));
    +            return parser.format(new java.sql.Date((int) value));
    --- End diff --
    
    Please check PR 1254


---