You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by ch...@apache.org on 2022/08/15 13:18:46 UTC

[incubator-kyuubi] branch master updated: [KYUUBI #3220] Make kyuubi.engine.ui.stop.enabled false in HistoryServer

This is an automated email from the ASF dual-hosted git repository.

chengpan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-kyuubi.git


The following commit(s) were added to refs/heads/master by this push:
     new 76b44c980 [KYUUBI #3220] Make kyuubi.engine.ui.stop.enabled false in HistoryServer
76b44c980 is described below

commit 76b44c980ec133d9eefa686eb92622014cf19dfb
Author: Wang Zhen <wa...@qiyi.com>
AuthorDate: Mon Aug 15 21:18:35 2022 +0800

    [KYUUBI #3220] Make kyuubi.engine.ui.stop.enabled false in HistoryServer
    
    ### _Why are the changes needed?_
    
    close #3220
    
    ### _How was this patch tested?_
    - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
    
    - [X] Add screenshots for manual tests if appropriate
    ![image](https://user-images.githubusercontent.com/17894939/184284124-018023c9-0e27-43c9-a4ab-f4c9214849eb.png)
    
    - [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
    
    Closes #3221 from wForget/KYUUBI-3220.
    
    Closes #3220
    
    ed3f596c [Wang Zhen] [KYUUBI-3220] Make kyuubi.engine.ui.stop.enabled false in HistoryServer
    
    Authored-by: Wang Zhen <wa...@qiyi.com>
    Signed-off-by: Cheng Pan <ch...@apache.org>
---
 .../src/main/scala/org/apache/spark/ui/KyuubiHistoryServerPlugin.scala | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/spark/ui/KyuubiHistoryServerPlugin.scala b/externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/spark/ui/KyuubiHistoryServerPlugin.scala
index f2eb96dde..47084686d 100644
--- a/externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/spark/ui/KyuubiHistoryServerPlugin.scala
+++ b/externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/spark/ui/KyuubiHistoryServerPlugin.scala
@@ -41,9 +41,10 @@ class KyuubiHistoryServerPlugin extends AppHistoryServerPlugin {
   }
 
   override def setupUI(ui: SparkUI): Unit = {
-    val kyuubiConf = mergedKyuubiConf(ui.conf)
     val store = new EngineEventsStore(ui.store.store)
     if (store.getSessionCount > 0) {
+      val kyuubiConf = mergedKyuubiConf(ui.conf)
+      kyuubiConf.set(KyuubiConf.ENGINE_UI_STOP_ENABLED, false)
       EngineTab(
         None,
         Some(ui),