You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "xixipi-lining (via GitHub)" <gi...@apache.org> on 2025/08/21 06:39:17 UTC

[PR] refactor(catalog/internal): Improve error handling in WriteTableMetadata and WriteMetadata functions [iceberg-go]

xixipi-lining opened a new pull request, #541:
URL: https://github.com/apache/iceberg-go/pull/541

   ### Changes
   
   - Updated the `WriteTableMetadata` and `WriteMetadata` functions to use `errors.Join` for better error handling, ensuring that both JSON encoding errors and file close errors are properly captured and returned.
   - This fix is particularly important for S3 storage where the actual upload happens during `Close()`, and previous implementation would silently ignore S3 upload failures.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] refactor(catalog/internal): Improve error handling in WriteTableMetadata and WriteMetadata functions [iceberg-go]

Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #541:
URL: https://github.com/apache/iceberg-go/pull/541


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org