You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Konstantin Knauf (Jira)" <ji...@apache.org> on 2021/07/29 07:36:11 UTC
[jira] [Updated] (FLINK-16503) Don't assign
ScheduledExecutorService into variables of ExecutorService or Executor
types
[ https://issues.apache.org/jira/browse/FLINK-16503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Knauf updated FLINK-16503:
-------------------------------------
Labels: (was: auto-closed)
Priority: Not a Priority (was: Minor)
> Don't assign ScheduledExecutorService into variables of ExecutorService or Executor types
> -----------------------------------------------------------------------------------------
>
> Key: FLINK-16503
> URL: https://issues.apache.org/jira/browse/FLINK-16503
> Project: Flink
> Issue Type: Improvement
> Reporter: Roman Leventov
> Priority: Not a Priority
>
> There is an unnecessary efficiency cost to assigning ScheduledExecutorService (typically, ScheduledThreadPoolExecutor) into variables of ExecutorService or Executor types.
> Currently, there is one such occurrence in production code, in TaskManagerRunner, and three more in tests.
> They could be found using IntelliJ's Structural search pattern (and Structural Search inspection):
> {{$x$ = $y$;}}
> Where the Type of {{$x$}} is set to {{ExecutorService|Executor}} ("within type hierarchy" checkbox is off), and the Type of {{$y$}} is set to {{ScheduledThreadPoolExecutor }}("within type hierarchy" checkbox is on).
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)