You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "brbzull0 (via GitHub)" <gi...@apache.org> on 2023/03/07 12:54:00 UTC

[GitHub] [trafficserver] brbzull0 opened a new pull request, #9504: records.yaml - Fix record name comparison logic.

brbzull0 opened a new pull request, #9504:
URL: https://github.com/apache/trafficserver/pull/9504

   There was a bug when you were trying to get a record by name from the registered records. Without this fix you could request  for instance a shorter record name and the comparison will still be valid.
   
   So you could have configured:
   ```yaml
   ts:
     diags:
       enable: 1 # note the missing "n" at the end. 
   ```
   and still be valid, even though the registered record is: `proxy.config.diags.debug.enabled`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficserver] brbzull0 merged pull request #9504: records.yaml - Fix record name comparison logic.

Posted by "brbzull0 (via GitHub)" <gi...@apache.org>.
brbzull0 merged PR #9504:
URL: https://github.com/apache/trafficserver/pull/9504


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficserver] shukitchan commented on pull request #9504: records.yaml - Fix record name comparison logic.

Posted by "shukitchan (via GitHub)" <gi...@apache.org>.
shukitchan commented on PR #9504:
URL: https://github.com/apache/trafficserver/pull/9504#issuecomment-1458561511

   I think you mean "d" in the above use case. right ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficserver] brbzull0 commented on pull request #9504: records.yaml - Fix record name comparison logic.

Posted by "brbzull0 (via GitHub)" <gi...@apache.org>.
brbzull0 commented on PR #9504:
URL: https://github.com/apache/trafficserver/pull/9504#issuecomment-1458564575

   > I think you mean "d" in the above use case. right ?
   
   yes, that's what I meant, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org