[GitHub] mitchell852 commented on a change in pull request #2348: Implement Traffic Portal Coordinates CRUD

[GitBox <gi...@apache.org>]

mitchell852 commented on a change in pull request #2348: Implement Traffic Portal Coordinates CRUD
URL: https://github.com/apache/incubator-trafficcontrol/pull/2348#discussion_r191900567
 
 

 ##########
 File path: traffic_portal/app/src/common/modules/form/cacheGroup/form.cacheGroup.tpl.html
 ##########
 @@ -85,18 +85,20 @@
             <div class="form-group" ng-class="{'has-error': hasError(cacheGroupForm.latitude), 'has-feedback': hasError(cacheGroupForm.latitude)}">
                 <label class="control-label col-md-2 col-sm-2 col-xs-12">Geo Magnetic Latitude *</label>
                 <div class="col-md-10 col-sm-10 col-xs-12">
-                    <input name="latitude" type="number" class="form-control" ng-model="cacheGroup.latitude" ng-pattern="/^[-+]?[0-9]*\.?[0-9]+$/" required autofocus>
-                    <small class="input-error" ng-show="hasPropertyError(cacheGroupForm.latitude, 'required')">Required Coordinate</small>
-                    <small class="input-error" ng-show="hasPropertyError(cacheGroupForm.latitude, 'pattern')">Invalid Coordinate</small>
+                    <input name="latitude" type="number" class="form-control" ng-model="cacheGroup.latitude" ng-min="-90.0" ng-max="90.0" required autofocus>
+                    <small class="input-error" ng-show="hasPropertyError(cacheGroupForm.latitude, 'required')">Required latitude</small>
+                    <small class="input-error" ng-show="hasPropertyError(cacheGroupForm.latitude, 'min')">Invalid latitude</small>
 
 Review comment:
   how about 
   
   "Invalid latitude. Must be between -90.0 and 90.0"
   
   for the latitude challenged. same for longitude.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services