[GitHub] [echarts] pissang commented on a change in pull request #14243: fix(visualMap): use itemSymbol as default symbol type and fix #5719

[GitBox <gi...@apache.org>]

pissang commented on a change in pull request #14243:
URL: https://github.com/apache/echarts/pull/14243#discussion_r603756637



##########
File path: src/component/visualMap/VisualMapModel.ts
##########
@@ -511,7 +516,7 @@ class VisualMapModel<Opts extends VisualMapOption = VisualMapOption> extends Com
 
                 // Filter square and none.
                 visuals.symbol = mapVisual(visuals.symbol, function (symbol) {
-                    return (symbol === 'none' || symbol === 'square') ? 'roundRect' : symbol;
+                    return (symbol === 'none' || symbol === 'square') ? defaultSymbol : symbol;

Review comment:
       @100pah Do you still remember why the `'square'` symbol needs to be filtered?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org