[jira] [Issue Comment Edited] (HBASE-4336) Convert source tree into maven modules

["Ted Yu (Issue Comment Edited) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-4336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13112206#comment-13112206 ] 

Ted Yu edited comment on HBASE-4336 at 11/27/11 5:45 PM:
---------------------------------------------------------

Unfortunately, the top level folder needs to just be a pom, so making it package into 1 nice jar is out. Which makes it necessary to move the source down a level in the hierarchy. With the move though, I was planning on making the folders essentially the same, but 1 level down.

So hbase/src/main/java/org/apache/hbase/thing becomes hbase/hbase-{core|security|server|it}/src/main/java/org/apache/hbase/thing

The move for the code in the patches is pretty minimal. Also, when do the rebasing, I _think_ git will handle reapplying your patches on top of the moved files (which it recognizes is moved). Of course, I'm assuming here that everyone uses git ;)

TL;DR not really, as dictated by maven. Its gonna be painful, but once its done, it will be much nicer.
                
      was (Author: jesse_yates):
    Unfortunately, the top level folder needs to just be a pom, so making it package into 1 nice jar is out. Which makes it necessary to move the source down a level in the hierarchy. With the move though, I was planning on making the folders essentially the same, but 1 level down.

So hbase/src/main/java/org/apache/hbase/thing -> hbase/hbase-{core|security|server|it}/src/main/java/org/apache/hbase/thing

The move for the code in the patches is pretty minimal. Also, when do the rebasing, I _think_ git will handle reapplying your patches on top of the moved files (which it recognizes is moved). Of course, I'm assuming here that everyone uses git ;)

TL;DR not really, as dictated by maven. Its gonna be painful, but once its done, it will be much nicer.
                  
> Convert source tree into maven modules
> --------------------------------------
>
>                 Key: HBASE-4336
>                 URL: https://issues.apache.org/jira/browse/HBASE-4336
>             Project: HBase
>          Issue Type: Task
>          Components: build
>            Reporter: Gary Helmling
>
> When we originally converted the build to maven we had a single "core" module defined, but later reverted this to a module-less build for the sake of simplicity.
> It now looks like it's time to re-address this, as we have an actual need for modules to:
> * provide a trimmed down "client" library that applications can make use of
> * more cleanly support building against different versions of Hadoop, in place of some of the reflection machinations currently required
> * incorporate the secure RPC engine that depends on some secure Hadoop classes
> I propose we start simply by refactoring into two initial modules:
> * core - common classes and utilities, and client-side code and interfaces
> * server - master and region server implementations and supporting code
> This would also lay the groundwork for incorporating the HBase security features that have been developed.  Once the module structure is in place, security-related features could then be incorporated into a third module -- "security" -- after normal review and approval.  The security module could then depend on secure Hadoop, without modifying the dependencies of the rest of the HBase code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira