You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@metron.apache.org by GitBox <gi...@apache.org> on 2019/01/08 14:57:55 UTC

[GitHub] justinleet commented on issue #1299: METRON-1929: Build GET_ASN Stellar function

justinleet commented on issue #1299: METRON-1929: Build GET_ASN Stellar function
URL: https://github.com/apache/metron/pull/1299#issuecomment-452327823
 
 
   @nickwallen 
   
   Re: license. The GeoLite2 databases are fine license-wise (CC-BY) and have attribution.  If it were the commercial/enterprise DBs, we wouldn't be able to include them as they're under a separate license.
   
   The review comments should be addressed, but obviously let me know if you want any adjustments or if I missed anything.  There was a lot of good stuff and I'm glad you went over things thoroughly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services