You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/04/25 19:25:20 UTC
[GitHub] [lucene] risdenk opened a new pull request, #837: LUCENE-10534: MinFloatFunction / MaxFloatFunction exists check can be slow
risdenk opened a new pull request, #837:
URL: https://github.com/apache/lucene/pull/837
# Description
`MinFloatFunction` and `MaxFloatFunction` currently check if values exist which can happen twice in the worst case.
# Solution
This rearranges the logic to only check if values exist when `0.0f` is returned to check if it is a real value from the document or there is no value in the document.
# Tests
The existing tests covered the logic cases for this.
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/lucene/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Lucene maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] risdenk merged pull request #837: LUCENE-10534: MinFloatFunction / MaxFloatFunction calls exists twice
Posted by GitBox <gi...@apache.org>.
risdenk merged PR #837:
URL: https://github.com/apache/lucene/pull/837
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org