You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "VampireAchao (via GitHub)" <gi...@apache.org> on 2023/05/02 15:42:24 UTC
[GitHub] [shenyu] VampireAchao opened a new pull request, #4604: add test case for PortUtils.findPort
VampireAchao opened a new pull request, #4604:
URL: https://github.com/apache/shenyu/pull/4604
<!-- Describe your PR here; eg. Fixes #issueNo -->
<!--
Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
-->
Make sure that:
- [x] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
- [x] You submit test cases (unit or integration tests) that back your changes.
- [x] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] dengliming commented on pull request #4604: add test case for PortUtils.findPort
Posted by "dengliming (via GitHub)" <gi...@apache.org>.
dengliming commented on PR #4604:
URL: https://github.com/apache/shenyu/pull/4604#issuecomment-1532703542
<img width="1462" alt="image" src="https://user-images.githubusercontent.com/7796156/235878142-8da201a9-8c2c-4353-b0ff-e5f3acf4f6c5.png">
@VampireAchao Did you forget to submit the code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] VampireAchao commented on pull request #4604: add test case for PortUtils.findPort
Posted by "VampireAchao (via GitHub)" <gi...@apache.org>.
VampireAchao commented on PR #4604:
URL: https://github.com/apache/shenyu/pull/4604#issuecomment-1531710843
[blone](https://github.com/apache/shenyu/issues/4544)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] VampireAchao commented on pull request #4604: add test case for PortUtils.findPort
Posted by "VampireAchao (via GitHub)" <gi...@apache.org>.
VampireAchao commented on PR #4604:
URL: https://github.com/apache/shenyu/pull/4604#issuecomment-1532818920
I'm sooooooo sorry!Now the code is here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] codecov-commenter commented on pull request #4604: add test case for PortUtils.findPort
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4604:
URL: https://github.com/apache/shenyu/pull/4604#issuecomment-1532878557
## [Codecov](https://app.codecov.io/gh/apache/shenyu/pull/4604?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#4604](https://app.codecov.io/gh/apache/shenyu/pull/4604?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fec8a22) into [master](https://app.codecov.io/gh/apache/shenyu/commit/1e678f4519a7a169132b03cf57a1bb7a9bceb4de?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1e678f4) will **decrease** coverage by `1.12%`.
> The diff coverage is `n/a`.
> :exclamation: Current head fec8a22 differs from pull request most recent head 2b39d40. Consider uploading reports for the commit 2b39d40 to get more accurate results
```diff
@@ Coverage Diff @@
## master #4604 +/- ##
============================================
- Coverage 68.72% 67.61% -1.12%
+ Complexity 7818 7816 -2
============================================
Files 1041 1063 +22
Lines 30047 30542 +495
Branches 2735 2781 +46
============================================
+ Hits 20650 20651 +1
- Misses 7769 8268 +499
+ Partials 1628 1623 -5
```
[see 34 files with indirect coverage changes](https://app.codecov.io/gh/apache/shenyu/pull/4604/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] dengliming merged pull request #4604: add test case for PortUtils.findPort
Posted by "dengliming (via GitHub)" <gi...@apache.org>.
dengliming merged PR #4604:
URL: https://github.com/apache/shenyu/pull/4604
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org