You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2026/04/16 21:11:25 UTC
[PR] fix: remove spurious .flatten call that garbled SortMergeJoin fallback messages [datafusion-comet]
andygrove opened a new pull request, #3968:
URL: https://github.com/apache/datafusion-comet/pull/3968
## Summary
Fixes #3967.
When `SortMergeJoin` falls back to Spark due to an unsupported join key type (e.g. `TimestampType`), the fallback message was rendered as a garbled list of individual characters like `[COMET: e, s, n, j, y, T, t, ...]` instead of the expected `[COMET: Unsupported join key type TimestampType on key: <col>]`.
**Root cause:** `join.leftKeys.flatMap { ... }` already returns a `Seq[String]` (the `flatMap` unwraps the `Option[String]`). Calling `.flatten` again on a `Seq[String]` triggers Scala's implicit `String → Iterable[Char]` conversion, exploding each message string into individual characters. The fix removes the redundant `.flatten` call.
## Test plan
- [ ] Manually verify fallback message is readable when a `SortMergeJoin` has an unsupported key type such as `TimestampType`
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: remove spurious .flatten call that garbled SortMergeJoin fallback messages [datafusion-comet]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead merged PR #3968:
URL: https://github.com/apache/datafusion-comet/pull/3968
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org