[GitHub] [cloudstack] andrijapanicsb commented on a diff in pull request #6942: ssvm: synchorise when adding iptables and routing rules

[GitBox <gi...@apache.org>]

andrijapanicsb commented on code in PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#discussion_r1065498870


##########
services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java:
##########
@@ -2225,7 +2225,7 @@ private String deleteLocalFile(String fullPath) {
         return null;
     }
 
-    public String allowOutgoingOnPrivate(String destCidr) {
+    public synchronized String allowOutgoingOnPrivate(String destCidr) {

Review Comment:
   Could not be reproduced (the bug), so the solution as well could not be verified. The customer has confirmed (by testing in their env) that the "synchronized" seems to solve the issue on their end.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org