You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2014/08/05 22:14:12 UTC

[jira] [Commented] (HBASE-8896) Refactor RetryCounter so it is generally useful

    [ https://issues.apache.org/jira/browse/HBASE-8896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14086683#comment-14086683 ] 

Hadoop QA commented on HBASE-8896:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12591271/8896.txt
  against trunk revision .
  ATTACHMENT ID: 12591271

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 2 new or modified tests.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10300//console

This message is automatically generated.

> Refactor RetryCounter so it is generally useful
> -----------------------------------------------
>
>                 Key: HBASE-8896
>                 URL: https://issues.apache.org/jira/browse/HBASE-8896
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: stack
>            Assignee: stack
>              Labels: beginner
>         Attachments: 8896.txt
>
>
> RetryCounter is a useful looking endeavor that is half done.   Notion is a class to manage retry and the sleep between retries.  We retry everywhere so this could save code.  There is a half-done factory too that is used currently just by RecoverableZooKeeper.  The factory only produces one RetryCounter type.  It's purpose seems to be just save on having to have configs available everywhere we want to do retrying.



--
This message was sent by Atlassian JIRA
(v6.2#6252)