You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/09/09 09:50:50 UTC
[GitHub] [nifi] bejancsaba commented on a diff in pull request #6376: NIFI-10455 Get workday report processor
bejancsaba commented on code in PR #6376:
URL: https://github.com/apache/nifi/pull/6376#discussion_r966777791
##########
nifi-nar-bundles/nifi-workday-bundle/nifi-workday-processors/src/main/java/org/apache/nifi/processors/workday/GetWorkdayReport.java:
##########
@@ -0,0 +1,432 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.processors.workday;
+
+import static org.apache.nifi.expression.ExpressionLanguageScope.FLOWFILE_ATTRIBUTES;
+import static org.apache.nifi.expression.ExpressionLanguageScope.NONE;
+import static org.apache.nifi.processor.util.StandardValidators.NON_BLANK_VALIDATOR;
+import static org.apache.nifi.processor.util.StandardValidators.URL_VALIDATOR;
+
+import java.io.BufferedInputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.OutputStream;
+import java.net.URI;
+import java.nio.charset.StandardCharsets;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Base64;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.regex.Pattern;
+import java.util.stream.Collectors;
+import org.apache.nifi.annotation.behavior.EventDriven;
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.behavior.InputRequirement.Requirement;
+import org.apache.nifi.annotation.behavior.SideEffectFree;
+import org.apache.nifi.annotation.behavior.SupportsBatching;
+import org.apache.nifi.annotation.behavior.WritesAttribute;
+import org.apache.nifi.annotation.behavior.WritesAttributes;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnScheduled;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.flowfile.attributes.CoreAttributes;
+import org.apache.nifi.logging.ComponentLog;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.record.path.RecordPath;
+import org.apache.nifi.record.path.RecordPathResult;
+import org.apache.nifi.schema.access.SchemaNotFoundException;
+import org.apache.nifi.security.util.crypto.HashAlgorithm;
+import org.apache.nifi.security.util.crypto.HashService;
+import org.apache.nifi.serialization.MalformedRecordException;
+import org.apache.nifi.serialization.RecordReader;
+import org.apache.nifi.serialization.RecordReaderFactory;
+import org.apache.nifi.serialization.RecordSetWriter;
+import org.apache.nifi.serialization.RecordSetWriterFactory;
+import org.apache.nifi.serialization.record.Record;
+import org.apache.nifi.serialization.record.RecordFieldType;
+import org.apache.nifi.serialization.record.RecordSchema;
+import org.apache.nifi.web.client.api.HttpResponseEntity;
+import org.apache.nifi.web.client.api.WebClientService;
+import org.apache.nifi.web.client.provider.api.WebClientServiceProvider;
+
+@Tags({"Workday", "report", "get"})
Review Comment:
Do we need "get" tag here? It seems very general.
##########
nifi-nar-bundles/nifi-workday-bundle/nifi-workday-processors/src/main/resources/docs/org.apache.nifi.processors.workday.GetWorkdayReport/additionalDetails.html:
##########
@@ -0,0 +1,103 @@
+<!DOCTYPE html>
+<html lang="en">
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+ http://www.apache.org/licenses/LICENSE-2.0
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+<head>
+ <meta charset="utf-8"/>
+ <title>GetWorkdayReport</title>
+ <link rel="stylesheet" href="../../../../../css/component-usage.css" type="text/css"/>
+</head>
+
+<body>
+<h2>Summary</h2>
+<p>
+ This processor acts as a client endpoint to interact with the Workday API.
+ It is capable of reading reports from Workday RaaS and transferring the content directly to the output, or you can define
+ the required Record Reader and RecordSet Writer, so you can transform the report to the required format.
+</p>
+
+<h2>Supported report formats</h2>
+
+<ul>
+ <li>csv</li>
+ <li>simplexml</li>
+ <li>json</li>
+</ul>
+
+<p>
+ In case of json source you need to set the following parameters in the JsonTreeReader:
+ <ul>
+ <li>Starting Field Strategy: Nested Field</li>
+ <li>Starting Field Name: Report_Entry</li>
+ </ul>
+</p>
+
+<p>
+ It is possible to hide specific columns from the response if you define the Writer scheme explicitly in the configuration of the RecordSet Writer.
+</p>
+
+<h2>
+ Example: Remove name2 column from the response
+</h2>
+<p>
+ Let's say we have the following record structure:
+</p>
+<code>
+ <pre>
+ RecordSet (
+ Record (
+ Field "name1" = "value1",
+ Field "name2" = 42
+ ),
+ Record (
+ Field "name1" = "value2",
+ Field "name2" = 84
+ )
+ )
+ </pre>
+</code>
+
+<p>
+ If you would like to remove the "name2" column from the response, then you need to define the following writer schema:
+</p>
+
+<code>
+ <pre>
+ {
+ "name": "test",
+ "namespace": "nifi",
+ "type": "record",
+ "fields": [
+ { "name": "name1", "type": "string" }
+ ]
+ }
+ </pre>
+</code>
+
+<h2>
+ Example: Hash selected columns
+</h2>
+
+<p>
+ If you would like to keep a column in the response, but hash the value, you can do it by defining the record path selector and a hashing algorithm.
+ <ul>
+ <li>Columns to hash: /personalId,/emailAddress</li>
+ <li>Hashing algorithm: SHA-512</li>
+ </ul>
+ The above example hashes the PersonalId and emailAddress columns.
Review Comment:
```suggestion
The above example hashes the personalId and emailAddress columns.
```
##########
nifi-nar-bundles/nifi-workday-bundle/nifi-workday-processors/src/main/java/org/apache/nifi/processors/workday/GetWorkdayReport.java:
##########
@@ -0,0 +1,432 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.processors.workday;
+
+import static org.apache.nifi.expression.ExpressionLanguageScope.FLOWFILE_ATTRIBUTES;
+import static org.apache.nifi.expression.ExpressionLanguageScope.NONE;
+import static org.apache.nifi.processor.util.StandardValidators.NON_BLANK_VALIDATOR;
+import static org.apache.nifi.processor.util.StandardValidators.URL_VALIDATOR;
+
+import java.io.BufferedInputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.OutputStream;
+import java.net.URI;
+import java.nio.charset.StandardCharsets;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Base64;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.regex.Pattern;
+import java.util.stream.Collectors;
+import org.apache.nifi.annotation.behavior.EventDriven;
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.behavior.InputRequirement.Requirement;
+import org.apache.nifi.annotation.behavior.SideEffectFree;
+import org.apache.nifi.annotation.behavior.SupportsBatching;
+import org.apache.nifi.annotation.behavior.WritesAttribute;
+import org.apache.nifi.annotation.behavior.WritesAttributes;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnScheduled;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.flowfile.attributes.CoreAttributes;
+import org.apache.nifi.logging.ComponentLog;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.record.path.RecordPath;
+import org.apache.nifi.record.path.RecordPathResult;
+import org.apache.nifi.schema.access.SchemaNotFoundException;
+import org.apache.nifi.security.util.crypto.HashAlgorithm;
+import org.apache.nifi.security.util.crypto.HashService;
+import org.apache.nifi.serialization.MalformedRecordException;
+import org.apache.nifi.serialization.RecordReader;
+import org.apache.nifi.serialization.RecordReaderFactory;
+import org.apache.nifi.serialization.RecordSetWriter;
+import org.apache.nifi.serialization.RecordSetWriterFactory;
+import org.apache.nifi.serialization.record.Record;
+import org.apache.nifi.serialization.record.RecordFieldType;
+import org.apache.nifi.serialization.record.RecordSchema;
+import org.apache.nifi.web.client.api.HttpResponseEntity;
+import org.apache.nifi.web.client.api.WebClientService;
+import org.apache.nifi.web.client.provider.api.WebClientServiceProvider;
+
+@Tags({"Workday", "report", "get"})
+@InputRequirement(Requirement.INPUT_ALLOWED)
+@CapabilityDescription("A processor which can interact with a configurable Workday Report. The processor can forward the content without modification, or you can transform it by"
+ + " providing the specific Record Reader and Record Writer services based on your needs. You can also hash, or remove fields using the input parameters and schemes in the Record writer. "
+ + "Supported Workday report formats are: csv, simplexml, json")
+@EventDriven
+@SideEffectFree
+@SupportsBatching
+@WritesAttributes({
+ @WritesAttribute(attribute = GetWorkdayReport.GET_WORKDAY_REPORT_JAVA_EXCEPTION_CLASS, description = "The Java exception class raised when the processor fails"),
+ @WritesAttribute(attribute = GetWorkdayReport.GET_WORKDAY_REPORT_JAVA_EXCEPTION_MESSAGE, description = "The Java exception message raised when the processor fails"),
+ @WritesAttribute(attribute = "mime.type", description = "Sets the mime.type attribute to the MIME Type specified by the Source / Record Writer"),
+ @WritesAttribute(attribute= GetWorkdayReport.RECORD_COUNT, description = "The number of records in an outgoing FlowFile. This is only populated on the 'success' relationship "
+ + "when Record Reader and Writer is set.")})
+public class GetWorkdayReport extends AbstractProcessor {
+
+ protected static final String STATUS_CODE = "getworkdayreport.status.code";
+ protected static final String REQUEST_URL = "getworkdayreport.request.url";
+ protected static final String REQUEST_DURATION = "getworkdayreport.request.duration";
+ protected static final String TRANSACTION_ID = "getworkdayreport.tx.id";
+ protected static final String GET_WORKDAY_REPORT_JAVA_EXCEPTION_CLASS = "getworkdayreport.java.exception.class";
+ protected static final String GET_WORKDAY_REPORT_JAVA_EXCEPTION_MESSAGE = "getworkdayreport.java.exception.message";
+ protected static final String RECORD_COUNT = "record.count";
+ protected static final String BASIC_PREFIX = "Basic ";
+ protected static final String COLUMNS_TO_HASH_SEPARATOR = ",";
+ protected static final String HEADER_AUTHORIZATION = "Authorization";
+ protected static final String HEADER_CONTENT_TYPE = "Content-Type";
+ protected static final String USERNAME_PASSWORD_SEPARATOR = ":";
+
+ protected static final PropertyDescriptor REPORT_URL = new PropertyDescriptor.Builder()
+ .name("Workday report URL")
+ .displayName("Workday report URL")
+ .description("HTTP remote URL of Workday report including a scheme of http or https, as well as a hostname or IP address with optional port and path elements.")
+ .required(true)
+ .expressionLanguageSupported(FLOWFILE_ATTRIBUTES)
+ .addValidator(URL_VALIDATOR)
+ .build();
+
+ protected static final PropertyDescriptor WORKDAY_USERNAME = new PropertyDescriptor.Builder()
+ .name("Workday Username")
+ .displayName("Workday Username")
+ .description("The username provided for authentication of Workday requests. Encoded using Base64 for HTTP Basic Authentication as described in RFC 7617.")
+ .required(true)
+ .addValidator(StandardValidators.createRegexMatchingValidator(Pattern.compile("^[\\x20-\\x39\\x3b-\\x7e\\x80-\\xff]+$")))
+ .expressionLanguageSupported(FLOWFILE_ATTRIBUTES)
+ .build();
+
+ protected static final PropertyDescriptor WORKDAY_PASSWORD = new PropertyDescriptor.Builder()
+ .name("Workday Password")
+ .displayName("Workday Password")
+ .description("The password provided for authentication of Workday requests. Encoded using Base64 for HTTP Basic Authentication as described in RFC 7617.")
+ .required(true)
+ .sensitive(true)
+ .addValidator(StandardValidators.createRegexMatchingValidator(Pattern.compile("^[\\x20-\\x7e\\x80-\\xff]+$")))
+ .expressionLanguageSupported(FLOWFILE_ATTRIBUTES)
+ .build();
+
+ protected static final PropertyDescriptor WEB_CLIENT_SERVICE = new PropertyDescriptor.Builder()
+ .name("Standard Web Client Service")
+ .description("Web client which is used to communicate with the Workday API.")
+ .required(true)
+ .identifiesControllerService(WebClientServiceProvider.class)
+ .build();
+
+ protected static final PropertyDescriptor FIELDS_TO_HASH = new PropertyDescriptor.Builder()
+ .name("Fields to hash")
+ .displayName("Fields to hash")
+ .description("Comma separated record paths to replace with hash.")
+ .required(false)
+ .expressionLanguageSupported(FLOWFILE_ATTRIBUTES)
+ .addValidator(NON_BLANK_VALIDATOR)
+ .build();
+
+ protected static final PropertyDescriptor HASHING_ALGORITHM = new PropertyDescriptor.Builder()
+ .name("Hashing algorithm")
+ .displayName("Hashing algorithm")
+ .description("Determines what hashing algorithm should be used to perform the hashing function.")
+ .required(true)
+ .allowableValues(HashService.buildHashAlgorithmAllowableValues())
+ .defaultValue(HashAlgorithm.SHA256.getName())
+ .addValidator(NON_BLANK_VALIDATOR)
+ .expressionLanguageSupported(NONE)
+ .dependsOn(FIELDS_TO_HASH)
+ .build();
+
+ protected static final PropertyDescriptor RECORD_READER_FACTORY = new PropertyDescriptor.Builder()
+ .name("record-reader")
+ .displayName("Record Reader")
+ .description("Specifies the Controller Service to use for parsing incoming data and determining the data's schema.")
+ .identifiesControllerService(RecordReaderFactory.class)
+ .required(false)
+ .build();
+
+ protected static final PropertyDescriptor RECORD_WRITER_FACTORY = new PropertyDescriptor.Builder()
+ .name("record-writer")
+ .displayName("Record Writer")
+ .description("The Record Writer to use for serializing Records to an output FlowFile.")
+ .identifiesControllerService(RecordSetWriterFactory.class)
+ .dependsOn(RECORD_READER_FACTORY)
+ .required(true)
+ .build();
+
+ protected static final Relationship ORIGINAL = new Relationship.Builder()
+ .name("Original")
+ .description("Request FlowFiles transferred when receiving HTTP responses with a status code between 200 and 299.")
+ .build();
+
+ protected static final Relationship FAILURE = new Relationship.Builder()
+ .name("Failure")
+ .description("Request FlowFiles transferred when receiving socket communication errors.")
+ .build();
+
+ protected static final Relationship RESPONSE = new Relationship.Builder()
+ .name("Response")
+ .description("Response FlowFiles transferred when receiving HTTP responses with a status code between 200 and 299.")
+ .build();
+
+ protected static final Set<Relationship> RELATIONSHIPS = Collections.unmodifiableSet(new HashSet<>(Arrays.asList(ORIGINAL, RESPONSE, FAILURE)));
+ protected static final List<PropertyDescriptor> PROPERTIES = Collections.unmodifiableList(Arrays.asList(REPORT_URL, WORKDAY_USERNAME, WORKDAY_PASSWORD, WEB_CLIENT_SERVICE,
+ FIELDS_TO_HASH, HASHING_ALGORITHM, RECORD_READER_FACTORY, RECORD_WRITER_FACTORY));
+
+ private final AtomicReference<WebClientService> webClientAtomicReference = new AtomicReference<>();
+ private final AtomicReference<RecordReaderFactory> recordReaderFactoryAtomicReference = new AtomicReference<>();
+ private final AtomicReference<RecordSetWriterFactory> recordSetWriterFactoryAtomicReference = new AtomicReference<>();
+
+ @Override
+ protected List<PropertyDescriptor> getSupportedPropertyDescriptors() {
+ return PROPERTIES;
+ }
+
+ @Override
+ public Set<Relationship> getRelationships() {
+ return RELATIONSHIPS;
+ }
+
+ @OnScheduled
+ public void setUpClient(final ProcessContext context) {
+ WebClientServiceProvider standardWebClientServiceProvider = context.getProperty(WEB_CLIENT_SERVICE).asControllerService(WebClientServiceProvider.class);
+ RecordReaderFactory recordReaderFactory = context.getProperty(RECORD_READER_FACTORY).asControllerService(RecordReaderFactory.class);
+ RecordSetWriterFactory recordSetWriterFactory = context.getProperty(RECORD_WRITER_FACTORY).asControllerService(RecordSetWriterFactory.class);
+ WebClientService webClientService = standardWebClientServiceProvider.getWebClientService();
+ webClientAtomicReference.set(webClientService);
+ recordReaderFactoryAtomicReference.set(recordReaderFactory);
+ recordSetWriterFactoryAtomicReference.set(recordSetWriterFactory);
+ }
+
+ @Override
+ public void onTrigger(ProcessContext context, ProcessSession session) throws ProcessException {
+ FlowFile flowfile = session.get();
+
+ if (skipExecution(context, flowfile)) {
+ return;
+ }
+
+ ComponentLog logger = getLogger();
+ FlowFile responseFlowFile = null;
+
+ try {
+ WebClientService webClientService = webClientAtomicReference.get();
+ URI uri = new URI(context.getProperty(REPORT_URL).evaluateAttributeExpressions(flowfile).getValue().trim());
+ long startNanos = System.nanoTime();
+ String authorization = createAuthorizationHeader(context, flowfile);
+
+ try(HttpResponseEntity httpResponseEntity = webClientService.get().uri(uri).header(HEADER_AUTHORIZATION, authorization).retrieve()) {
+ responseFlowFile = createResponseFlowFile(flowfile, session, context, httpResponseEntity);
+ long elapsedTime = TimeUnit.NANOSECONDS.toMillis(System.nanoTime() - startNanos);
+ Map<String, String> commonAttributes = createCommonAttributes(uri, httpResponseEntity, elapsedTime);
+
+ if (flowfile != null) {
+ flowfile = session.putAllAttributes(flowfile, decorateWithMimeAttribute(commonAttributes, httpResponseEntity));
+ }
+ if (responseFlowFile != null) {
+ responseFlowFile = session.putAllAttributes(responseFlowFile, commonAttributes);
+ if (flowfile != null) {
+ session.getProvenanceReporter().fetch(responseFlowFile, uri.toString(), elapsedTime);
+ } else {
+ session.getProvenanceReporter().receive(responseFlowFile, uri.toString(), elapsedTime);
+ }
+ }
+
+ route(flowfile, responseFlowFile, session, context, httpResponseEntity.statusCode());
+ }
+ } catch (Exception e) {
+ if (flowfile == null) {
+ logger.error("Request Processing failed", e);
+ context.yield();
+ } else {
+ logger.error("Request Processing failed: {}", flowfile, e);
+ session.penalize(flowfile);
+ flowfile = session.putAttribute(flowfile, GET_WORKDAY_REPORT_JAVA_EXCEPTION_CLASS, e.getClass().getName());
+ flowfile = session.putAttribute(flowfile, GET_WORKDAY_REPORT_JAVA_EXCEPTION_MESSAGE, e.getMessage());
+ session.transfer(flowfile, FAILURE);
+ }
+
+ if (responseFlowFile != null) {
+ session.remove(responseFlowFile);
+ }
+ }
+ }
+
+ @Override
+ protected Collection<ValidationResult> customValidate(ValidationContext validationContext) {
+ List<ValidationResult> results = new ArrayList<>(super.customValidate(validationContext));
+ if (validationContext.getProperty(FIELDS_TO_HASH).isSet() && !validationContext.getProperty(RECORD_READER_FACTORY).isSet()) {
+ results.add(new ValidationResult.Builder()
+ .valid(false)
+ .explanation("Record-Reader and Record-Writer must be set if you would like to hash specific fields")
+ .subject("Workday report configuration")
+ .build());
+ }
+ return results;
+ }
+
+ /*
+ * If we have no FlowFile, and all incoming connections are self-loops then we can continue on.
+ * However, if we have no FlowFile and we have connections coming from other Processors, then
+ * we know that we should run only if we have a FlowFile.
+ */
+ private boolean skipExecution(ProcessContext context, FlowFile flowfile) {
+ return context.hasIncomingConnection() && flowfile == null && context.hasNonLoopConnection();
+ }
+
+ private FlowFile createResponseFlowFile(FlowFile flowfile, ProcessSession session, ProcessContext context, HttpResponseEntity httpResponseEntity)
+ throws IOException, SchemaNotFoundException, MalformedRecordException {
+ FlowFile responseFlowFile = null;
+ String hashingAlgorithm = context.getProperty(HASHING_ALGORITHM).getValue();
+ Set<String> columnsToHash = Optional.ofNullable(context.getProperty(FIELDS_TO_HASH).evaluateAttributeExpressions(flowfile).getValue()).map(String::trim)
+ .map(columns -> columns.split(COLUMNS_TO_HASH_SEPARATOR)).map(Arrays::stream).map(columns -> columns.collect(Collectors.toSet())).orElse(Collections.emptySet());
+ try {
+ if (isSuccess(httpResponseEntity.statusCode())) {
+ responseFlowFile = flowfile != null ? session.create(flowfile) : session.create();
+ InputStream responseBodyStream = httpResponseEntity.body();
+ if (recordReaderFactoryAtomicReference.get() != null) {
+ TransformResult transformResult = transformRecords(session, flowfile, responseFlowFile, hashingAlgorithm, columnsToHash, responseBodyStream);
+ Map<String, String> attributes = new HashMap<>();
+ attributes.put(RECORD_COUNT, String.valueOf(transformResult.getNumberOfRecords()));
+ attributes.put(CoreAttributes.MIME_TYPE.key(), transformResult.getMimeType());
+ responseFlowFile = session.putAllAttributes(responseFlowFile, attributes);
+ } else {
+ responseFlowFile = session.importFrom(responseBodyStream, responseFlowFile);
+ Optional<String> mimeType = httpResponseEntity.headers().getFirstHeader(HEADER_CONTENT_TYPE);
+ if (mimeType.isPresent()) {
+ responseFlowFile = session.putAttribute(responseFlowFile, CoreAttributes.MIME_TYPE.key(), mimeType.get());
+ }
+ }
+ }
+ } catch (Exception e) {
+ session.remove(responseFlowFile);
+ throw e;
+ }
+ return responseFlowFile;
+ }
+
+ private String createAuthorizationHeader(ProcessContext context, FlowFile flowfile) {
+ String userName = context.getProperty(WORKDAY_USERNAME).evaluateAttributeExpressions(flowfile).getValue();
+ String password = context.getProperty(WORKDAY_PASSWORD).evaluateAttributeExpressions(flowfile).getValue();
+ String base64Credential = Base64.getEncoder().encodeToString((userName + USERNAME_PASSWORD_SEPARATOR + password).getBytes(StandardCharsets.ISO_8859_1));
+ return BASIC_PREFIX + base64Credential;
+ }
+
+ private TransformResult transformRecords(ProcessSession session, FlowFile flowfile, FlowFile responseFlowFile, String hashingAlgorithm, Set<String> columnsToHash,
+ InputStream responseBodyStream) throws IOException, SchemaNotFoundException, MalformedRecordException {
+ int numberOfRecords = 0;
+ String mimeType = null;
+ try (RecordReader reader = recordReaderFactoryAtomicReference.get().createRecordReader(flowfile,
+ new BufferedInputStream(responseBodyStream), getLogger())) {
+ RecordSchema schema = recordSetWriterFactoryAtomicReference.get()
+ .getSchema(flowfile == null ? Collections.emptyMap() : flowfile.getAttributes(), reader.getSchema());
+ try (OutputStream responseStream = session.write(responseFlowFile);
+ RecordSetWriter recordSetWriter = recordSetWriterFactoryAtomicReference.get().createWriter(getLogger(), schema, responseStream, responseFlowFile)) {
+ mimeType = recordSetWriter.getMimeType();
+ recordSetWriter.beginRecordSet();
+ Record currentRecord;
+ while ((currentRecord = reader.nextRecord(false, true)) != null) {
Review Comment:
Is it possible to either add explanation what the "false,true" is or handle this via processor properties?
##########
nifi-nar-bundles/nifi-workday-bundle/nifi-workday-processors/src/main/java/org/apache/nifi/processors/workday/GetWorkdayReport.java:
##########
@@ -0,0 +1,432 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.processors.workday;
+
+import static org.apache.nifi.expression.ExpressionLanguageScope.FLOWFILE_ATTRIBUTES;
+import static org.apache.nifi.expression.ExpressionLanguageScope.NONE;
+import static org.apache.nifi.processor.util.StandardValidators.NON_BLANK_VALIDATOR;
+import static org.apache.nifi.processor.util.StandardValidators.URL_VALIDATOR;
+
+import java.io.BufferedInputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.OutputStream;
+import java.net.URI;
+import java.nio.charset.StandardCharsets;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Base64;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.regex.Pattern;
+import java.util.stream.Collectors;
+import org.apache.nifi.annotation.behavior.EventDriven;
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.behavior.InputRequirement.Requirement;
+import org.apache.nifi.annotation.behavior.SideEffectFree;
+import org.apache.nifi.annotation.behavior.SupportsBatching;
+import org.apache.nifi.annotation.behavior.WritesAttribute;
+import org.apache.nifi.annotation.behavior.WritesAttributes;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnScheduled;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.flowfile.attributes.CoreAttributes;
+import org.apache.nifi.logging.ComponentLog;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.record.path.RecordPath;
+import org.apache.nifi.record.path.RecordPathResult;
+import org.apache.nifi.schema.access.SchemaNotFoundException;
+import org.apache.nifi.security.util.crypto.HashAlgorithm;
+import org.apache.nifi.security.util.crypto.HashService;
+import org.apache.nifi.serialization.MalformedRecordException;
+import org.apache.nifi.serialization.RecordReader;
+import org.apache.nifi.serialization.RecordReaderFactory;
+import org.apache.nifi.serialization.RecordSetWriter;
+import org.apache.nifi.serialization.RecordSetWriterFactory;
+import org.apache.nifi.serialization.record.Record;
+import org.apache.nifi.serialization.record.RecordFieldType;
+import org.apache.nifi.serialization.record.RecordSchema;
+import org.apache.nifi.web.client.api.HttpResponseEntity;
+import org.apache.nifi.web.client.api.WebClientService;
+import org.apache.nifi.web.client.provider.api.WebClientServiceProvider;
+
+@Tags({"Workday", "report", "get"})
+@InputRequirement(Requirement.INPUT_ALLOWED)
+@CapabilityDescription("A processor which can interact with a configurable Workday Report. The processor can forward the content without modification, or you can transform it by"
+ + " providing the specific Record Reader and Record Writer services based on your needs. You can also hash, or remove fields using the input parameters and schemes in the Record writer. "
+ + "Supported Workday report formats are: csv, simplexml, json")
+@EventDriven
+@SideEffectFree
+@SupportsBatching
+@WritesAttributes({
+ @WritesAttribute(attribute = GetWorkdayReport.GET_WORKDAY_REPORT_JAVA_EXCEPTION_CLASS, description = "The Java exception class raised when the processor fails"),
+ @WritesAttribute(attribute = GetWorkdayReport.GET_WORKDAY_REPORT_JAVA_EXCEPTION_MESSAGE, description = "The Java exception message raised when the processor fails"),
+ @WritesAttribute(attribute = "mime.type", description = "Sets the mime.type attribute to the MIME Type specified by the Source / Record Writer"),
+ @WritesAttribute(attribute= GetWorkdayReport.RECORD_COUNT, description = "The number of records in an outgoing FlowFile. This is only populated on the 'success' relationship "
+ + "when Record Reader and Writer is set.")})
+public class GetWorkdayReport extends AbstractProcessor {
+
+ protected static final String STATUS_CODE = "getworkdayreport.status.code";
+ protected static final String REQUEST_URL = "getworkdayreport.request.url";
+ protected static final String REQUEST_DURATION = "getworkdayreport.request.duration";
+ protected static final String TRANSACTION_ID = "getworkdayreport.tx.id";
+ protected static final String GET_WORKDAY_REPORT_JAVA_EXCEPTION_CLASS = "getworkdayreport.java.exception.class";
+ protected static final String GET_WORKDAY_REPORT_JAVA_EXCEPTION_MESSAGE = "getworkdayreport.java.exception.message";
+ protected static final String RECORD_COUNT = "record.count";
+ protected static final String BASIC_PREFIX = "Basic ";
+ protected static final String COLUMNS_TO_HASH_SEPARATOR = ",";
+ protected static final String HEADER_AUTHORIZATION = "Authorization";
+ protected static final String HEADER_CONTENT_TYPE = "Content-Type";
+ protected static final String USERNAME_PASSWORD_SEPARATOR = ":";
+
+ protected static final PropertyDescriptor REPORT_URL = new PropertyDescriptor.Builder()
+ .name("Workday report URL")
+ .displayName("Workday report URL")
+ .description("HTTP remote URL of Workday report including a scheme of http or https, as well as a hostname or IP address with optional port and path elements.")
+ .required(true)
+ .expressionLanguageSupported(FLOWFILE_ATTRIBUTES)
+ .addValidator(URL_VALIDATOR)
+ .build();
+
+ protected static final PropertyDescriptor WORKDAY_USERNAME = new PropertyDescriptor.Builder()
+ .name("Workday Username")
+ .displayName("Workday Username")
+ .description("The username provided for authentication of Workday requests. Encoded using Base64 for HTTP Basic Authentication as described in RFC 7617.")
+ .required(true)
+ .addValidator(StandardValidators.createRegexMatchingValidator(Pattern.compile("^[\\x20-\\x39\\x3b-\\x7e\\x80-\\xff]+$")))
+ .expressionLanguageSupported(FLOWFILE_ATTRIBUTES)
+ .build();
+
+ protected static final PropertyDescriptor WORKDAY_PASSWORD = new PropertyDescriptor.Builder()
+ .name("Workday Password")
+ .displayName("Workday Password")
+ .description("The password provided for authentication of Workday requests. Encoded using Base64 for HTTP Basic Authentication as described in RFC 7617.")
+ .required(true)
+ .sensitive(true)
+ .addValidator(StandardValidators.createRegexMatchingValidator(Pattern.compile("^[\\x20-\\x7e\\x80-\\xff]+$")))
+ .expressionLanguageSupported(FLOWFILE_ATTRIBUTES)
+ .build();
+
+ protected static final PropertyDescriptor WEB_CLIENT_SERVICE = new PropertyDescriptor.Builder()
+ .name("Standard Web Client Service")
+ .description("Web client which is used to communicate with the Workday API.")
+ .required(true)
+ .identifiesControllerService(WebClientServiceProvider.class)
+ .build();
+
+ protected static final PropertyDescriptor FIELDS_TO_HASH = new PropertyDescriptor.Builder()
+ .name("Fields to hash")
+ .displayName("Fields to hash")
+ .description("Comma separated record paths to replace with hash.")
+ .required(false)
+ .expressionLanguageSupported(FLOWFILE_ATTRIBUTES)
+ .addValidator(NON_BLANK_VALIDATOR)
+ .build();
+
+ protected static final PropertyDescriptor HASHING_ALGORITHM = new PropertyDescriptor.Builder()
+ .name("Hashing algorithm")
+ .displayName("Hashing algorithm")
+ .description("Determines what hashing algorithm should be used to perform the hashing function.")
+ .required(true)
+ .allowableValues(HashService.buildHashAlgorithmAllowableValues())
+ .defaultValue(HashAlgorithm.SHA256.getName())
+ .addValidator(NON_BLANK_VALIDATOR)
+ .expressionLanguageSupported(NONE)
+ .dependsOn(FIELDS_TO_HASH)
+ .build();
+
+ protected static final PropertyDescriptor RECORD_READER_FACTORY = new PropertyDescriptor.Builder()
+ .name("record-reader")
+ .displayName("Record Reader")
+ .description("Specifies the Controller Service to use for parsing incoming data and determining the data's schema.")
+ .identifiesControllerService(RecordReaderFactory.class)
+ .required(false)
+ .build();
+
+ protected static final PropertyDescriptor RECORD_WRITER_FACTORY = new PropertyDescriptor.Builder()
+ .name("record-writer")
+ .displayName("Record Writer")
+ .description("The Record Writer to use for serializing Records to an output FlowFile.")
+ .identifiesControllerService(RecordSetWriterFactory.class)
+ .dependsOn(RECORD_READER_FACTORY)
+ .required(true)
+ .build();
+
+ protected static final Relationship ORIGINAL = new Relationship.Builder()
+ .name("Original")
+ .description("Request FlowFiles transferred when receiving HTTP responses with a status code between 200 and 299.")
+ .build();
+
+ protected static final Relationship FAILURE = new Relationship.Builder()
+ .name("Failure")
+ .description("Request FlowFiles transferred when receiving socket communication errors.")
+ .build();
+
+ protected static final Relationship RESPONSE = new Relationship.Builder()
+ .name("Response")
+ .description("Response FlowFiles transferred when receiving HTTP responses with a status code between 200 and 299.")
+ .build();
+
+ protected static final Set<Relationship> RELATIONSHIPS = Collections.unmodifiableSet(new HashSet<>(Arrays.asList(ORIGINAL, RESPONSE, FAILURE)));
+ protected static final List<PropertyDescriptor> PROPERTIES = Collections.unmodifiableList(Arrays.asList(REPORT_URL, WORKDAY_USERNAME, WORKDAY_PASSWORD, WEB_CLIENT_SERVICE,
+ FIELDS_TO_HASH, HASHING_ALGORITHM, RECORD_READER_FACTORY, RECORD_WRITER_FACTORY));
+
+ private final AtomicReference<WebClientService> webClientAtomicReference = new AtomicReference<>();
+ private final AtomicReference<RecordReaderFactory> recordReaderFactoryAtomicReference = new AtomicReference<>();
+ private final AtomicReference<RecordSetWriterFactory> recordSetWriterFactoryAtomicReference = new AtomicReference<>();
+
+ @Override
+ protected List<PropertyDescriptor> getSupportedPropertyDescriptors() {
+ return PROPERTIES;
+ }
+
+ @Override
+ public Set<Relationship> getRelationships() {
+ return RELATIONSHIPS;
+ }
+
+ @OnScheduled
+ public void setUpClient(final ProcessContext context) {
+ WebClientServiceProvider standardWebClientServiceProvider = context.getProperty(WEB_CLIENT_SERVICE).asControllerService(WebClientServiceProvider.class);
+ RecordReaderFactory recordReaderFactory = context.getProperty(RECORD_READER_FACTORY).asControllerService(RecordReaderFactory.class);
+ RecordSetWriterFactory recordSetWriterFactory = context.getProperty(RECORD_WRITER_FACTORY).asControllerService(RecordSetWriterFactory.class);
+ WebClientService webClientService = standardWebClientServiceProvider.getWebClientService();
+ webClientAtomicReference.set(webClientService);
+ recordReaderFactoryAtomicReference.set(recordReaderFactory);
+ recordSetWriterFactoryAtomicReference.set(recordSetWriterFactory);
+ }
+
+ @Override
+ public void onTrigger(ProcessContext context, ProcessSession session) throws ProcessException {
+ FlowFile flowfile = session.get();
+
+ if (skipExecution(context, flowfile)) {
+ return;
+ }
+
+ ComponentLog logger = getLogger();
+ FlowFile responseFlowFile = null;
+
+ try {
+ WebClientService webClientService = webClientAtomicReference.get();
+ URI uri = new URI(context.getProperty(REPORT_URL).evaluateAttributeExpressions(flowfile).getValue().trim());
+ long startNanos = System.nanoTime();
+ String authorization = createAuthorizationHeader(context, flowfile);
+
+ try(HttpResponseEntity httpResponseEntity = webClientService.get().uri(uri).header(HEADER_AUTHORIZATION, authorization).retrieve()) {
+ responseFlowFile = createResponseFlowFile(flowfile, session, context, httpResponseEntity);
+ long elapsedTime = TimeUnit.NANOSECONDS.toMillis(System.nanoTime() - startNanos);
+ Map<String, String> commonAttributes = createCommonAttributes(uri, httpResponseEntity, elapsedTime);
+
+ if (flowfile != null) {
+ flowfile = session.putAllAttributes(flowfile, decorateWithMimeAttribute(commonAttributes, httpResponseEntity));
+ }
+ if (responseFlowFile != null) {
+ responseFlowFile = session.putAllAttributes(responseFlowFile, commonAttributes);
+ if (flowfile != null) {
+ session.getProvenanceReporter().fetch(responseFlowFile, uri.toString(), elapsedTime);
+ } else {
+ session.getProvenanceReporter().receive(responseFlowFile, uri.toString(), elapsedTime);
+ }
+ }
+
+ route(flowfile, responseFlowFile, session, context, httpResponseEntity.statusCode());
+ }
+ } catch (Exception e) {
+ if (flowfile == null) {
+ logger.error("Request Processing failed", e);
+ context.yield();
+ } else {
+ logger.error("Request Processing failed: {}", flowfile, e);
+ session.penalize(flowfile);
+ flowfile = session.putAttribute(flowfile, GET_WORKDAY_REPORT_JAVA_EXCEPTION_CLASS, e.getClass().getName());
+ flowfile = session.putAttribute(flowfile, GET_WORKDAY_REPORT_JAVA_EXCEPTION_MESSAGE, e.getMessage());
+ session.transfer(flowfile, FAILURE);
+ }
+
+ if (responseFlowFile != null) {
+ session.remove(responseFlowFile);
+ }
+ }
+ }
+
+ @Override
+ protected Collection<ValidationResult> customValidate(ValidationContext validationContext) {
+ List<ValidationResult> results = new ArrayList<>(super.customValidate(validationContext));
+ if (validationContext.getProperty(FIELDS_TO_HASH).isSet() && !validationContext.getProperty(RECORD_READER_FACTORY).isSet()) {
+ results.add(new ValidationResult.Builder()
+ .valid(false)
+ .explanation("Record-Reader and Record-Writer must be set if you would like to hash specific fields")
+ .subject("Workday report configuration")
+ .build());
+ }
+ return results;
+ }
+
+ /*
+ * If we have no FlowFile, and all incoming connections are self-loops then we can continue on.
+ * However, if we have no FlowFile and we have connections coming from other Processors, then
+ * we know that we should run only if we have a FlowFile.
+ */
+ private boolean skipExecution(ProcessContext context, FlowFile flowfile) {
+ return context.hasIncomingConnection() && flowfile == null && context.hasNonLoopConnection();
+ }
+
+ private FlowFile createResponseFlowFile(FlowFile flowfile, ProcessSession session, ProcessContext context, HttpResponseEntity httpResponseEntity)
+ throws IOException, SchemaNotFoundException, MalformedRecordException {
+ FlowFile responseFlowFile = null;
+ String hashingAlgorithm = context.getProperty(HASHING_ALGORITHM).getValue();
+ Set<String> columnsToHash = Optional.ofNullable(context.getProperty(FIELDS_TO_HASH).evaluateAttributeExpressions(flowfile).getValue()).map(String::trim)
+ .map(columns -> columns.split(COLUMNS_TO_HASH_SEPARATOR)).map(Arrays::stream).map(columns -> columns.collect(Collectors.toSet())).orElse(Collections.emptySet());
+ try {
+ if (isSuccess(httpResponseEntity.statusCode())) {
+ responseFlowFile = flowfile != null ? session.create(flowfile) : session.create();
+ InputStream responseBodyStream = httpResponseEntity.body();
+ if (recordReaderFactoryAtomicReference.get() != null) {
+ TransformResult transformResult = transformRecords(session, flowfile, responseFlowFile, hashingAlgorithm, columnsToHash, responseBodyStream);
+ Map<String, String> attributes = new HashMap<>();
+ attributes.put(RECORD_COUNT, String.valueOf(transformResult.getNumberOfRecords()));
+ attributes.put(CoreAttributes.MIME_TYPE.key(), transformResult.getMimeType());
+ responseFlowFile = session.putAllAttributes(responseFlowFile, attributes);
+ } else {
+ responseFlowFile = session.importFrom(responseBodyStream, responseFlowFile);
+ Optional<String> mimeType = httpResponseEntity.headers().getFirstHeader(HEADER_CONTENT_TYPE);
+ if (mimeType.isPresent()) {
+ responseFlowFile = session.putAttribute(responseFlowFile, CoreAttributes.MIME_TYPE.key(), mimeType.get());
+ }
+ }
+ }
+ } catch (Exception e) {
+ session.remove(responseFlowFile);
+ throw e;
+ }
+ return responseFlowFile;
+ }
+
+ private String createAuthorizationHeader(ProcessContext context, FlowFile flowfile) {
+ String userName = context.getProperty(WORKDAY_USERNAME).evaluateAttributeExpressions(flowfile).getValue();
+ String password = context.getProperty(WORKDAY_PASSWORD).evaluateAttributeExpressions(flowfile).getValue();
+ String base64Credential = Base64.getEncoder().encodeToString((userName + USERNAME_PASSWORD_SEPARATOR + password).getBytes(StandardCharsets.ISO_8859_1));
+ return BASIC_PREFIX + base64Credential;
+ }
+
+ private TransformResult transformRecords(ProcessSession session, FlowFile flowfile, FlowFile responseFlowFile, String hashingAlgorithm, Set<String> columnsToHash,
+ InputStream responseBodyStream) throws IOException, SchemaNotFoundException, MalformedRecordException {
+ int numberOfRecords = 0;
+ String mimeType = null;
+ try (RecordReader reader = recordReaderFactoryAtomicReference.get().createRecordReader(flowfile,
+ new BufferedInputStream(responseBodyStream), getLogger())) {
+ RecordSchema schema = recordSetWriterFactoryAtomicReference.get()
+ .getSchema(flowfile == null ? Collections.emptyMap() : flowfile.getAttributes(), reader.getSchema());
+ try (OutputStream responseStream = session.write(responseFlowFile);
+ RecordSetWriter recordSetWriter = recordSetWriterFactoryAtomicReference.get().createWriter(getLogger(), schema, responseStream, responseFlowFile)) {
+ mimeType = recordSetWriter.getMimeType();
+ recordSetWriter.beginRecordSet();
+ Record currentRecord;
+ while ((currentRecord = reader.nextRecord(false, true)) != null) {
+ for (String recordPath : columnsToHash) {
+ RecordPathResult evaluate = RecordPath.compile("hash(" + recordPath + ", '" + hashingAlgorithm + "')").evaluate(currentRecord);
+ evaluate.getSelectedFields().forEach(fieldVal -> fieldVal.updateValue(fieldVal.getValue(), RecordFieldType.STRING.getDataType()));
+ }
+ currentRecord.incorporateInactiveFields();
+ recordSetWriter.write(currentRecord);
+ numberOfRecords++;
+ }
+ }
+ }
+ return new TransformResult(numberOfRecords, mimeType);
+ }
+
+ private void route(FlowFile request, FlowFile response, ProcessSession session, ProcessContext context, int statusCode) {
+ if (!isSuccess(statusCode) && request == null) {
+ context.yield();
+ }
+
+ if (isSuccess(statusCode)) {
+ if (request != null) {
+ session.transfer(request, ORIGINAL);
+ }
+ if (response != null) {
+ session.transfer(response, RESPONSE);
+ }
+ } else {
+ if (request != null) {
+ session.transfer(request, FAILURE);
+ }
+ }
+ }
+
+ private boolean isSuccess(int statusCode) {
+ return statusCode / 100 == 2;
Review Comment:
What do you think about making this a little more descriptive like
```
return statuscode >= 200 && statuscode < 300;
```
##########
nifi-nar-bundles/nifi-workday-bundle/nifi-workday-processors/src/main/java/org/apache/nifi/processors/workday/GetWorkdayReport.java:
##########
@@ -0,0 +1,432 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.processors.workday;
+
+import static org.apache.nifi.expression.ExpressionLanguageScope.FLOWFILE_ATTRIBUTES;
+import static org.apache.nifi.expression.ExpressionLanguageScope.NONE;
+import static org.apache.nifi.processor.util.StandardValidators.NON_BLANK_VALIDATOR;
+import static org.apache.nifi.processor.util.StandardValidators.URL_VALIDATOR;
+
+import java.io.BufferedInputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.OutputStream;
+import java.net.URI;
+import java.nio.charset.StandardCharsets;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Base64;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.Set;
+import java.util.UUID;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicReference;
+import java.util.regex.Pattern;
+import java.util.stream.Collectors;
+import org.apache.nifi.annotation.behavior.EventDriven;
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.behavior.InputRequirement.Requirement;
+import org.apache.nifi.annotation.behavior.SideEffectFree;
+import org.apache.nifi.annotation.behavior.SupportsBatching;
+import org.apache.nifi.annotation.behavior.WritesAttribute;
+import org.apache.nifi.annotation.behavior.WritesAttributes;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnScheduled;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.flowfile.attributes.CoreAttributes;
+import org.apache.nifi.logging.ComponentLog;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.record.path.RecordPath;
+import org.apache.nifi.record.path.RecordPathResult;
+import org.apache.nifi.schema.access.SchemaNotFoundException;
+import org.apache.nifi.security.util.crypto.HashAlgorithm;
+import org.apache.nifi.security.util.crypto.HashService;
+import org.apache.nifi.serialization.MalformedRecordException;
+import org.apache.nifi.serialization.RecordReader;
+import org.apache.nifi.serialization.RecordReaderFactory;
+import org.apache.nifi.serialization.RecordSetWriter;
+import org.apache.nifi.serialization.RecordSetWriterFactory;
+import org.apache.nifi.serialization.record.Record;
+import org.apache.nifi.serialization.record.RecordFieldType;
+import org.apache.nifi.serialization.record.RecordSchema;
+import org.apache.nifi.web.client.api.HttpResponseEntity;
+import org.apache.nifi.web.client.api.WebClientService;
+import org.apache.nifi.web.client.provider.api.WebClientServiceProvider;
+
+@Tags({"Workday", "report", "get"})
+@InputRequirement(Requirement.INPUT_ALLOWED)
+@CapabilityDescription("A processor which can interact with a configurable Workday Report. The processor can forward the content without modification, or you can transform it by"
+ + " providing the specific Record Reader and Record Writer services based on your needs. You can also hash, or remove fields using the input parameters and schemes in the Record writer. "
Review Comment:
```suggestion
+ " providing the specific Record Reader and Record Writer services based on your needs. You can also hash, or remove fields using the input parameters and schemes in the Record Writer. "
```
##########
nifi-nar-bundles/nifi-workday-bundle/nifi-workday-processors/src/test/java/org/apache/nifi/processors/workday/GetWorkdayReportTest.java:
##########
@@ -0,0 +1,438 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.processors.workday;
+
+import static org.apache.nifi.processors.workday.GetWorkdayReport.FAILURE;
+import static org.apache.nifi.processors.workday.GetWorkdayReport.FIELDS_TO_HASH;
+import static org.apache.nifi.processors.workday.GetWorkdayReport.GET_WORKDAY_REPORT_JAVA_EXCEPTION_CLASS;
+import static org.apache.nifi.processors.workday.GetWorkdayReport.GET_WORKDAY_REPORT_JAVA_EXCEPTION_MESSAGE;
+import static org.apache.nifi.processors.workday.GetWorkdayReport.HASHING_ALGORITHM;
+import static org.apache.nifi.processors.workday.GetWorkdayReport.HEADER_AUTHORIZATION;
+import static org.apache.nifi.processors.workday.GetWorkdayReport.ORIGINAL;
+import static org.apache.nifi.processors.workday.GetWorkdayReport.RECORD_COUNT;
+import static org.apache.nifi.processors.workday.GetWorkdayReport.RECORD_READER_FACTORY;
+import static org.apache.nifi.processors.workday.GetWorkdayReport.RECORD_WRITER_FACTORY;
+import static org.apache.nifi.processors.workday.GetWorkdayReport.RESPONSE;
+import static org.apache.nifi.processors.workday.GetWorkdayReport.STATUS_CODE;
+import static org.apache.nifi.processors.workday.GetWorkdayReport.WEB_CLIENT_SERVICE;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+import java.io.IOException;
+import java.net.URISyntaxException;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.concurrent.TimeUnit;
+import java.util.regex.Pattern;
+import okhttp3.mockwebserver.MockResponse;
+import okhttp3.mockwebserver.MockWebServer;
+import okhttp3.mockwebserver.RecordedRequest;
+import org.apache.nifi.csv.CSVRecordSetWriter;
+import org.apache.nifi.flowfile.attributes.CoreAttributes;
+import org.apache.nifi.json.JsonTreeReader;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.reporting.InitializationException;
+import org.apache.nifi.security.util.crypto.HashAlgorithm;
+import org.apache.nifi.security.util.crypto.HashService;
+import org.apache.nifi.serialization.RecordReaderFactory;
+import org.apache.nifi.serialization.RecordSetWriterFactory;
+import org.apache.nifi.util.MockFlowFile;
+import org.apache.nifi.util.MockProcessContext;
+import org.apache.nifi.util.TestRunner;
+import org.apache.nifi.util.TestRunners;
+import org.apache.nifi.web.client.provider.api.WebClientServiceProvider;
+import org.apache.nifi.web.client.provider.service.StandardWebClientServiceProvider;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+class GetWorkdayReportTest {
+
+ private static final String LOCALHOST = "localhost";
+ private static final String REPORT_URL = "http://" + LOCALHOST;
+ private static final String INVALID_URL = "invalid";
+ private static final String FIELD_TO_HASH = "/name";
+ private static final String INVALID_URL_PARAM = ":invalid_url";
+ private static final String APPLICATION_JSON = "application/json";
+ private static final String OK_STATUS_CODE = "200";
+ private static final String CONTENT_TYPE = "Content-Type";
+ private static final String TEXT_CSV = "text/csv";
+ private static final String USER_NAME = "userName";
+ private static final String PASSWORD = "password";
+
+ private TestRunner runner;
+ private MockWebServer mockWebServer;
+
+ @BeforeEach
+ public void setRunner() {
+ runner = TestRunners.newTestRunner(new GetWorkdayReport());
+ mockWebServer = new MockWebServer();
+ }
+
+ @AfterEach
+ public void shutdownServer() throws IOException {
+ mockWebServer.shutdown();
+ }
+
+ @Test
+ public void testNotValidWithoutReportUrlProperty() throws InitializationException {
+ withWebClientService();
+ runner.setProperty(GetWorkdayReport.WORKDAY_USERNAME, USER_NAME);
+ runner.setProperty(GetWorkdayReport.WORKDAY_PASSWORD, PASSWORD);
+
+ runner.assertNotValid();
+ }
+
+ @Test
+ public void testNotValidWithInvalidReportUrlProperty() throws InitializationException {
+ withWebClientService();
+ runner.setProperty(GetWorkdayReport.WORKDAY_USERNAME, USER_NAME);
+ runner.setProperty(GetWorkdayReport.WORKDAY_PASSWORD, PASSWORD);
+ runner.setProperty(GetWorkdayReport.REPORT_URL, INVALID_URL);
+ runner.assertNotValid();
+ }
+
+ @Test
+ public void testNotValidWithoutUserName() throws InitializationException {
+ withWebClientService();
+ runner.setProperty(GetWorkdayReport.WORKDAY_PASSWORD, PASSWORD);
+ runner.setProperty(GetWorkdayReport.REPORT_URL, REPORT_URL);
+
+ runner.assertNotValid();
+ }
+
+ @Test
+ public void testNotValidWithoutPassword() throws InitializationException {
+ withWebClientService();
+ runner.setProperty(GetWorkdayReport.WORKDAY_USERNAME, USER_NAME);
+ runner.setProperty(GetWorkdayReport.REPORT_URL, REPORT_URL);
+
+ runner.assertNotValid();
+ }
+
+ @Test
+ public void testNotValidIfFieldsToHashIsGivenWithoutRecordReader() throws InitializationException {
+ withWebClientService();
+ withMockRecordSetWriterFactory();
+ runner.setProperty(GetWorkdayReport.WORKDAY_USERNAME, USER_NAME);
+ runner.setProperty(GetWorkdayReport.WORKDAY_PASSWORD, PASSWORD);
+ runner.setProperty(GetWorkdayReport.REPORT_URL, REPORT_URL);
+ runner.setProperty(FIELDS_TO_HASH, FIELD_TO_HASH);
+ runner.assertNotValid();
+ }
+
+ @Test
+ public void testNotValidIfFieldsToHashIsGivenWithoutRecordWriter() throws InitializationException {
+ withWebClientService();
+ withMockRecordReaderFactory();
+ runner.setProperty(GetWorkdayReport.WORKDAY_USERNAME, USER_NAME);
+ runner.setProperty(GetWorkdayReport.WORKDAY_PASSWORD, PASSWORD);
+ runner.setProperty(GetWorkdayReport.REPORT_URL, REPORT_URL);
+ runner.setProperty(FIELDS_TO_HASH, FIELD_TO_HASH);
+ runner.assertNotValid();
+ }
+
+ @Test
+ public void testRunIncomingConnectionsWithNonLoopConnections() throws InitializationException {
+ withWebClientService();
+ runner.setProperty(GetWorkdayReport.WORKDAY_USERNAME, USER_NAME);
+ runner.setProperty(GetWorkdayReport.WORKDAY_PASSWORD, PASSWORD);
+ runner.setProperty(GetWorkdayReport.REPORT_URL, REPORT_URL);
+ runner.setIncomingConnection(true);
+ runner.setNonLoopConnection(true);
+
+ runner.run();
+ runner.assertQueueEmpty();
+ }
+
+ @Test
+ public void testRunThrowsURISyntaxExceptionFailure() throws InitializationException {
+ withWebClientService();
+ runner.setProperty(GetWorkdayReport.WORKDAY_USERNAME, USER_NAME);
+ runner.setProperty(GetWorkdayReport.WORKDAY_PASSWORD, PASSWORD);
+
+ String urlAttributeKey = "request.url";
+ runner.setProperty(GetWorkdayReport.REPORT_URL, String.format("${%s}", urlAttributeKey));
+
+ Map<String, String> attributes = new HashMap<>();
+ attributes.put(urlAttributeKey, INVALID_URL_PARAM);
+
+ runner.enqueue("", attributes);
+ runner.run();
+
+ runner.assertAllFlowFilesTransferred(FAILURE);
+ runner.assertPenalizeCount(1);
+
+ MockFlowFile flowFile = getFlowFile(FAILURE);
+ flowFile.assertAttributeEquals(GET_WORKDAY_REPORT_JAVA_EXCEPTION_CLASS, URISyntaxException.class.getName());
+ flowFile.assertAttributeExists(GET_WORKDAY_REPORT_JAVA_EXCEPTION_MESSAGE);
+ }
+
+ @Test
+ void testContextYieldIfHttpStatusIsNot2xxAndThereIsNoIncomingConnection() throws InitializationException {
+ runner.setIncomingConnection(false);
+ runner.setProperty(GetWorkdayReport.WORKDAY_USERNAME, USER_NAME);
+ runner.setProperty(GetWorkdayReport.WORKDAY_PASSWORD, PASSWORD);
+ withWebClientService();
+ runner.setProperty(GetWorkdayReport.REPORT_URL, getMockWebServerUrl());
+
+ mockWebServer.enqueue(new MockResponse().setResponseCode(500));
+
+ runner.run();
+
+ assertTrue(((MockProcessContext) runner.getProcessContext()).isYieldCalled());
+ runner.assertTransferCount(ORIGINAL, 0);
+ runner.assertTransferCount(RESPONSE, 0);
+ runner.assertTransferCount(FAILURE, 0);
+ }
+
+ @Test
+ void testContextYieldAndForwardFlowFileToFailureIfHttpStatusIsNot2xxAndThereIsIncomingConnection() throws InitializationException {
+ runner.setIncomingConnection(true);
+ runner.setProperty(GetWorkdayReport.WORKDAY_USERNAME, USER_NAME);
+ runner.setProperty(GetWorkdayReport.WORKDAY_PASSWORD, PASSWORD);
+ withWebClientService();
+ runner.setProperty(GetWorkdayReport.REPORT_URL, getMockWebServerUrl());
+
+ mockWebServer.enqueue(new MockResponse().setResponseCode(500));
+
+ runner.enqueue("test");
+ runner.run();
+
+ assertFalse(((MockProcessContext) runner.getProcessContext()).isYieldCalled());
+ runner.assertTransferCount(ORIGINAL, 0);
+ runner.assertTransferCount(RESPONSE, 0);
+ runner.assertTransferCount(FAILURE, 1);
+
+ final MockFlowFile flowFile = runner.getFlowFilesForRelationship(FAILURE).iterator().next();
+ flowFile.assertAttributeEquals("getworkdayreport.status.code", "500");
+ }
+
+ @Test
+ void testYieldShouldBeCalledWhenExceptionHappensAndThereIsNoRequestFlowFile() throws InitializationException {
+ runner.setIncomingConnection(false);
+ runner.setProperty(GetWorkdayReport.WORKDAY_USERNAME, USER_NAME);
+ runner.setProperty(GetWorkdayReport.WORKDAY_PASSWORD, PASSWORD);
+ withWebClientService();
+ String urlAttributeKey = "request.url";
+ runner.setProperty(GetWorkdayReport.REPORT_URL, String.format("${%s}", urlAttributeKey));
+
+ runner.run();
+
+ assertTrue(((MockProcessContext) runner.getProcessContext()).isYieldCalled());
+ runner.assertTransferCount(ORIGINAL, 0);
+ runner.assertTransferCount(RESPONSE, 0);
+ runner.assertTransferCount(FAILURE, 0);
+ }
+
+ @Test
+ void testPassThroughContentWithoutModificationIfNoRecordReaderAndWriterDefined() throws InitializationException {
+ withWebClientService();
+ runner.setProperty(GetWorkdayReport.WORKDAY_USERNAME, USER_NAME);
+ runner.setProperty(GetWorkdayReport.WORKDAY_PASSWORD, PASSWORD);
+ runner.setIncomingConnection(false);
+ runner.setProperty(GetWorkdayReport.REPORT_URL, getMockWebServerUrl());
+
+ String content = "id,name\n1,2";
+ mockWebServer.enqueue(new MockResponse().setResponseCode(200).setBody(content).setHeader(CONTENT_TYPE, TEXT_CSV));
+
+ runner.run();
+
+ assertFalse(((MockProcessContext) runner.getProcessContext()).isYieldCalled());
+ runner.assertTransferCount(ORIGINAL, 0);
+ runner.assertTransferCount(RESPONSE, 1);
+ runner.assertTransferCount(FAILURE, 0);
+
+ MockFlowFile flowFile = runner.getFlowFilesForRelationship(RESPONSE).iterator().next();
+ flowFile.assertAttributeEquals(STATUS_CODE, OK_STATUS_CODE);
+ flowFile.assertAttributeEquals(CoreAttributes.MIME_TYPE.key(), TEXT_CSV);
+ flowFile.assertAttributeNotExists(RECORD_COUNT);
+ flowFile.assertContentEquals(content);
+ }
+
+ @Test
+ void testRequestFlowFileIsTransferredToOriginalRelationship() throws InitializationException {
+ withWebClientService();
+ runner.setProperty(GetWorkdayReport.WORKDAY_USERNAME, USER_NAME);
+ runner.setProperty(GetWorkdayReport.WORKDAY_PASSWORD, PASSWORD);
+ runner.setIncomingConnection(true);
+ runner.setProperty(GetWorkdayReport.REPORT_URL, getMockWebServerUrl());
+
+ String content = "id,name\n1,2";
+ mockWebServer.enqueue(new MockResponse().setResponseCode(200).setBody(content).setHeader(CONTENT_TYPE, TEXT_CSV));
+ runner.enqueue("");
+
+ runner.run();
+
+ assertFalse(((MockProcessContext) runner.getProcessContext()).isYieldCalled());
+ runner.assertTransferCount(ORIGINAL, 1);
+ runner.assertTransferCount(RESPONSE, 1);
+ runner.assertTransferCount(FAILURE, 0);
+
+ MockFlowFile originalFlowFile = runner.getFlowFilesForRelationship(ORIGINAL).iterator().next();
+ MockFlowFile responseFlowFile = runner.getFlowFilesForRelationship(RESPONSE).iterator().next();
+ originalFlowFile.assertAttributeEquals(STATUS_CODE, OK_STATUS_CODE);
+ originalFlowFile.assertAttributeEquals(CoreAttributes.MIME_TYPE.key(), TEXT_CSV);
+ responseFlowFile.assertAttributeEquals(STATUS_CODE, OK_STATUS_CODE);
+ responseFlowFile.assertAttributeEquals(CoreAttributes.MIME_TYPE.key(), TEXT_CSV);
+ responseFlowFile.assertAttributeNotExists(RECORD_COUNT);
+ responseFlowFile.assertContentEquals(content);
+ }
+
+ @Test
+ void testContentIsTransformedIfRecordReaderAndWriterIsDefined() throws InitializationException {
+ withWebClientService();
+ withJsonRecordReader();
+ withCsvRecordSetWriter();
+ runner.setProperty(GetWorkdayReport.WORKDAY_USERNAME, USER_NAME);
+ runner.setProperty(GetWorkdayReport.WORKDAY_PASSWORD, PASSWORD);
+ runner.setIncomingConnection(false);
+ runner.setProperty(GetWorkdayReport.REPORT_URL, getMockWebServerUrl());
+
+ String jsonContent = "{\"id\": 1, \"name\": \"test\"}";
+ String csvContent = "id,name\n1,test\n";
+ mockWebServer.enqueue(new MockResponse().setResponseCode(200).setBody(jsonContent).setHeader(CONTENT_TYPE, APPLICATION_JSON));
+
+ runner.run();
+
+ assertFalse(((MockProcessContext) runner.getProcessContext()).isYieldCalled());
+ runner.assertTransferCount(ORIGINAL, 0);
+ runner.assertTransferCount(RESPONSE, 1);
+ runner.assertTransferCount(FAILURE, 0);
+
+ MockFlowFile flowFile = runner.getFlowFilesForRelationship(RESPONSE).iterator().next();
+ flowFile.assertAttributeEquals(STATUS_CODE, OK_STATUS_CODE);
+ flowFile.assertAttributeEquals(CoreAttributes.MIME_TYPE.key(), TEXT_CSV);
+
+ flowFile.assertAttributeEquals(RECORD_COUNT, "1");
+ flowFile.assertContentEquals(csvContent);
+ }
+
+ @Test
+ void testAttributeIsHashed() throws InitializationException {
Review Comment:
Nice test!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org