[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4668: Allow namespace ignore in user-events

[GitBox <gi...@apache.org>]

chetanmeh commented on a change in pull request #4668: Allow namespace ignore in user-events
URL: https://github.com/apache/openwhisk/pull/4668#discussion_r331663807
 
 

 ##########
 File path: core/monitoring/user-events/src/main/scala/org/apache/openwhisk/core/monitoring/metrics/EventConsumer.scala
 ##########
 @@ -94,6 +95,9 @@ case class EventConsumer(settings: ConsumerSettings[String, String], recorders:
   private def processEvent(value: String): Unit = {
     EventMessage
       .parse(value)
+      .filter { e =>
+        !metricConfig.ignoredNamespaces.contains(e.namespace)
+      }
 
 Review comment:
   Thinking about the ignore support again - May be we should still update the Global metrics so as to account for presence of such activations by ignored namespaces.
   
   Further even having a namespace level metric (which drops the specific action name) would be helpful to still see overall aggregated metric for that namespace. It also helps to confirm if the namespace is not getting abused for some reason (say key leak!)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services