You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "陈梓立 (JIRA)" <ji...@apache.org> on 2018/09/20 13:22:00 UTC

[jira] [Commented] (FLINK-10376) BlobCacheCleanupTest.testPermanentBlobCleanup failed on Travis

    [ https://issues.apache.org/jira/browse/FLINK-10376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16622029#comment-16622029 ] 

陈梓立 commented on FLINK-10376:
-----------------------------

Highly suspect this is caused by a thread unsafe method BlobUtils#mkdirTolerateExisting

 
 # dir.mkdir() by Thread#1 concurrency to dir.mkdir by Thread#2
 # Thread#1 mkdir but not finished, Thread#2 detect it and return false from mkdir and test exist
 # Because Thread#1's mkdir not finished, Thread#2's test fail
 # throw the exception

 

To solve it, I suggest replace this method by Files#createDirectories, which promise atomic.

> BlobCacheCleanupTest.testPermanentBlobCleanup failed on Travis
> --------------------------------------------------------------
>
>                 Key: FLINK-10376
>                 URL: https://issues.apache.org/jira/browse/FLINK-10376
>             Project: Flink
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 1.7.0
>            Reporter: Till Rohrmann
>            Assignee: 陈梓立
>            Priority: Critical
>              Labels: test-stability
>             Fix For: 1.7.0
>
>
> The {{BlobCacheCleanupTest.testPermanentBlobCleanup}} failed on Travis with the following exception:
> {code}
> testPermanentBlobCleanup(org.apache.flink.runtime.blob.BlobCacheCleanupTest)  Time elapsed: 1.021 sec  <<< ERROR!
> java.io.IOException: Cannot create directory '/tmp/junit6933344779576098111/junit6230481778643276963/blobStore-77f235ff-1721-4c30-9bec-db4004fe8859/job_9ca4b9530b367af6f554dad6458ca3ad'.
> 	at org.apache.flink.runtime.blob.BlobUtils.mkdirTolerateExisting(BlobUtils.java:214)
> 	at org.apache.flink.runtime.blob.BlobUtils.getStorageLocation(BlobUtils.java:237)
> 	at org.apache.flink.runtime.blob.PermanentBlobCache.getStorageLocation(PermanentBlobCache.java:222)
> 	at org.apache.flink.runtime.blob.BlobServerCleanupTest.checkFilesExist(BlobServerCleanupTest.java:213)
> 	at org.apache.flink.runtime.blob.BlobCacheCleanupTest.verifyJobCleanup(BlobCacheCleanupTest.java:432)
> 	at org.apache.flink.runtime.blob.BlobCacheCleanupTest.testPermanentBlobCleanup(BlobCacheCleanupTest.java:133)
> {code}
> https://api.travis-ci.org/v3/job/430910115/log.txt



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)