You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/04/15 17:50:33 UTC

[GitHub] [activemq-artemis] jbertram commented on a change in pull request #3085: ARTEMIS-2692 update dependency for JMS client

jbertram commented on a change in pull request #3085: ARTEMIS-2692 update dependency for JMS client
URL: https://github.com/apache/activemq-artemis/pull/3085#discussion_r409025360
 
 

 ##########
 File path: artemis-jms-client/pom.xml
 ##########
 @@ -50,6 +50,11 @@
          <artifactId>artemis-core-client</artifactId>
          <version>${project.version}</version>
       </dependency>
+      <dependency>
+         <groupId>org.apache.activemq</groupId>
+         <artifactId>artemis-commons</artifactId>
 
 Review comment:
   Yes, it comes in as transitive, but `org.apache.activemq.artemis.jms.client.ActiveMQDestination` uses `org.apache.activemq.artemis.api.core.QueueConfiguration` (from `artemins-commons`) explicitly so IMO the dependency should be explicit as well instead of leaving it as transitive.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services