[GitHub] [incubator-heron] nwangtw commented on a change in pull request #3283: Set to Kryo serializer when registerKryoSerialization is called

[GitBox <gi...@apache.org>]

nwangtw commented on a change in pull request #3283: Set to Kryo serializer when registerKryoSerialization is called
URL: https://github.com/apache/incubator-heron/pull/3283#discussion_r291660947
 
 

 ##########
 File path: heron/api/src/java/org/apache/heron/api/Config.java
 ##########
 @@ -480,11 +480,19 @@ private static List getRegisteredKryoSerializations(Map<String, Object> conf) {
   }
 
   public static void registerKryoSerialization(Map<String, Object> conf, Class klass) {
+    // Set to Kryo Seralizer when this function is caled. In Storm API, Kryo seralizer is
+    // the default but it is not in Heron. This implicit set could make migration easier
+    // since it is more consistent.
+    setSerializationClassName("org.apache.heron.api.serializer.KryoSerializer");
 
 Review comment:
   kk. done.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services