[GitHub] [druid] gianm commented on a change in pull request #11890: HashJoinEngine: Fix extraneous advance of left cursor.

[GitBox <gi...@apache.org>]

gianm commented on a change in pull request #11890:
URL: https://github.com/apache/druid/pull/11890#discussion_r745935843



##########
File path: processing/src/main/java/org/apache/druid/segment/RowWalker.java
##########
@@ -60,13 +61,16 @@ public T currentRow()
 
   public void advance()
   {
-    if (rowIterator.hasNext()) {
+    if (rowIterator == null) {
+      throw new IllegalStateException("cannot call advance when isDone == true");

Review comment:
       Note to reviewers: adding this check, without the patch to HashJoinEngine, causes a few of the tests to fail and illustrates the problem where `advance` is called on a cursor that has no more rows left.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org