You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by gi...@apache.org on 2018/03/29 14:47:59 UTC
[11/41] hbase-site git commit: Published site at
d8b550fabcacf3050583b514c4081adf5d087d65.
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/2a4c7d89/devapidocs/src-html/org/apache/hadoop/hbase/zookeeper/ReadOnlyZKClient.Task.html
----------------------------------------------------------------------
diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/zookeeper/ReadOnlyZKClient.Task.html b/devapidocs/src-html/org/apache/hadoop/hbase/zookeeper/ReadOnlyZKClient.Task.html
index f845807..1427c4c 100644
--- a/devapidocs/src-html/org/apache/hadoop/hbase/zookeeper/ReadOnlyZKClient.Task.html
+++ b/devapidocs/src-html/org/apache/hadoop/hbase/zookeeper/ReadOnlyZKClient.Task.html
@@ -132,233 +132,239 @@
<span class="sourceLineNo">124</span> }<a name="line.124"></a>
<span class="sourceLineNo">125</span><a name="line.125"></a>
<span class="sourceLineNo">126</span> public ReadOnlyZKClient(Configuration conf) {<a name="line.126"></a>
-<span class="sourceLineNo">127</span> this.connectString = ZKConfig.getZKQuorumServersString(conf);<a name="line.127"></a>
-<span class="sourceLineNo">128</span> this.sessionTimeoutMs = conf.getInt(ZK_SESSION_TIMEOUT, DEFAULT_ZK_SESSION_TIMEOUT);<a name="line.128"></a>
-<span class="sourceLineNo">129</span> this.maxRetries = conf.getInt(RECOVERY_RETRY, DEFAULT_RECOVERY_RETRY);<a name="line.129"></a>
-<span class="sourceLineNo">130</span> this.retryIntervalMs =<a name="line.130"></a>
-<span class="sourceLineNo">131</span> conf.getInt(RECOVERY_RETRY_INTERVAL_MILLIS, DEFAULT_RECOVERY_RETRY_INTERVAL_MILLIS);<a name="line.131"></a>
-<span class="sourceLineNo">132</span> this.keepAliveTimeMs = conf.getInt(KEEPALIVE_MILLIS, DEFAULT_KEEPALIVE_MILLIS);<a name="line.132"></a>
-<span class="sourceLineNo">133</span> LOG.info(<a name="line.133"></a>
-<span class="sourceLineNo">134</span> "Connect {} to {} with session timeout={}ms, retries {}, " +<a name="line.134"></a>
-<span class="sourceLineNo">135</span> "retry interval {}ms, keepAlive={}ms",<a name="line.135"></a>
-<span class="sourceLineNo">136</span> getId(), connectString, sessionTimeoutMs, maxRetries, retryIntervalMs, keepAliveTimeMs);<a name="line.136"></a>
-<span class="sourceLineNo">137</span> Threads.setDaemonThreadRunning(new Thread(this::run),<a name="line.137"></a>
-<span class="sourceLineNo">138</span> "ReadOnlyZKClient-" + connectString + "@" + getId());<a name="line.138"></a>
-<span class="sourceLineNo">139</span> }<a name="line.139"></a>
-<span class="sourceLineNo">140</span><a name="line.140"></a>
-<span class="sourceLineNo">141</span> private abstract class ZKTask<T> extends Task {<a name="line.141"></a>
-<span class="sourceLineNo">142</span><a name="line.142"></a>
-<span class="sourceLineNo">143</span> protected final String path;<a name="line.143"></a>
-<span class="sourceLineNo">144</span><a name="line.144"></a>
-<span class="sourceLineNo">145</span> private final CompletableFuture<T> future;<a name="line.145"></a>
+<span class="sourceLineNo">127</span> // We might use a different ZK for client access<a name="line.127"></a>
+<span class="sourceLineNo">128</span> String clientZkQuorumServers = ZKConfig.getClientZKQuorumServersString(conf);<a name="line.128"></a>
+<span class="sourceLineNo">129</span> if (clientZkQuorumServers != null) {<a name="line.129"></a>
+<span class="sourceLineNo">130</span> this.connectString = clientZkQuorumServers;<a name="line.130"></a>
+<span class="sourceLineNo">131</span> } else {<a name="line.131"></a>
+<span class="sourceLineNo">132</span> this.connectString = ZKConfig.getZKQuorumServersString(conf);<a name="line.132"></a>
+<span class="sourceLineNo">133</span> }<a name="line.133"></a>
+<span class="sourceLineNo">134</span> this.sessionTimeoutMs = conf.getInt(ZK_SESSION_TIMEOUT, DEFAULT_ZK_SESSION_TIMEOUT);<a name="line.134"></a>
+<span class="sourceLineNo">135</span> this.maxRetries = conf.getInt(RECOVERY_RETRY, DEFAULT_RECOVERY_RETRY);<a name="line.135"></a>
+<span class="sourceLineNo">136</span> this.retryIntervalMs =<a name="line.136"></a>
+<span class="sourceLineNo">137</span> conf.getInt(RECOVERY_RETRY_INTERVAL_MILLIS, DEFAULT_RECOVERY_RETRY_INTERVAL_MILLIS);<a name="line.137"></a>
+<span class="sourceLineNo">138</span> this.keepAliveTimeMs = conf.getInt(KEEPALIVE_MILLIS, DEFAULT_KEEPALIVE_MILLIS);<a name="line.138"></a>
+<span class="sourceLineNo">139</span> LOG.info(<a name="line.139"></a>
+<span class="sourceLineNo">140</span> "Connect {} to {} with session timeout={}ms, retries {}, " +<a name="line.140"></a>
+<span class="sourceLineNo">141</span> "retry interval {}ms, keepAlive={}ms",<a name="line.141"></a>
+<span class="sourceLineNo">142</span> getId(), connectString, sessionTimeoutMs, maxRetries, retryIntervalMs, keepAliveTimeMs);<a name="line.142"></a>
+<span class="sourceLineNo">143</span> Threads.setDaemonThreadRunning(new Thread(this::run),<a name="line.143"></a>
+<span class="sourceLineNo">144</span> "ReadOnlyZKClient-" + connectString + "@" + getId());<a name="line.144"></a>
+<span class="sourceLineNo">145</span> }<a name="line.145"></a>
<span class="sourceLineNo">146</span><a name="line.146"></a>
-<span class="sourceLineNo">147</span> private final String operationType;<a name="line.147"></a>
+<span class="sourceLineNo">147</span> private abstract class ZKTask<T> extends Task {<a name="line.147"></a>
<span class="sourceLineNo">148</span><a name="line.148"></a>
-<span class="sourceLineNo">149</span> private int retries;<a name="line.149"></a>
+<span class="sourceLineNo">149</span> protected final String path;<a name="line.149"></a>
<span class="sourceLineNo">150</span><a name="line.150"></a>
-<span class="sourceLineNo">151</span> protected ZKTask(String path, CompletableFuture<T> future, String operationType) {<a name="line.151"></a>
-<span class="sourceLineNo">152</span> this.path = path;<a name="line.152"></a>
-<span class="sourceLineNo">153</span> this.future = future;<a name="line.153"></a>
-<span class="sourceLineNo">154</span> this.operationType = operationType;<a name="line.154"></a>
-<span class="sourceLineNo">155</span> }<a name="line.155"></a>
+<span class="sourceLineNo">151</span> private final CompletableFuture<T> future;<a name="line.151"></a>
+<span class="sourceLineNo">152</span><a name="line.152"></a>
+<span class="sourceLineNo">153</span> private final String operationType;<a name="line.153"></a>
+<span class="sourceLineNo">154</span><a name="line.154"></a>
+<span class="sourceLineNo">155</span> private int retries;<a name="line.155"></a>
<span class="sourceLineNo">156</span><a name="line.156"></a>
-<span class="sourceLineNo">157</span> protected final void onComplete(ZooKeeper zk, int rc, T ret, boolean errorIfNoNode) {<a name="line.157"></a>
-<span class="sourceLineNo">158</span> tasks.add(new Task() {<a name="line.158"></a>
-<span class="sourceLineNo">159</span><a name="line.159"></a>
-<span class="sourceLineNo">160</span> @Override<a name="line.160"></a>
-<span class="sourceLineNo">161</span> public void exec(ZooKeeper alwaysNull) {<a name="line.161"></a>
-<span class="sourceLineNo">162</span> pendingRequests--;<a name="line.162"></a>
-<span class="sourceLineNo">163</span> Code code = Code.get(rc);<a name="line.163"></a>
-<span class="sourceLineNo">164</span> if (code == Code.OK) {<a name="line.164"></a>
-<span class="sourceLineNo">165</span> future.complete(ret);<a name="line.165"></a>
-<span class="sourceLineNo">166</span> } else if (code == Code.NONODE) {<a name="line.166"></a>
-<span class="sourceLineNo">167</span> if (errorIfNoNode) {<a name="line.167"></a>
-<span class="sourceLineNo">168</span> future.completeExceptionally(KeeperException.create(code, path));<a name="line.168"></a>
-<span class="sourceLineNo">169</span> } else {<a name="line.169"></a>
-<span class="sourceLineNo">170</span> future.complete(ret);<a name="line.170"></a>
-<span class="sourceLineNo">171</span> }<a name="line.171"></a>
-<span class="sourceLineNo">172</span> } else if (FAIL_FAST_CODES.contains(code)) {<a name="line.172"></a>
-<span class="sourceLineNo">173</span> future.completeExceptionally(KeeperException.create(code, path));<a name="line.173"></a>
-<span class="sourceLineNo">174</span> } else {<a name="line.174"></a>
-<span class="sourceLineNo">175</span> if (code == Code.SESSIONEXPIRED) {<a name="line.175"></a>
-<span class="sourceLineNo">176</span> LOG.warn("{} to {} session expired, close and reconnect", getId(), connectString);<a name="line.176"></a>
-<span class="sourceLineNo">177</span> try {<a name="line.177"></a>
-<span class="sourceLineNo">178</span> zk.close();<a name="line.178"></a>
-<span class="sourceLineNo">179</span> } catch (InterruptedException e) {<a name="line.179"></a>
-<span class="sourceLineNo">180</span> }<a name="line.180"></a>
-<span class="sourceLineNo">181</span> }<a name="line.181"></a>
-<span class="sourceLineNo">182</span> if (ZKTask.this.delay(retryIntervalMs, maxRetries)) {<a name="line.182"></a>
-<span class="sourceLineNo">183</span> LOG.warn("{} to {} failed for {} of {}, code = {}, retries = {}", getId(),<a name="line.183"></a>
-<span class="sourceLineNo">184</span> connectString, operationType, path, code, ZKTask.this.retries);<a name="line.184"></a>
-<span class="sourceLineNo">185</span> tasks.add(ZKTask.this);<a name="line.185"></a>
-<span class="sourceLineNo">186</span> } else {<a name="line.186"></a>
-<span class="sourceLineNo">187</span> LOG.warn("{} to {} failed for {} of {}, code = {}, retries = {}, give up", getId(),<a name="line.187"></a>
-<span class="sourceLineNo">188</span> connectString, operationType, path, code, ZKTask.this.retries);<a name="line.188"></a>
-<span class="sourceLineNo">189</span> future.completeExceptionally(KeeperException.create(code, path));<a name="line.189"></a>
-<span class="sourceLineNo">190</span> }<a name="line.190"></a>
-<span class="sourceLineNo">191</span> }<a name="line.191"></a>
-<span class="sourceLineNo">192</span> }<a name="line.192"></a>
-<span class="sourceLineNo">193</span><a name="line.193"></a>
-<span class="sourceLineNo">194</span> @Override<a name="line.194"></a>
-<span class="sourceLineNo">195</span> public void closed(IOException e) {<a name="line.195"></a>
-<span class="sourceLineNo">196</span> // It may happen that a request is succeeded and the onComplete has been called and pushed<a name="line.196"></a>
-<span class="sourceLineNo">197</span> // us into the task queue, but before we get called a close is called and here we will<a name="line.197"></a>
-<span class="sourceLineNo">198</span> // fail the request, although it is succeeded actually.<a name="line.198"></a>
-<span class="sourceLineNo">199</span> // This is not a perfect solution but anyway, it is better than hang the requests for<a name="line.199"></a>
-<span class="sourceLineNo">200</span> // ever, and also acceptable as if you close the zk client before actually getting the<a name="line.200"></a>
-<span class="sourceLineNo">201</span> // response then a failure is always possible.<a name="line.201"></a>
-<span class="sourceLineNo">202</span> future.completeExceptionally(e);<a name="line.202"></a>
-<span class="sourceLineNo">203</span> }<a name="line.203"></a>
-<span class="sourceLineNo">204</span> });<a name="line.204"></a>
-<span class="sourceLineNo">205</span> }<a name="line.205"></a>
-<span class="sourceLineNo">206</span><a name="line.206"></a>
-<span class="sourceLineNo">207</span> @Override<a name="line.207"></a>
-<span class="sourceLineNo">208</span> public boolean needZk() {<a name="line.208"></a>
-<span class="sourceLineNo">209</span> return true;<a name="line.209"></a>
-<span class="sourceLineNo">210</span> }<a name="line.210"></a>
-<span class="sourceLineNo">211</span><a name="line.211"></a>
-<span class="sourceLineNo">212</span> protected abstract void doExec(ZooKeeper zk);<a name="line.212"></a>
-<span class="sourceLineNo">213</span><a name="line.213"></a>
-<span class="sourceLineNo">214</span> @Override<a name="line.214"></a>
-<span class="sourceLineNo">215</span> public final void exec(ZooKeeper zk) {<a name="line.215"></a>
-<span class="sourceLineNo">216</span> pendingRequests++;<a name="line.216"></a>
-<span class="sourceLineNo">217</span> doExec(zk);<a name="line.217"></a>
-<span class="sourceLineNo">218</span> }<a name="line.218"></a>
+<span class="sourceLineNo">157</span> protected ZKTask(String path, CompletableFuture<T> future, String operationType) {<a name="line.157"></a>
+<span class="sourceLineNo">158</span> this.path = path;<a name="line.158"></a>
+<span class="sourceLineNo">159</span> this.future = future;<a name="line.159"></a>
+<span class="sourceLineNo">160</span> this.operationType = operationType;<a name="line.160"></a>
+<span class="sourceLineNo">161</span> }<a name="line.161"></a>
+<span class="sourceLineNo">162</span><a name="line.162"></a>
+<span class="sourceLineNo">163</span> protected final void onComplete(ZooKeeper zk, int rc, T ret, boolean errorIfNoNode) {<a name="line.163"></a>
+<span class="sourceLineNo">164</span> tasks.add(new Task() {<a name="line.164"></a>
+<span class="sourceLineNo">165</span><a name="line.165"></a>
+<span class="sourceLineNo">166</span> @Override<a name="line.166"></a>
+<span class="sourceLineNo">167</span> public void exec(ZooKeeper alwaysNull) {<a name="line.167"></a>
+<span class="sourceLineNo">168</span> pendingRequests--;<a name="line.168"></a>
+<span class="sourceLineNo">169</span> Code code = Code.get(rc);<a name="line.169"></a>
+<span class="sourceLineNo">170</span> if (code == Code.OK) {<a name="line.170"></a>
+<span class="sourceLineNo">171</span> future.complete(ret);<a name="line.171"></a>
+<span class="sourceLineNo">172</span> } else if (code == Code.NONODE) {<a name="line.172"></a>
+<span class="sourceLineNo">173</span> if (errorIfNoNode) {<a name="line.173"></a>
+<span class="sourceLineNo">174</span> future.completeExceptionally(KeeperException.create(code, path));<a name="line.174"></a>
+<span class="sourceLineNo">175</span> } else {<a name="line.175"></a>
+<span class="sourceLineNo">176</span> future.complete(ret);<a name="line.176"></a>
+<span class="sourceLineNo">177</span> }<a name="line.177"></a>
+<span class="sourceLineNo">178</span> } else if (FAIL_FAST_CODES.contains(code)) {<a name="line.178"></a>
+<span class="sourceLineNo">179</span> future.completeExceptionally(KeeperException.create(code, path));<a name="line.179"></a>
+<span class="sourceLineNo">180</span> } else {<a name="line.180"></a>
+<span class="sourceLineNo">181</span> if (code == Code.SESSIONEXPIRED) {<a name="line.181"></a>
+<span class="sourceLineNo">182</span> LOG.warn("{} to {} session expired, close and reconnect", getId(), connectString);<a name="line.182"></a>
+<span class="sourceLineNo">183</span> try {<a name="line.183"></a>
+<span class="sourceLineNo">184</span> zk.close();<a name="line.184"></a>
+<span class="sourceLineNo">185</span> } catch (InterruptedException e) {<a name="line.185"></a>
+<span class="sourceLineNo">186</span> }<a name="line.186"></a>
+<span class="sourceLineNo">187</span> }<a name="line.187"></a>
+<span class="sourceLineNo">188</span> if (ZKTask.this.delay(retryIntervalMs, maxRetries)) {<a name="line.188"></a>
+<span class="sourceLineNo">189</span> LOG.warn("{} to {} failed for {} of {}, code = {}, retries = {}", getId(),<a name="line.189"></a>
+<span class="sourceLineNo">190</span> connectString, operationType, path, code, ZKTask.this.retries);<a name="line.190"></a>
+<span class="sourceLineNo">191</span> tasks.add(ZKTask.this);<a name="line.191"></a>
+<span class="sourceLineNo">192</span> } else {<a name="line.192"></a>
+<span class="sourceLineNo">193</span> LOG.warn("{} to {} failed for {} of {}, code = {}, retries = {}, give up", getId(),<a name="line.193"></a>
+<span class="sourceLineNo">194</span> connectString, operationType, path, code, ZKTask.this.retries);<a name="line.194"></a>
+<span class="sourceLineNo">195</span> future.completeExceptionally(KeeperException.create(code, path));<a name="line.195"></a>
+<span class="sourceLineNo">196</span> }<a name="line.196"></a>
+<span class="sourceLineNo">197</span> }<a name="line.197"></a>
+<span class="sourceLineNo">198</span> }<a name="line.198"></a>
+<span class="sourceLineNo">199</span><a name="line.199"></a>
+<span class="sourceLineNo">200</span> @Override<a name="line.200"></a>
+<span class="sourceLineNo">201</span> public void closed(IOException e) {<a name="line.201"></a>
+<span class="sourceLineNo">202</span> // It may happen that a request is succeeded and the onComplete has been called and pushed<a name="line.202"></a>
+<span class="sourceLineNo">203</span> // us into the task queue, but before we get called a close is called and here we will<a name="line.203"></a>
+<span class="sourceLineNo">204</span> // fail the request, although it is succeeded actually.<a name="line.204"></a>
+<span class="sourceLineNo">205</span> // This is not a perfect solution but anyway, it is better than hang the requests for<a name="line.205"></a>
+<span class="sourceLineNo">206</span> // ever, and also acceptable as if you close the zk client before actually getting the<a name="line.206"></a>
+<span class="sourceLineNo">207</span> // response then a failure is always possible.<a name="line.207"></a>
+<span class="sourceLineNo">208</span> future.completeExceptionally(e);<a name="line.208"></a>
+<span class="sourceLineNo">209</span> }<a name="line.209"></a>
+<span class="sourceLineNo">210</span> });<a name="line.210"></a>
+<span class="sourceLineNo">211</span> }<a name="line.211"></a>
+<span class="sourceLineNo">212</span><a name="line.212"></a>
+<span class="sourceLineNo">213</span> @Override<a name="line.213"></a>
+<span class="sourceLineNo">214</span> public boolean needZk() {<a name="line.214"></a>
+<span class="sourceLineNo">215</span> return true;<a name="line.215"></a>
+<span class="sourceLineNo">216</span> }<a name="line.216"></a>
+<span class="sourceLineNo">217</span><a name="line.217"></a>
+<span class="sourceLineNo">218</span> protected abstract void doExec(ZooKeeper zk);<a name="line.218"></a>
<span class="sourceLineNo">219</span><a name="line.219"></a>
-<span class="sourceLineNo">220</span> public boolean delay(long intervalMs, int maxRetries) {<a name="line.220"></a>
-<span class="sourceLineNo">221</span> if (retries >= maxRetries) {<a name="line.221"></a>
-<span class="sourceLineNo">222</span> return false;<a name="line.222"></a>
-<span class="sourceLineNo">223</span> }<a name="line.223"></a>
-<span class="sourceLineNo">224</span> retries++;<a name="line.224"></a>
-<span class="sourceLineNo">225</span> time = System.nanoTime() + TimeUnit.MILLISECONDS.toNanos(intervalMs);<a name="line.225"></a>
-<span class="sourceLineNo">226</span> return true;<a name="line.226"></a>
-<span class="sourceLineNo">227</span> }<a name="line.227"></a>
-<span class="sourceLineNo">228</span><a name="line.228"></a>
-<span class="sourceLineNo">229</span> @Override<a name="line.229"></a>
-<span class="sourceLineNo">230</span> public void connectFailed(IOException e) {<a name="line.230"></a>
-<span class="sourceLineNo">231</span> if (delay(retryIntervalMs, maxRetries)) {<a name="line.231"></a>
-<span class="sourceLineNo">232</span> LOG.warn("{} to {} failed to connect to zk fo {} of {}, retries = {}", getId(),<a name="line.232"></a>
-<span class="sourceLineNo">233</span> connectString, operationType, path, retries, e);<a name="line.233"></a>
-<span class="sourceLineNo">234</span> tasks.add(this);<a name="line.234"></a>
-<span class="sourceLineNo">235</span> } else {<a name="line.235"></a>
-<span class="sourceLineNo">236</span> LOG.warn("{} to {} failed to connect to zk fo {} of {}, retries = {}, give up", getId(),<a name="line.236"></a>
-<span class="sourceLineNo">237</span> connectString, operationType, path, retries, e);<a name="line.237"></a>
-<span class="sourceLineNo">238</span> future.completeExceptionally(e);<a name="line.238"></a>
-<span class="sourceLineNo">239</span> }<a name="line.239"></a>
-<span class="sourceLineNo">240</span> }<a name="line.240"></a>
-<span class="sourceLineNo">241</span><a name="line.241"></a>
-<span class="sourceLineNo">242</span> @Override<a name="line.242"></a>
-<span class="sourceLineNo">243</span> public void closed(IOException e) {<a name="line.243"></a>
-<span class="sourceLineNo">244</span> future.completeExceptionally(e);<a name="line.244"></a>
-<span class="sourceLineNo">245</span> }<a name="line.245"></a>
-<span class="sourceLineNo">246</span> }<a name="line.246"></a>
+<span class="sourceLineNo">220</span> @Override<a name="line.220"></a>
+<span class="sourceLineNo">221</span> public final void exec(ZooKeeper zk) {<a name="line.221"></a>
+<span class="sourceLineNo">222</span> pendingRequests++;<a name="line.222"></a>
+<span class="sourceLineNo">223</span> doExec(zk);<a name="line.223"></a>
+<span class="sourceLineNo">224</span> }<a name="line.224"></a>
+<span class="sourceLineNo">225</span><a name="line.225"></a>
+<span class="sourceLineNo">226</span> public boolean delay(long intervalMs, int maxRetries) {<a name="line.226"></a>
+<span class="sourceLineNo">227</span> if (retries >= maxRetries) {<a name="line.227"></a>
+<span class="sourceLineNo">228</span> return false;<a name="line.228"></a>
+<span class="sourceLineNo">229</span> }<a name="line.229"></a>
+<span class="sourceLineNo">230</span> retries++;<a name="line.230"></a>
+<span class="sourceLineNo">231</span> time = System.nanoTime() + TimeUnit.MILLISECONDS.toNanos(intervalMs);<a name="line.231"></a>
+<span class="sourceLineNo">232</span> return true;<a name="line.232"></a>
+<span class="sourceLineNo">233</span> }<a name="line.233"></a>
+<span class="sourceLineNo">234</span><a name="line.234"></a>
+<span class="sourceLineNo">235</span> @Override<a name="line.235"></a>
+<span class="sourceLineNo">236</span> public void connectFailed(IOException e) {<a name="line.236"></a>
+<span class="sourceLineNo">237</span> if (delay(retryIntervalMs, maxRetries)) {<a name="line.237"></a>
+<span class="sourceLineNo">238</span> LOG.warn("{} to {} failed to connect to zk fo {} of {}, retries = {}", getId(),<a name="line.238"></a>
+<span class="sourceLineNo">239</span> connectString, operationType, path, retries, e);<a name="line.239"></a>
+<span class="sourceLineNo">240</span> tasks.add(this);<a name="line.240"></a>
+<span class="sourceLineNo">241</span> } else {<a name="line.241"></a>
+<span class="sourceLineNo">242</span> LOG.warn("{} to {} failed to connect to zk fo {} of {}, retries = {}, give up", getId(),<a name="line.242"></a>
+<span class="sourceLineNo">243</span> connectString, operationType, path, retries, e);<a name="line.243"></a>
+<span class="sourceLineNo">244</span> future.completeExceptionally(e);<a name="line.244"></a>
+<span class="sourceLineNo">245</span> }<a name="line.245"></a>
+<span class="sourceLineNo">246</span> }<a name="line.246"></a>
<span class="sourceLineNo">247</span><a name="line.247"></a>
-<span class="sourceLineNo">248</span> private static <T> CompletableFuture<T> failed(Throwable e) {<a name="line.248"></a>
-<span class="sourceLineNo">249</span> CompletableFuture<T> future = new CompletableFuture<>();<a name="line.249"></a>
-<span class="sourceLineNo">250</span> future.completeExceptionally(e);<a name="line.250"></a>
-<span class="sourceLineNo">251</span> return future;<a name="line.251"></a>
+<span class="sourceLineNo">248</span> @Override<a name="line.248"></a>
+<span class="sourceLineNo">249</span> public void closed(IOException e) {<a name="line.249"></a>
+<span class="sourceLineNo">250</span> future.completeExceptionally(e);<a name="line.250"></a>
+<span class="sourceLineNo">251</span> }<a name="line.251"></a>
<span class="sourceLineNo">252</span> }<a name="line.252"></a>
<span class="sourceLineNo">253</span><a name="line.253"></a>
-<span class="sourceLineNo">254</span> public CompletableFuture<byte[]> get(String path) {<a name="line.254"></a>
-<span class="sourceLineNo">255</span> if (closed.get()) {<a name="line.255"></a>
-<span class="sourceLineNo">256</span> return failed(new IOException("Client already closed"));<a name="line.256"></a>
-<span class="sourceLineNo">257</span> }<a name="line.257"></a>
-<span class="sourceLineNo">258</span> CompletableFuture<byte[]> future = new CompletableFuture<>();<a name="line.258"></a>
-<span class="sourceLineNo">259</span> tasks.add(new ZKTask<byte[]>(path, future, "get") {<a name="line.259"></a>
-<span class="sourceLineNo">260</span><a name="line.260"></a>
-<span class="sourceLineNo">261</span> @Override<a name="line.261"></a>
-<span class="sourceLineNo">262</span> protected void doExec(ZooKeeper zk) {<a name="line.262"></a>
-<span class="sourceLineNo">263</span> zk.getData(path, false,<a name="line.263"></a>
-<span class="sourceLineNo">264</span> (rc, path, ctx, data, stat) -> onComplete(zk, rc, data, true), null);<a name="line.264"></a>
-<span class="sourceLineNo">265</span> }<a name="line.265"></a>
-<span class="sourceLineNo">266</span> });<a name="line.266"></a>
-<span class="sourceLineNo">267</span> return future;<a name="line.267"></a>
-<span class="sourceLineNo">268</span> }<a name="line.268"></a>
-<span class="sourceLineNo">269</span><a name="line.269"></a>
-<span class="sourceLineNo">270</span> public CompletableFuture<Stat> exists(String path) {<a name="line.270"></a>
-<span class="sourceLineNo">271</span> if (closed.get()) {<a name="line.271"></a>
-<span class="sourceLineNo">272</span> return failed(new IOException("Client already closed"));<a name="line.272"></a>
-<span class="sourceLineNo">273</span> }<a name="line.273"></a>
-<span class="sourceLineNo">274</span> CompletableFuture<Stat> future = new CompletableFuture<>();<a name="line.274"></a>
-<span class="sourceLineNo">275</span> tasks.add(new ZKTask<Stat>(path, future, "exists") {<a name="line.275"></a>
-<span class="sourceLineNo">276</span><a name="line.276"></a>
-<span class="sourceLineNo">277</span> @Override<a name="line.277"></a>
-<span class="sourceLineNo">278</span> protected void doExec(ZooKeeper zk) {<a name="line.278"></a>
-<span class="sourceLineNo">279</span> zk.exists(path, false, (rc, path, ctx, stat) -> onComplete(zk, rc, stat, false), null);<a name="line.279"></a>
-<span class="sourceLineNo">280</span> }<a name="line.280"></a>
-<span class="sourceLineNo">281</span> });<a name="line.281"></a>
-<span class="sourceLineNo">282</span> return future;<a name="line.282"></a>
-<span class="sourceLineNo">283</span> }<a name="line.283"></a>
-<span class="sourceLineNo">284</span><a name="line.284"></a>
-<span class="sourceLineNo">285</span> private void closeZk() {<a name="line.285"></a>
-<span class="sourceLineNo">286</span> if (zookeeper != null) {<a name="line.286"></a>
-<span class="sourceLineNo">287</span> try {<a name="line.287"></a>
-<span class="sourceLineNo">288</span> zookeeper.close();<a name="line.288"></a>
-<span class="sourceLineNo">289</span> } catch (InterruptedException e) {<a name="line.289"></a>
-<span class="sourceLineNo">290</span> }<a name="line.290"></a>
-<span class="sourceLineNo">291</span> zookeeper = null;<a name="line.291"></a>
-<span class="sourceLineNo">292</span> }<a name="line.292"></a>
-<span class="sourceLineNo">293</span> }<a name="line.293"></a>
-<span class="sourceLineNo">294</span><a name="line.294"></a>
-<span class="sourceLineNo">295</span> private ZooKeeper getZk() throws IOException {<a name="line.295"></a>
-<span class="sourceLineNo">296</span> // may be closed when session expired<a name="line.296"></a>
-<span class="sourceLineNo">297</span> if (zookeeper == null || !zookeeper.getState().isAlive()) {<a name="line.297"></a>
-<span class="sourceLineNo">298</span> zookeeper = new ZooKeeper(connectString, sessionTimeoutMs, e -> {});<a name="line.298"></a>
-<span class="sourceLineNo">299</span> }<a name="line.299"></a>
-<span class="sourceLineNo">300</span> return zookeeper;<a name="line.300"></a>
-<span class="sourceLineNo">301</span> }<a name="line.301"></a>
-<span class="sourceLineNo">302</span><a name="line.302"></a>
-<span class="sourceLineNo">303</span> private void run() {<a name="line.303"></a>
-<span class="sourceLineNo">304</span> for (;;) {<a name="line.304"></a>
-<span class="sourceLineNo">305</span> Task task;<a name="line.305"></a>
-<span class="sourceLineNo">306</span> try {<a name="line.306"></a>
-<span class="sourceLineNo">307</span> task = tasks.poll(keepAliveTimeMs, TimeUnit.MILLISECONDS);<a name="line.307"></a>
-<span class="sourceLineNo">308</span> } catch (InterruptedException e) {<a name="line.308"></a>
-<span class="sourceLineNo">309</span> continue;<a name="line.309"></a>
-<span class="sourceLineNo">310</span> }<a name="line.310"></a>
-<span class="sourceLineNo">311</span> if (task == CLOSE) {<a name="line.311"></a>
-<span class="sourceLineNo">312</span> break;<a name="line.312"></a>
-<span class="sourceLineNo">313</span> }<a name="line.313"></a>
-<span class="sourceLineNo">314</span> if (task == null) {<a name="line.314"></a>
-<span class="sourceLineNo">315</span> if (pendingRequests == 0) {<a name="line.315"></a>
-<span class="sourceLineNo">316</span> LOG.trace("{} to {} inactive for {}ms; closing (Will reconnect when new requests)",<a name="line.316"></a>
-<span class="sourceLineNo">317</span> getId(), connectString, keepAliveTimeMs);<a name="line.317"></a>
-<span class="sourceLineNo">318</span> closeZk();<a name="line.318"></a>
-<span class="sourceLineNo">319</span> }<a name="line.319"></a>
-<span class="sourceLineNo">320</span> continue;<a name="line.320"></a>
-<span class="sourceLineNo">321</span> }<a name="line.321"></a>
-<span class="sourceLineNo">322</span> if (!task.needZk()) {<a name="line.322"></a>
-<span class="sourceLineNo">323</span> task.exec(null);<a name="line.323"></a>
-<span class="sourceLineNo">324</span> } else {<a name="line.324"></a>
-<span class="sourceLineNo">325</span> ZooKeeper zk;<a name="line.325"></a>
-<span class="sourceLineNo">326</span> try {<a name="line.326"></a>
-<span class="sourceLineNo">327</span> zk = getZk();<a name="line.327"></a>
-<span class="sourceLineNo">328</span> } catch (IOException e) {<a name="line.328"></a>
-<span class="sourceLineNo">329</span> task.connectFailed(e);<a name="line.329"></a>
-<span class="sourceLineNo">330</span> continue;<a name="line.330"></a>
-<span class="sourceLineNo">331</span> }<a name="line.331"></a>
-<span class="sourceLineNo">332</span> task.exec(zk);<a name="line.332"></a>
-<span class="sourceLineNo">333</span> }<a name="line.333"></a>
-<span class="sourceLineNo">334</span> }<a name="line.334"></a>
-<span class="sourceLineNo">335</span> closeZk();<a name="line.335"></a>
-<span class="sourceLineNo">336</span> IOException error = new IOException("Client already closed");<a name="line.336"></a>
-<span class="sourceLineNo">337</span> Arrays.stream(tasks.toArray(new Task[0])).forEach(t -> t.closed(error));<a name="line.337"></a>
-<span class="sourceLineNo">338</span> tasks.clear();<a name="line.338"></a>
-<span class="sourceLineNo">339</span> }<a name="line.339"></a>
-<span class="sourceLineNo">340</span><a name="line.340"></a>
-<span class="sourceLineNo">341</span> @Override<a name="line.341"></a>
-<span class="sourceLineNo">342</span> public void close() {<a name="line.342"></a>
-<span class="sourceLineNo">343</span> if (closed.compareAndSet(false, true)) {<a name="line.343"></a>
-<span class="sourceLineNo">344</span> LOG.info("Close zookeeper connection {} to {}", getId(), connectString);<a name="line.344"></a>
-<span class="sourceLineNo">345</span> tasks.add(CLOSE);<a name="line.345"></a>
-<span class="sourceLineNo">346</span> }<a name="line.346"></a>
-<span class="sourceLineNo">347</span> }<a name="line.347"></a>
-<span class="sourceLineNo">348</span><a name="line.348"></a>
-<span class="sourceLineNo">349</span> @VisibleForTesting<a name="line.349"></a>
-<span class="sourceLineNo">350</span> public String getConnectString() {<a name="line.350"></a>
-<span class="sourceLineNo">351</span> return connectString;<a name="line.351"></a>
-<span class="sourceLineNo">352</span> }<a name="line.352"></a>
-<span class="sourceLineNo">353</span>}<a name="line.353"></a>
+<span class="sourceLineNo">254</span> private static <T> CompletableFuture<T> failed(Throwable e) {<a name="line.254"></a>
+<span class="sourceLineNo">255</span> CompletableFuture<T> future = new CompletableFuture<>();<a name="line.255"></a>
+<span class="sourceLineNo">256</span> future.completeExceptionally(e);<a name="line.256"></a>
+<span class="sourceLineNo">257</span> return future;<a name="line.257"></a>
+<span class="sourceLineNo">258</span> }<a name="line.258"></a>
+<span class="sourceLineNo">259</span><a name="line.259"></a>
+<span class="sourceLineNo">260</span> public CompletableFuture<byte[]> get(String path) {<a name="line.260"></a>
+<span class="sourceLineNo">261</span> if (closed.get()) {<a name="line.261"></a>
+<span class="sourceLineNo">262</span> return failed(new IOException("Client already closed"));<a name="line.262"></a>
+<span class="sourceLineNo">263</span> }<a name="line.263"></a>
+<span class="sourceLineNo">264</span> CompletableFuture<byte[]> future = new CompletableFuture<>();<a name="line.264"></a>
+<span class="sourceLineNo">265</span> tasks.add(new ZKTask<byte[]>(path, future, "get") {<a name="line.265"></a>
+<span class="sourceLineNo">266</span><a name="line.266"></a>
+<span class="sourceLineNo">267</span> @Override<a name="line.267"></a>
+<span class="sourceLineNo">268</span> protected void doExec(ZooKeeper zk) {<a name="line.268"></a>
+<span class="sourceLineNo">269</span> zk.getData(path, false,<a name="line.269"></a>
+<span class="sourceLineNo">270</span> (rc, path, ctx, data, stat) -> onComplete(zk, rc, data, true), null);<a name="line.270"></a>
+<span class="sourceLineNo">271</span> }<a name="line.271"></a>
+<span class="sourceLineNo">272</span> });<a name="line.272"></a>
+<span class="sourceLineNo">273</span> return future;<a name="line.273"></a>
+<span class="sourceLineNo">274</span> }<a name="line.274"></a>
+<span class="sourceLineNo">275</span><a name="line.275"></a>
+<span class="sourceLineNo">276</span> public CompletableFuture<Stat> exists(String path) {<a name="line.276"></a>
+<span class="sourceLineNo">277</span> if (closed.get()) {<a name="line.277"></a>
+<span class="sourceLineNo">278</span> return failed(new IOException("Client already closed"));<a name="line.278"></a>
+<span class="sourceLineNo">279</span> }<a name="line.279"></a>
+<span class="sourceLineNo">280</span> CompletableFuture<Stat> future = new CompletableFuture<>();<a name="line.280"></a>
+<span class="sourceLineNo">281</span> tasks.add(new ZKTask<Stat>(path, future, "exists") {<a name="line.281"></a>
+<span class="sourceLineNo">282</span><a name="line.282"></a>
+<span class="sourceLineNo">283</span> @Override<a name="line.283"></a>
+<span class="sourceLineNo">284</span> protected void doExec(ZooKeeper zk) {<a name="line.284"></a>
+<span class="sourceLineNo">285</span> zk.exists(path, false, (rc, path, ctx, stat) -> onComplete(zk, rc, stat, false), null);<a name="line.285"></a>
+<span class="sourceLineNo">286</span> }<a name="line.286"></a>
+<span class="sourceLineNo">287</span> });<a name="line.287"></a>
+<span class="sourceLineNo">288</span> return future;<a name="line.288"></a>
+<span class="sourceLineNo">289</span> }<a name="line.289"></a>
+<span class="sourceLineNo">290</span><a name="line.290"></a>
+<span class="sourceLineNo">291</span> private void closeZk() {<a name="line.291"></a>
+<span class="sourceLineNo">292</span> if (zookeeper != null) {<a name="line.292"></a>
+<span class="sourceLineNo">293</span> try {<a name="line.293"></a>
+<span class="sourceLineNo">294</span> zookeeper.close();<a name="line.294"></a>
+<span class="sourceLineNo">295</span> } catch (InterruptedException e) {<a name="line.295"></a>
+<span class="sourceLineNo">296</span> }<a name="line.296"></a>
+<span class="sourceLineNo">297</span> zookeeper = null;<a name="line.297"></a>
+<span class="sourceLineNo">298</span> }<a name="line.298"></a>
+<span class="sourceLineNo">299</span> }<a name="line.299"></a>
+<span class="sourceLineNo">300</span><a name="line.300"></a>
+<span class="sourceLineNo">301</span> private ZooKeeper getZk() throws IOException {<a name="line.301"></a>
+<span class="sourceLineNo">302</span> // may be closed when session expired<a name="line.302"></a>
+<span class="sourceLineNo">303</span> if (zookeeper == null || !zookeeper.getState().isAlive()) {<a name="line.303"></a>
+<span class="sourceLineNo">304</span> zookeeper = new ZooKeeper(connectString, sessionTimeoutMs, e -> {});<a name="line.304"></a>
+<span class="sourceLineNo">305</span> }<a name="line.305"></a>
+<span class="sourceLineNo">306</span> return zookeeper;<a name="line.306"></a>
+<span class="sourceLineNo">307</span> }<a name="line.307"></a>
+<span class="sourceLineNo">308</span><a name="line.308"></a>
+<span class="sourceLineNo">309</span> private void run() {<a name="line.309"></a>
+<span class="sourceLineNo">310</span> for (;;) {<a name="line.310"></a>
+<span class="sourceLineNo">311</span> Task task;<a name="line.311"></a>
+<span class="sourceLineNo">312</span> try {<a name="line.312"></a>
+<span class="sourceLineNo">313</span> task = tasks.poll(keepAliveTimeMs, TimeUnit.MILLISECONDS);<a name="line.313"></a>
+<span class="sourceLineNo">314</span> } catch (InterruptedException e) {<a name="line.314"></a>
+<span class="sourceLineNo">315</span> continue;<a name="line.315"></a>
+<span class="sourceLineNo">316</span> }<a name="line.316"></a>
+<span class="sourceLineNo">317</span> if (task == CLOSE) {<a name="line.317"></a>
+<span class="sourceLineNo">318</span> break;<a name="line.318"></a>
+<span class="sourceLineNo">319</span> }<a name="line.319"></a>
+<span class="sourceLineNo">320</span> if (task == null) {<a name="line.320"></a>
+<span class="sourceLineNo">321</span> if (pendingRequests == 0) {<a name="line.321"></a>
+<span class="sourceLineNo">322</span> LOG.trace("{} to {} inactive for {}ms; closing (Will reconnect when new requests)",<a name="line.322"></a>
+<span class="sourceLineNo">323</span> getId(), connectString, keepAliveTimeMs);<a name="line.323"></a>
+<span class="sourceLineNo">324</span> closeZk();<a name="line.324"></a>
+<span class="sourceLineNo">325</span> }<a name="line.325"></a>
+<span class="sourceLineNo">326</span> continue;<a name="line.326"></a>
+<span class="sourceLineNo">327</span> }<a name="line.327"></a>
+<span class="sourceLineNo">328</span> if (!task.needZk()) {<a name="line.328"></a>
+<span class="sourceLineNo">329</span> task.exec(null);<a name="line.329"></a>
+<span class="sourceLineNo">330</span> } else {<a name="line.330"></a>
+<span class="sourceLineNo">331</span> ZooKeeper zk;<a name="line.331"></a>
+<span class="sourceLineNo">332</span> try {<a name="line.332"></a>
+<span class="sourceLineNo">333</span> zk = getZk();<a name="line.333"></a>
+<span class="sourceLineNo">334</span> } catch (IOException e) {<a name="line.334"></a>
+<span class="sourceLineNo">335</span> task.connectFailed(e);<a name="line.335"></a>
+<span class="sourceLineNo">336</span> continue;<a name="line.336"></a>
+<span class="sourceLineNo">337</span> }<a name="line.337"></a>
+<span class="sourceLineNo">338</span> task.exec(zk);<a name="line.338"></a>
+<span class="sourceLineNo">339</span> }<a name="line.339"></a>
+<span class="sourceLineNo">340</span> }<a name="line.340"></a>
+<span class="sourceLineNo">341</span> closeZk();<a name="line.341"></a>
+<span class="sourceLineNo">342</span> IOException error = new IOException("Client already closed");<a name="line.342"></a>
+<span class="sourceLineNo">343</span> Arrays.stream(tasks.toArray(new Task[0])).forEach(t -> t.closed(error));<a name="line.343"></a>
+<span class="sourceLineNo">344</span> tasks.clear();<a name="line.344"></a>
+<span class="sourceLineNo">345</span> }<a name="line.345"></a>
+<span class="sourceLineNo">346</span><a name="line.346"></a>
+<span class="sourceLineNo">347</span> @Override<a name="line.347"></a>
+<span class="sourceLineNo">348</span> public void close() {<a name="line.348"></a>
+<span class="sourceLineNo">349</span> if (closed.compareAndSet(false, true)) {<a name="line.349"></a>
+<span class="sourceLineNo">350</span> LOG.info("Close zookeeper connection {} to {}", getId(), connectString);<a name="line.350"></a>
+<span class="sourceLineNo">351</span> tasks.add(CLOSE);<a name="line.351"></a>
+<span class="sourceLineNo">352</span> }<a name="line.352"></a>
+<span class="sourceLineNo">353</span> }<a name="line.353"></a>
+<span class="sourceLineNo">354</span><a name="line.354"></a>
+<span class="sourceLineNo">355</span> @VisibleForTesting<a name="line.355"></a>
+<span class="sourceLineNo">356</span> public String getConnectString() {<a name="line.356"></a>
+<span class="sourceLineNo">357</span> return connectString;<a name="line.357"></a>
+<span class="sourceLineNo">358</span> }<a name="line.358"></a>
+<span class="sourceLineNo">359</span>}<a name="line.359"></a>
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/2a4c7d89/devapidocs/src-html/org/apache/hadoop/hbase/zookeeper/ReadOnlyZKClient.ZKTask.html
----------------------------------------------------------------------
diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/zookeeper/ReadOnlyZKClient.ZKTask.html b/devapidocs/src-html/org/apache/hadoop/hbase/zookeeper/ReadOnlyZKClient.ZKTask.html
index f845807..1427c4c 100644
--- a/devapidocs/src-html/org/apache/hadoop/hbase/zookeeper/ReadOnlyZKClient.ZKTask.html
+++ b/devapidocs/src-html/org/apache/hadoop/hbase/zookeeper/ReadOnlyZKClient.ZKTask.html
@@ -132,233 +132,239 @@
<span class="sourceLineNo">124</span> }<a name="line.124"></a>
<span class="sourceLineNo">125</span><a name="line.125"></a>
<span class="sourceLineNo">126</span> public ReadOnlyZKClient(Configuration conf) {<a name="line.126"></a>
-<span class="sourceLineNo">127</span> this.connectString = ZKConfig.getZKQuorumServersString(conf);<a name="line.127"></a>
-<span class="sourceLineNo">128</span> this.sessionTimeoutMs = conf.getInt(ZK_SESSION_TIMEOUT, DEFAULT_ZK_SESSION_TIMEOUT);<a name="line.128"></a>
-<span class="sourceLineNo">129</span> this.maxRetries = conf.getInt(RECOVERY_RETRY, DEFAULT_RECOVERY_RETRY);<a name="line.129"></a>
-<span class="sourceLineNo">130</span> this.retryIntervalMs =<a name="line.130"></a>
-<span class="sourceLineNo">131</span> conf.getInt(RECOVERY_RETRY_INTERVAL_MILLIS, DEFAULT_RECOVERY_RETRY_INTERVAL_MILLIS);<a name="line.131"></a>
-<span class="sourceLineNo">132</span> this.keepAliveTimeMs = conf.getInt(KEEPALIVE_MILLIS, DEFAULT_KEEPALIVE_MILLIS);<a name="line.132"></a>
-<span class="sourceLineNo">133</span> LOG.info(<a name="line.133"></a>
-<span class="sourceLineNo">134</span> "Connect {} to {} with session timeout={}ms, retries {}, " +<a name="line.134"></a>
-<span class="sourceLineNo">135</span> "retry interval {}ms, keepAlive={}ms",<a name="line.135"></a>
-<span class="sourceLineNo">136</span> getId(), connectString, sessionTimeoutMs, maxRetries, retryIntervalMs, keepAliveTimeMs);<a name="line.136"></a>
-<span class="sourceLineNo">137</span> Threads.setDaemonThreadRunning(new Thread(this::run),<a name="line.137"></a>
-<span class="sourceLineNo">138</span> "ReadOnlyZKClient-" + connectString + "@" + getId());<a name="line.138"></a>
-<span class="sourceLineNo">139</span> }<a name="line.139"></a>
-<span class="sourceLineNo">140</span><a name="line.140"></a>
-<span class="sourceLineNo">141</span> private abstract class ZKTask<T> extends Task {<a name="line.141"></a>
-<span class="sourceLineNo">142</span><a name="line.142"></a>
-<span class="sourceLineNo">143</span> protected final String path;<a name="line.143"></a>
-<span class="sourceLineNo">144</span><a name="line.144"></a>
-<span class="sourceLineNo">145</span> private final CompletableFuture<T> future;<a name="line.145"></a>
+<span class="sourceLineNo">127</span> // We might use a different ZK for client access<a name="line.127"></a>
+<span class="sourceLineNo">128</span> String clientZkQuorumServers = ZKConfig.getClientZKQuorumServersString(conf);<a name="line.128"></a>
+<span class="sourceLineNo">129</span> if (clientZkQuorumServers != null) {<a name="line.129"></a>
+<span class="sourceLineNo">130</span> this.connectString = clientZkQuorumServers;<a name="line.130"></a>
+<span class="sourceLineNo">131</span> } else {<a name="line.131"></a>
+<span class="sourceLineNo">132</span> this.connectString = ZKConfig.getZKQuorumServersString(conf);<a name="line.132"></a>
+<span class="sourceLineNo">133</span> }<a name="line.133"></a>
+<span class="sourceLineNo">134</span> this.sessionTimeoutMs = conf.getInt(ZK_SESSION_TIMEOUT, DEFAULT_ZK_SESSION_TIMEOUT);<a name="line.134"></a>
+<span class="sourceLineNo">135</span> this.maxRetries = conf.getInt(RECOVERY_RETRY, DEFAULT_RECOVERY_RETRY);<a name="line.135"></a>
+<span class="sourceLineNo">136</span> this.retryIntervalMs =<a name="line.136"></a>
+<span class="sourceLineNo">137</span> conf.getInt(RECOVERY_RETRY_INTERVAL_MILLIS, DEFAULT_RECOVERY_RETRY_INTERVAL_MILLIS);<a name="line.137"></a>
+<span class="sourceLineNo">138</span> this.keepAliveTimeMs = conf.getInt(KEEPALIVE_MILLIS, DEFAULT_KEEPALIVE_MILLIS);<a name="line.138"></a>
+<span class="sourceLineNo">139</span> LOG.info(<a name="line.139"></a>
+<span class="sourceLineNo">140</span> "Connect {} to {} with session timeout={}ms, retries {}, " +<a name="line.140"></a>
+<span class="sourceLineNo">141</span> "retry interval {}ms, keepAlive={}ms",<a name="line.141"></a>
+<span class="sourceLineNo">142</span> getId(), connectString, sessionTimeoutMs, maxRetries, retryIntervalMs, keepAliveTimeMs);<a name="line.142"></a>
+<span class="sourceLineNo">143</span> Threads.setDaemonThreadRunning(new Thread(this::run),<a name="line.143"></a>
+<span class="sourceLineNo">144</span> "ReadOnlyZKClient-" + connectString + "@" + getId());<a name="line.144"></a>
+<span class="sourceLineNo">145</span> }<a name="line.145"></a>
<span class="sourceLineNo">146</span><a name="line.146"></a>
-<span class="sourceLineNo">147</span> private final String operationType;<a name="line.147"></a>
+<span class="sourceLineNo">147</span> private abstract class ZKTask<T> extends Task {<a name="line.147"></a>
<span class="sourceLineNo">148</span><a name="line.148"></a>
-<span class="sourceLineNo">149</span> private int retries;<a name="line.149"></a>
+<span class="sourceLineNo">149</span> protected final String path;<a name="line.149"></a>
<span class="sourceLineNo">150</span><a name="line.150"></a>
-<span class="sourceLineNo">151</span> protected ZKTask(String path, CompletableFuture<T> future, String operationType) {<a name="line.151"></a>
-<span class="sourceLineNo">152</span> this.path = path;<a name="line.152"></a>
-<span class="sourceLineNo">153</span> this.future = future;<a name="line.153"></a>
-<span class="sourceLineNo">154</span> this.operationType = operationType;<a name="line.154"></a>
-<span class="sourceLineNo">155</span> }<a name="line.155"></a>
+<span class="sourceLineNo">151</span> private final CompletableFuture<T> future;<a name="line.151"></a>
+<span class="sourceLineNo">152</span><a name="line.152"></a>
+<span class="sourceLineNo">153</span> private final String operationType;<a name="line.153"></a>
+<span class="sourceLineNo">154</span><a name="line.154"></a>
+<span class="sourceLineNo">155</span> private int retries;<a name="line.155"></a>
<span class="sourceLineNo">156</span><a name="line.156"></a>
-<span class="sourceLineNo">157</span> protected final void onComplete(ZooKeeper zk, int rc, T ret, boolean errorIfNoNode) {<a name="line.157"></a>
-<span class="sourceLineNo">158</span> tasks.add(new Task() {<a name="line.158"></a>
-<span class="sourceLineNo">159</span><a name="line.159"></a>
-<span class="sourceLineNo">160</span> @Override<a name="line.160"></a>
-<span class="sourceLineNo">161</span> public void exec(ZooKeeper alwaysNull) {<a name="line.161"></a>
-<span class="sourceLineNo">162</span> pendingRequests--;<a name="line.162"></a>
-<span class="sourceLineNo">163</span> Code code = Code.get(rc);<a name="line.163"></a>
-<span class="sourceLineNo">164</span> if (code == Code.OK) {<a name="line.164"></a>
-<span class="sourceLineNo">165</span> future.complete(ret);<a name="line.165"></a>
-<span class="sourceLineNo">166</span> } else if (code == Code.NONODE) {<a name="line.166"></a>
-<span class="sourceLineNo">167</span> if (errorIfNoNode) {<a name="line.167"></a>
-<span class="sourceLineNo">168</span> future.completeExceptionally(KeeperException.create(code, path));<a name="line.168"></a>
-<span class="sourceLineNo">169</span> } else {<a name="line.169"></a>
-<span class="sourceLineNo">170</span> future.complete(ret);<a name="line.170"></a>
-<span class="sourceLineNo">171</span> }<a name="line.171"></a>
-<span class="sourceLineNo">172</span> } else if (FAIL_FAST_CODES.contains(code)) {<a name="line.172"></a>
-<span class="sourceLineNo">173</span> future.completeExceptionally(KeeperException.create(code, path));<a name="line.173"></a>
-<span class="sourceLineNo">174</span> } else {<a name="line.174"></a>
-<span class="sourceLineNo">175</span> if (code == Code.SESSIONEXPIRED) {<a name="line.175"></a>
-<span class="sourceLineNo">176</span> LOG.warn("{} to {} session expired, close and reconnect", getId(), connectString);<a name="line.176"></a>
-<span class="sourceLineNo">177</span> try {<a name="line.177"></a>
-<span class="sourceLineNo">178</span> zk.close();<a name="line.178"></a>
-<span class="sourceLineNo">179</span> } catch (InterruptedException e) {<a name="line.179"></a>
-<span class="sourceLineNo">180</span> }<a name="line.180"></a>
-<span class="sourceLineNo">181</span> }<a name="line.181"></a>
-<span class="sourceLineNo">182</span> if (ZKTask.this.delay(retryIntervalMs, maxRetries)) {<a name="line.182"></a>
-<span class="sourceLineNo">183</span> LOG.warn("{} to {} failed for {} of {}, code = {}, retries = {}", getId(),<a name="line.183"></a>
-<span class="sourceLineNo">184</span> connectString, operationType, path, code, ZKTask.this.retries);<a name="line.184"></a>
-<span class="sourceLineNo">185</span> tasks.add(ZKTask.this);<a name="line.185"></a>
-<span class="sourceLineNo">186</span> } else {<a name="line.186"></a>
-<span class="sourceLineNo">187</span> LOG.warn("{} to {} failed for {} of {}, code = {}, retries = {}, give up", getId(),<a name="line.187"></a>
-<span class="sourceLineNo">188</span> connectString, operationType, path, code, ZKTask.this.retries);<a name="line.188"></a>
-<span class="sourceLineNo">189</span> future.completeExceptionally(KeeperException.create(code, path));<a name="line.189"></a>
-<span class="sourceLineNo">190</span> }<a name="line.190"></a>
-<span class="sourceLineNo">191</span> }<a name="line.191"></a>
-<span class="sourceLineNo">192</span> }<a name="line.192"></a>
-<span class="sourceLineNo">193</span><a name="line.193"></a>
-<span class="sourceLineNo">194</span> @Override<a name="line.194"></a>
-<span class="sourceLineNo">195</span> public void closed(IOException e) {<a name="line.195"></a>
-<span class="sourceLineNo">196</span> // It may happen that a request is succeeded and the onComplete has been called and pushed<a name="line.196"></a>
-<span class="sourceLineNo">197</span> // us into the task queue, but before we get called a close is called and here we will<a name="line.197"></a>
-<span class="sourceLineNo">198</span> // fail the request, although it is succeeded actually.<a name="line.198"></a>
-<span class="sourceLineNo">199</span> // This is not a perfect solution but anyway, it is better than hang the requests for<a name="line.199"></a>
-<span class="sourceLineNo">200</span> // ever, and also acceptable as if you close the zk client before actually getting the<a name="line.200"></a>
-<span class="sourceLineNo">201</span> // response then a failure is always possible.<a name="line.201"></a>
-<span class="sourceLineNo">202</span> future.completeExceptionally(e);<a name="line.202"></a>
-<span class="sourceLineNo">203</span> }<a name="line.203"></a>
-<span class="sourceLineNo">204</span> });<a name="line.204"></a>
-<span class="sourceLineNo">205</span> }<a name="line.205"></a>
-<span class="sourceLineNo">206</span><a name="line.206"></a>
-<span class="sourceLineNo">207</span> @Override<a name="line.207"></a>
-<span class="sourceLineNo">208</span> public boolean needZk() {<a name="line.208"></a>
-<span class="sourceLineNo">209</span> return true;<a name="line.209"></a>
-<span class="sourceLineNo">210</span> }<a name="line.210"></a>
-<span class="sourceLineNo">211</span><a name="line.211"></a>
-<span class="sourceLineNo">212</span> protected abstract void doExec(ZooKeeper zk);<a name="line.212"></a>
-<span class="sourceLineNo">213</span><a name="line.213"></a>
-<span class="sourceLineNo">214</span> @Override<a name="line.214"></a>
-<span class="sourceLineNo">215</span> public final void exec(ZooKeeper zk) {<a name="line.215"></a>
-<span class="sourceLineNo">216</span> pendingRequests++;<a name="line.216"></a>
-<span class="sourceLineNo">217</span> doExec(zk);<a name="line.217"></a>
-<span class="sourceLineNo">218</span> }<a name="line.218"></a>
+<span class="sourceLineNo">157</span> protected ZKTask(String path, CompletableFuture<T> future, String operationType) {<a name="line.157"></a>
+<span class="sourceLineNo">158</span> this.path = path;<a name="line.158"></a>
+<span class="sourceLineNo">159</span> this.future = future;<a name="line.159"></a>
+<span class="sourceLineNo">160</span> this.operationType = operationType;<a name="line.160"></a>
+<span class="sourceLineNo">161</span> }<a name="line.161"></a>
+<span class="sourceLineNo">162</span><a name="line.162"></a>
+<span class="sourceLineNo">163</span> protected final void onComplete(ZooKeeper zk, int rc, T ret, boolean errorIfNoNode) {<a name="line.163"></a>
+<span class="sourceLineNo">164</span> tasks.add(new Task() {<a name="line.164"></a>
+<span class="sourceLineNo">165</span><a name="line.165"></a>
+<span class="sourceLineNo">166</span> @Override<a name="line.166"></a>
+<span class="sourceLineNo">167</span> public void exec(ZooKeeper alwaysNull) {<a name="line.167"></a>
+<span class="sourceLineNo">168</span> pendingRequests--;<a name="line.168"></a>
+<span class="sourceLineNo">169</span> Code code = Code.get(rc);<a name="line.169"></a>
+<span class="sourceLineNo">170</span> if (code == Code.OK) {<a name="line.170"></a>
+<span class="sourceLineNo">171</span> future.complete(ret);<a name="line.171"></a>
+<span class="sourceLineNo">172</span> } else if (code == Code.NONODE) {<a name="line.172"></a>
+<span class="sourceLineNo">173</span> if (errorIfNoNode) {<a name="line.173"></a>
+<span class="sourceLineNo">174</span> future.completeExceptionally(KeeperException.create(code, path));<a name="line.174"></a>
+<span class="sourceLineNo">175</span> } else {<a name="line.175"></a>
+<span class="sourceLineNo">176</span> future.complete(ret);<a name="line.176"></a>
+<span class="sourceLineNo">177</span> }<a name="line.177"></a>
+<span class="sourceLineNo">178</span> } else if (FAIL_FAST_CODES.contains(code)) {<a name="line.178"></a>
+<span class="sourceLineNo">179</span> future.completeExceptionally(KeeperException.create(code, path));<a name="line.179"></a>
+<span class="sourceLineNo">180</span> } else {<a name="line.180"></a>
+<span class="sourceLineNo">181</span> if (code == Code.SESSIONEXPIRED) {<a name="line.181"></a>
+<span class="sourceLineNo">182</span> LOG.warn("{} to {} session expired, close and reconnect", getId(), connectString);<a name="line.182"></a>
+<span class="sourceLineNo">183</span> try {<a name="line.183"></a>
+<span class="sourceLineNo">184</span> zk.close();<a name="line.184"></a>
+<span class="sourceLineNo">185</span> } catch (InterruptedException e) {<a name="line.185"></a>
+<span class="sourceLineNo">186</span> }<a name="line.186"></a>
+<span class="sourceLineNo">187</span> }<a name="line.187"></a>
+<span class="sourceLineNo">188</span> if (ZKTask.this.delay(retryIntervalMs, maxRetries)) {<a name="line.188"></a>
+<span class="sourceLineNo">189</span> LOG.warn("{} to {} failed for {} of {}, code = {}, retries = {}", getId(),<a name="line.189"></a>
+<span class="sourceLineNo">190</span> connectString, operationType, path, code, ZKTask.this.retries);<a name="line.190"></a>
+<span class="sourceLineNo">191</span> tasks.add(ZKTask.this);<a name="line.191"></a>
+<span class="sourceLineNo">192</span> } else {<a name="line.192"></a>
+<span class="sourceLineNo">193</span> LOG.warn("{} to {} failed for {} of {}, code = {}, retries = {}, give up", getId(),<a name="line.193"></a>
+<span class="sourceLineNo">194</span> connectString, operationType, path, code, ZKTask.this.retries);<a name="line.194"></a>
+<span class="sourceLineNo">195</span> future.completeExceptionally(KeeperException.create(code, path));<a name="line.195"></a>
+<span class="sourceLineNo">196</span> }<a name="line.196"></a>
+<span class="sourceLineNo">197</span> }<a name="line.197"></a>
+<span class="sourceLineNo">198</span> }<a name="line.198"></a>
+<span class="sourceLineNo">199</span><a name="line.199"></a>
+<span class="sourceLineNo">200</span> @Override<a name="line.200"></a>
+<span class="sourceLineNo">201</span> public void closed(IOException e) {<a name="line.201"></a>
+<span class="sourceLineNo">202</span> // It may happen that a request is succeeded and the onComplete has been called and pushed<a name="line.202"></a>
+<span class="sourceLineNo">203</span> // us into the task queue, but before we get called a close is called and here we will<a name="line.203"></a>
+<span class="sourceLineNo">204</span> // fail the request, although it is succeeded actually.<a name="line.204"></a>
+<span class="sourceLineNo">205</span> // This is not a perfect solution but anyway, it is better than hang the requests for<a name="line.205"></a>
+<span class="sourceLineNo">206</span> // ever, and also acceptable as if you close the zk client before actually getting the<a name="line.206"></a>
+<span class="sourceLineNo">207</span> // response then a failure is always possible.<a name="line.207"></a>
+<span class="sourceLineNo">208</span> future.completeExceptionally(e);<a name="line.208"></a>
+<span class="sourceLineNo">209</span> }<a name="line.209"></a>
+<span class="sourceLineNo">210</span> });<a name="line.210"></a>
+<span class="sourceLineNo">211</span> }<a name="line.211"></a>
+<span class="sourceLineNo">212</span><a name="line.212"></a>
+<span class="sourceLineNo">213</span> @Override<a name="line.213"></a>
+<span class="sourceLineNo">214</span> public boolean needZk() {<a name="line.214"></a>
+<span class="sourceLineNo">215</span> return true;<a name="line.215"></a>
+<span class="sourceLineNo">216</span> }<a name="line.216"></a>
+<span class="sourceLineNo">217</span><a name="line.217"></a>
+<span class="sourceLineNo">218</span> protected abstract void doExec(ZooKeeper zk);<a name="line.218"></a>
<span class="sourceLineNo">219</span><a name="line.219"></a>
-<span class="sourceLineNo">220</span> public boolean delay(long intervalMs, int maxRetries) {<a name="line.220"></a>
-<span class="sourceLineNo">221</span> if (retries >= maxRetries) {<a name="line.221"></a>
-<span class="sourceLineNo">222</span> return false;<a name="line.222"></a>
-<span class="sourceLineNo">223</span> }<a name="line.223"></a>
-<span class="sourceLineNo">224</span> retries++;<a name="line.224"></a>
-<span class="sourceLineNo">225</span> time = System.nanoTime() + TimeUnit.MILLISECONDS.toNanos(intervalMs);<a name="line.225"></a>
-<span class="sourceLineNo">226</span> return true;<a name="line.226"></a>
-<span class="sourceLineNo">227</span> }<a name="line.227"></a>
-<span class="sourceLineNo">228</span><a name="line.228"></a>
-<span class="sourceLineNo">229</span> @Override<a name="line.229"></a>
-<span class="sourceLineNo">230</span> public void connectFailed(IOException e) {<a name="line.230"></a>
-<span class="sourceLineNo">231</span> if (delay(retryIntervalMs, maxRetries)) {<a name="line.231"></a>
-<span class="sourceLineNo">232</span> LOG.warn("{} to {} failed to connect to zk fo {} of {}, retries = {}", getId(),<a name="line.232"></a>
-<span class="sourceLineNo">233</span> connectString, operationType, path, retries, e);<a name="line.233"></a>
-<span class="sourceLineNo">234</span> tasks.add(this);<a name="line.234"></a>
-<span class="sourceLineNo">235</span> } else {<a name="line.235"></a>
-<span class="sourceLineNo">236</span> LOG.warn("{} to {} failed to connect to zk fo {} of {}, retries = {}, give up", getId(),<a name="line.236"></a>
-<span class="sourceLineNo">237</span> connectString, operationType, path, retries, e);<a name="line.237"></a>
-<span class="sourceLineNo">238</span> future.completeExceptionally(e);<a name="line.238"></a>
-<span class="sourceLineNo">239</span> }<a name="line.239"></a>
-<span class="sourceLineNo">240</span> }<a name="line.240"></a>
-<span class="sourceLineNo">241</span><a name="line.241"></a>
-<span class="sourceLineNo">242</span> @Override<a name="line.242"></a>
-<span class="sourceLineNo">243</span> public void closed(IOException e) {<a name="line.243"></a>
-<span class="sourceLineNo">244</span> future.completeExceptionally(e);<a name="line.244"></a>
-<span class="sourceLineNo">245</span> }<a name="line.245"></a>
-<span class="sourceLineNo">246</span> }<a name="line.246"></a>
+<span class="sourceLineNo">220</span> @Override<a name="line.220"></a>
+<span class="sourceLineNo">221</span> public final void exec(ZooKeeper zk) {<a name="line.221"></a>
+<span class="sourceLineNo">222</span> pendingRequests++;<a name="line.222"></a>
+<span class="sourceLineNo">223</span> doExec(zk);<a name="line.223"></a>
+<span class="sourceLineNo">224</span> }<a name="line.224"></a>
+<span class="sourceLineNo">225</span><a name="line.225"></a>
+<span class="sourceLineNo">226</span> public boolean delay(long intervalMs, int maxRetries) {<a name="line.226"></a>
+<span class="sourceLineNo">227</span> if (retries >= maxRetries) {<a name="line.227"></a>
+<span class="sourceLineNo">228</span> return false;<a name="line.228"></a>
+<span class="sourceLineNo">229</span> }<a name="line.229"></a>
+<span class="sourceLineNo">230</span> retries++;<a name="line.230"></a>
+<span class="sourceLineNo">231</span> time = System.nanoTime() + TimeUnit.MILLISECONDS.toNanos(intervalMs);<a name="line.231"></a>
+<span class="sourceLineNo">232</span> return true;<a name="line.232"></a>
+<span class="sourceLineNo">233</span> }<a name="line.233"></a>
+<span class="sourceLineNo">234</span><a name="line.234"></a>
+<span class="sourceLineNo">235</span> @Override<a name="line.235"></a>
+<span class="sourceLineNo">236</span> public void connectFailed(IOException e) {<a name="line.236"></a>
+<span class="sourceLineNo">237</span> if (delay(retryIntervalMs, maxRetries)) {<a name="line.237"></a>
+<span class="sourceLineNo">238</span> LOG.warn("{} to {} failed to connect to zk fo {} of {}, retries = {}", getId(),<a name="line.238"></a>
+<span class="sourceLineNo">239</span> connectString, operationType, path, retries, e);<a name="line.239"></a>
+<span class="sourceLineNo">240</span> tasks.add(this);<a name="line.240"></a>
+<span class="sourceLineNo">241</span> } else {<a name="line.241"></a>
+<span class="sourceLineNo">242</span> LOG.warn("{} to {} failed to connect to zk fo {} of {}, retries = {}, give up", getId(),<a name="line.242"></a>
+<span class="sourceLineNo">243</span> connectString, operationType, path, retries, e);<a name="line.243"></a>
+<span class="sourceLineNo">244</span> future.completeExceptionally(e);<a name="line.244"></a>
+<span class="sourceLineNo">245</span> }<a name="line.245"></a>
+<span class="sourceLineNo">246</span> }<a name="line.246"></a>
<span class="sourceLineNo">247</span><a name="line.247"></a>
-<span class="sourceLineNo">248</span> private static <T> CompletableFuture<T> failed(Throwable e) {<a name="line.248"></a>
-<span class="sourceLineNo">249</span> CompletableFuture<T> future = new CompletableFuture<>();<a name="line.249"></a>
-<span class="sourceLineNo">250</span> future.completeExceptionally(e);<a name="line.250"></a>
-<span class="sourceLineNo">251</span> return future;<a name="line.251"></a>
+<span class="sourceLineNo">248</span> @Override<a name="line.248"></a>
+<span class="sourceLineNo">249</span> public void closed(IOException e) {<a name="line.249"></a>
+<span class="sourceLineNo">250</span> future.completeExceptionally(e);<a name="line.250"></a>
+<span class="sourceLineNo">251</span> }<a name="line.251"></a>
<span class="sourceLineNo">252</span> }<a name="line.252"></a>
<span class="sourceLineNo">253</span><a name="line.253"></a>
-<span class="sourceLineNo">254</span> public CompletableFuture<byte[]> get(String path) {<a name="line.254"></a>
-<span class="sourceLineNo">255</span> if (closed.get()) {<a name="line.255"></a>
-<span class="sourceLineNo">256</span> return failed(new IOException("Client already closed"));<a name="line.256"></a>
-<span class="sourceLineNo">257</span> }<a name="line.257"></a>
-<span class="sourceLineNo">258</span> CompletableFuture<byte[]> future = new CompletableFuture<>();<a name="line.258"></a>
-<span class="sourceLineNo">259</span> tasks.add(new ZKTask<byte[]>(path, future, "get") {<a name="line.259"></a>
-<span class="sourceLineNo">260</span><a name="line.260"></a>
-<span class="sourceLineNo">261</span> @Override<a name="line.261"></a>
-<span class="sourceLineNo">262</span> protected void doExec(ZooKeeper zk) {<a name="line.262"></a>
-<span class="sourceLineNo">263</span> zk.getData(path, false,<a name="line.263"></a>
-<span class="sourceLineNo">264</span> (rc, path, ctx, data, stat) -> onComplete(zk, rc, data, true), null);<a name="line.264"></a>
-<span class="sourceLineNo">265</span> }<a name="line.265"></a>
-<span class="sourceLineNo">266</span> });<a name="line.266"></a>
-<span class="sourceLineNo">267</span> return future;<a name="line.267"></a>
-<span class="sourceLineNo">268</span> }<a name="line.268"></a>
-<span class="sourceLineNo">269</span><a name="line.269"></a>
-<span class="sourceLineNo">270</span> public CompletableFuture<Stat> exists(String path) {<a name="line.270"></a>
-<span class="sourceLineNo">271</span> if (closed.get()) {<a name="line.271"></a>
-<span class="sourceLineNo">272</span> return failed(new IOException("Client already closed"));<a name="line.272"></a>
-<span class="sourceLineNo">273</span> }<a name="line.273"></a>
-<span class="sourceLineNo">274</span> CompletableFuture<Stat> future = new CompletableFuture<>();<a name="line.274"></a>
-<span class="sourceLineNo">275</span> tasks.add(new ZKTask<Stat>(path, future, "exists") {<a name="line.275"></a>
-<span class="sourceLineNo">276</span><a name="line.276"></a>
-<span class="sourceLineNo">277</span> @Override<a name="line.277"></a>
-<span class="sourceLineNo">278</span> protected void doExec(ZooKeeper zk) {<a name="line.278"></a>
-<span class="sourceLineNo">279</span> zk.exists(path, false, (rc, path, ctx, stat) -> onComplete(zk, rc, stat, false), null);<a name="line.279"></a>
-<span class="sourceLineNo">280</span> }<a name="line.280"></a>
-<span class="sourceLineNo">281</span> });<a name="line.281"></a>
-<span class="sourceLineNo">282</span> return future;<a name="line.282"></a>
-<span class="sourceLineNo">283</span> }<a name="line.283"></a>
-<span class="sourceLineNo">284</span><a name="line.284"></a>
-<span class="sourceLineNo">285</span> private void closeZk() {<a name="line.285"></a>
-<span class="sourceLineNo">286</span> if (zookeeper != null) {<a name="line.286"></a>
-<span class="sourceLineNo">287</span> try {<a name="line.287"></a>
-<span class="sourceLineNo">288</span> zookeeper.close();<a name="line.288"></a>
-<span class="sourceLineNo">289</span> } catch (InterruptedException e) {<a name="line.289"></a>
-<span class="sourceLineNo">290</span> }<a name="line.290"></a>
-<span class="sourceLineNo">291</span> zookeeper = null;<a name="line.291"></a>
-<span class="sourceLineNo">292</span> }<a name="line.292"></a>
-<span class="sourceLineNo">293</span> }<a name="line.293"></a>
-<span class="sourceLineNo">294</span><a name="line.294"></a>
-<span class="sourceLineNo">295</span> private ZooKeeper getZk() throws IOException {<a name="line.295"></a>
-<span class="sourceLineNo">296</span> // may be closed when session expired<a name="line.296"></a>
-<span class="sourceLineNo">297</span> if (zookeeper == null || !zookeeper.getState().isAlive()) {<a name="line.297"></a>
-<span class="sourceLineNo">298</span> zookeeper = new ZooKeeper(connectString, sessionTimeoutMs, e -> {});<a name="line.298"></a>
-<span class="sourceLineNo">299</span> }<a name="line.299"></a>
-<span class="sourceLineNo">300</span> return zookeeper;<a name="line.300"></a>
-<span class="sourceLineNo">301</span> }<a name="line.301"></a>
-<span class="sourceLineNo">302</span><a name="line.302"></a>
-<span class="sourceLineNo">303</span> private void run() {<a name="line.303"></a>
-<span class="sourceLineNo">304</span> for (;;) {<a name="line.304"></a>
-<span class="sourceLineNo">305</span> Task task;<a name="line.305"></a>
-<span class="sourceLineNo">306</span> try {<a name="line.306"></a>
-<span class="sourceLineNo">307</span> task = tasks.poll(keepAliveTimeMs, TimeUnit.MILLISECONDS);<a name="line.307"></a>
-<span class="sourceLineNo">308</span> } catch (InterruptedException e) {<a name="line.308"></a>
-<span class="sourceLineNo">309</span> continue;<a name="line.309"></a>
-<span class="sourceLineNo">310</span> }<a name="line.310"></a>
-<span class="sourceLineNo">311</span> if (task == CLOSE) {<a name="line.311"></a>
-<span class="sourceLineNo">312</span> break;<a name="line.312"></a>
-<span class="sourceLineNo">313</span> }<a name="line.313"></a>
-<span class="sourceLineNo">314</span> if (task == null) {<a name="line.314"></a>
-<span class="sourceLineNo">315</span> if (pendingRequests == 0) {<a name="line.315"></a>
-<span class="sourceLineNo">316</span> LOG.trace("{} to {} inactive for {}ms; closing (Will reconnect when new requests)",<a name="line.316"></a>
-<span class="sourceLineNo">317</span> getId(), connectString, keepAliveTimeMs);<a name="line.317"></a>
-<span class="sourceLineNo">318</span> closeZk();<a name="line.318"></a>
-<span class="sourceLineNo">319</span> }<a name="line.319"></a>
-<span class="sourceLineNo">320</span> continue;<a name="line.320"></a>
-<span class="sourceLineNo">321</span> }<a name="line.321"></a>
-<span class="sourceLineNo">322</span> if (!task.needZk()) {<a name="line.322"></a>
-<span class="sourceLineNo">323</span> task.exec(null);<a name="line.323"></a>
-<span class="sourceLineNo">324</span> } else {<a name="line.324"></a>
-<span class="sourceLineNo">325</span> ZooKeeper zk;<a name="line.325"></a>
-<span class="sourceLineNo">326</span> try {<a name="line.326"></a>
-<span class="sourceLineNo">327</span> zk = getZk();<a name="line.327"></a>
-<span class="sourceLineNo">328</span> } catch (IOException e) {<a name="line.328"></a>
-<span class="sourceLineNo">329</span> task.connectFailed(e);<a name="line.329"></a>
-<span class="sourceLineNo">330</span> continue;<a name="line.330"></a>
-<span class="sourceLineNo">331</span> }<a name="line.331"></a>
-<span class="sourceLineNo">332</span> task.exec(zk);<a name="line.332"></a>
-<span class="sourceLineNo">333</span> }<a name="line.333"></a>
-<span class="sourceLineNo">334</span> }<a name="line.334"></a>
-<span class="sourceLineNo">335</span> closeZk();<a name="line.335"></a>
-<span class="sourceLineNo">336</span> IOException error = new IOException("Client already closed");<a name="line.336"></a>
-<span class="sourceLineNo">337</span> Arrays.stream(tasks.toArray(new Task[0])).forEach(t -> t.closed(error));<a name="line.337"></a>
-<span class="sourceLineNo">338</span> tasks.clear();<a name="line.338"></a>
-<span class="sourceLineNo">339</span> }<a name="line.339"></a>
-<span class="sourceLineNo">340</span><a name="line.340"></a>
-<span class="sourceLineNo">341</span> @Override<a name="line.341"></a>
-<span class="sourceLineNo">342</span> public void close() {<a name="line.342"></a>
-<span class="sourceLineNo">343</span> if (closed.compareAndSet(false, true)) {<a name="line.343"></a>
-<span class="sourceLineNo">344</span> LOG.info("Close zookeeper connection {} to {}", getId(), connectString);<a name="line.344"></a>
-<span class="sourceLineNo">345</span> tasks.add(CLOSE);<a name="line.345"></a>
-<span class="sourceLineNo">346</span> }<a name="line.346"></a>
-<span class="sourceLineNo">347</span> }<a name="line.347"></a>
-<span class="sourceLineNo">348</span><a name="line.348"></a>
-<span class="sourceLineNo">349</span> @VisibleForTesting<a name="line.349"></a>
-<span class="sourceLineNo">350</span> public String getConnectString() {<a name="line.350"></a>
-<span class="sourceLineNo">351</span> return connectString;<a name="line.351"></a>
-<span class="sourceLineNo">352</span> }<a name="line.352"></a>
-<span class="sourceLineNo">353</span>}<a name="line.353"></a>
+<span class="sourceLineNo">254</span> private static <T> CompletableFuture<T> failed(Throwable e) {<a name="line.254"></a>
+<span class="sourceLineNo">255</span> CompletableFuture<T> future = new CompletableFuture<>();<a name="line.255"></a>
+<span class="sourceLineNo">256</span> future.completeExceptionally(e);<a name="line.256"></a>
+<span class="sourceLineNo">257</span> return future;<a name="line.257"></a>
+<span class="sourceLineNo">258</span> }<a name="line.258"></a>
+<span class="sourceLineNo">259</span><a name="line.259"></a>
+<span class="sourceLineNo">260</span> public CompletableFuture<byte[]> get(String path) {<a name="line.260"></a>
+<span class="sourceLineNo">261</span> if (closed.get()) {<a name="line.261"></a>
+<span class="sourceLineNo">262</span> return failed(new IOException("Client already closed"));<a name="line.262"></a>
+<span class="sourceLineNo">263</span> }<a name="line.263"></a>
+<span class="sourceLineNo">264</span> CompletableFuture<byte[]> future = new CompletableFuture<>();<a name="line.264"></a>
+<span class="sourceLineNo">265</span> tasks.add(new ZKTask<byte[]>(path, future, "get") {<a name="line.265"></a>
+<span class="sourceLineNo">266</span><a name="line.266"></a>
+<span class="sourceLineNo">267</span> @Override<a name="line.267"></a>
+<span class="sourceLineNo">268</span> protected void doExec(ZooKeeper zk) {<a name="line.268"></a>
+<span class="sourceLineNo">269</span> zk.getData(path, false,<a name="line.269"></a>
+<span class="sourceLineNo">270</span> (rc, path, ctx, data, stat) -> onComplete(zk, rc, data, true), null);<a name="line.270"></a>
+<span class="sourceLineNo">271</span> }<a name="line.271"></a>
+<span class="sourceLineNo">272</span> });<a name="line.272"></a>
+<span class="sourceLineNo">273</span> return future;<a name="line.273"></a>
+<span class="sourceLineNo">274</span> }<a name="line.274"></a>
+<span class="sourceLineNo">275</span><a name="line.275"></a>
+<span class="sourceLineNo">276</span> public CompletableFuture<Stat> exists(String path) {<a name="line.276"></a>
+<span class="sourceLineNo">277</span> if (closed.get()) {<a name="line.277"></a>
+<span class="sourceLineNo">278</span> return failed(new IOException("Client already closed"));<a name="line.278"></a>
+<span class="sourceLineNo">279</span> }<a name="line.279"></a>
+<span class="sourceLineNo">280</span> CompletableFuture<Stat> future = new CompletableFuture<>();<a name="line.280"></a>
+<span class="sourceLineNo">281</span> tasks.add(new ZKTask<Stat>(path, future, "exists") {<a name="line.281"></a>
+<span class="sourceLineNo">282</span><a name="line.282"></a>
+<span class="sourceLineNo">283</span> @Override<a name="line.283"></a>
+<span class="sourceLineNo">284</span> protected void doExec(ZooKeeper zk) {<a name="line.284"></a>
+<span class="sourceLineNo">285</span> zk.exists(path, false, (rc, path, ctx, stat) -> onComplete(zk, rc, stat, false), null);<a name="line.285"></a>
+<span class="sourceLineNo">286</span> }<a name="line.286"></a>
+<span class="sourceLineNo">287</span> });<a name="line.287"></a>
+<span class="sourceLineNo">288</span> return future;<a name="line.288"></a>
+<span class="sourceLineNo">289</span> }<a name="line.289"></a>
+<span class="sourceLineNo">290</span><a name="line.290"></a>
+<span class="sourceLineNo">291</span> private void closeZk() {<a name="line.291"></a>
+<span class="sourceLineNo">292</span> if (zookeeper != null) {<a name="line.292"></a>
+<span class="sourceLineNo">293</span> try {<a name="line.293"></a>
+<span class="sourceLineNo">294</span> zookeeper.close();<a name="line.294"></a>
+<span class="sourceLineNo">295</span> } catch (InterruptedException e) {<a name="line.295"></a>
+<span class="sourceLineNo">296</span> }<a name="line.296"></a>
+<span class="sourceLineNo">297</span> zookeeper = null;<a name="line.297"></a>
+<span class="sourceLineNo">298</span> }<a name="line.298"></a>
+<span class="sourceLineNo">299</span> }<a name="line.299"></a>
+<span class="sourceLineNo">300</span><a name="line.300"></a>
+<span class="sourceLineNo">301</span> private ZooKeeper getZk() throws IOException {<a name="line.301"></a>
+<span class="sourceLineNo">302</span> // may be closed when session expired<a name="line.302"></a>
+<span class="sourceLineNo">303</span> if (zookeeper == null || !zookeeper.getState().isAlive()) {<a name="line.303"></a>
+<span class="sourceLineNo">304</span> zookeeper = new ZooKeeper(connectString, sessionTimeoutMs, e -> {});<a name="line.304"></a>
+<span class="sourceLineNo">305</span> }<a name="line.305"></a>
+<span class="sourceLineNo">306</span> return zookeeper;<a name="line.306"></a>
+<span class="sourceLineNo">307</span> }<a name="line.307"></a>
+<span class="sourceLineNo">308</span><a name="line.308"></a>
+<span class="sourceLineNo">309</span> private void run() {<a name="line.309"></a>
+<span class="sourceLineNo">310</span> for (;;) {<a name="line.310"></a>
+<span class="sourceLineNo">311</span> Task task;<a name="line.311"></a>
+<span class="sourceLineNo">312</span> try {<a name="line.312"></a>
+<span class="sourceLineNo">313</span> task = tasks.poll(keepAliveTimeMs, TimeUnit.MILLISECONDS);<a name="line.313"></a>
+<span class="sourceLineNo">314</span> } catch (InterruptedException e) {<a name="line.314"></a>
+<span class="sourceLineNo">315</span> continue;<a name="line.315"></a>
+<span class="sourceLineNo">316</span> }<a name="line.316"></a>
+<span class="sourceLineNo">317</span> if (task == CLOSE) {<a name="line.317"></a>
+<span class="sourceLineNo">318</span> break;<a name="line.318"></a>
+<span class="sourceLineNo">319</span> }<a name="line.319"></a>
+<span class="sourceLineNo">320</span> if (task == null) {<a name="line.320"></a>
+<span class="sourceLineNo">321</span> if (pendingRequests == 0) {<a name="line.321"></a>
+<span class="sourceLineNo">322</span> LOG.trace("{} to {} inactive for {}ms; closing (Will reconnect when new requests)",<a name="line.322"></a>
+<span class="sourceLineNo">323</span> getId(), connectString, keepAliveTimeMs);<a name="line.323"></a>
+<span class="sourceLineNo">324</span> closeZk();<a name="line.324"></a>
+<span class="sourceLineNo">325</span> }<a name="line.325"></a>
+<span class="sourceLineNo">326</span> continue;<a name="line.326"></a>
+<span class="sourceLineNo">327</span> }<a name="line.327"></a>
+<span class="sourceLineNo">328</span> if (!task.needZk()) {<a name="line.328"></a>
+<span class="sourceLineNo">329</span> task.exec(null);<a name="line.329"></a>
+<span class="sourceLineNo">330</span> } else {<a name="line.330"></a>
+<span class="sourceLineNo">331</span> ZooKeeper zk;<a name="line.331"></a>
+<span class="sourceLineNo">332</span> try {<a name="line.332"></a>
+<span class="sourceLineNo">333</span> zk = getZk();<a name="line.333"></a>
+<span class="sourceLineNo">334</span> } catch (IOException e) {<a name="line.334"></a>
+<span class="sourceLineNo">335</span> task.connectFailed(e);<a name="line.335"></a>
+<span class="sourceLineNo">336</span> continue;<a name="line.336"></a>
+<span class="sourceLineNo">337</span> }<a name="line.337"></a>
+<span class="sourceLineNo">338</span> task.exec(zk);<a name="line.338"></a>
+<span class="sourceLineNo">339</span> }<a name="line.339"></a>
+<span class="sourceLineNo">340</span> }<a name="line.340"></a>
+<span class="sourceLineNo">341</span> closeZk();<a name="line.341"></a>
+<span class="sourceLineNo">342</span> IOException error = new IOException("Client already closed");<a name="line.342"></a>
+<span class="sourceLineNo">343</span> Arrays.stream(tasks.toArray(new Task[0])).forEach(t -> t.closed(error));<a name="line.343"></a>
+<span class="sourceLineNo">344</span> tasks.clear();<a name="line.344"></a>
+<span class="sourceLineNo">345</span> }<a name="line.345"></a>
+<span class="sourceLineNo">346</span><a name="line.346"></a>
+<span class="sourceLineNo">347</span> @Override<a name="line.347"></a>
+<span class="sourceLineNo">348</span> public void close() {<a name="line.348"></a>
+<span class="sourceLineNo">349</span> if (closed.compareAndSet(false, true)) {<a name="line.349"></a>
+<span class="sourceLineNo">350</span> LOG.info("Close zookeeper connection {} to {}", getId(), connectString);<a name="line.350"></a>
+<span class="sourceLineNo">351</span> tasks.add(CLOSE);<a name="line.351"></a>
+<span class="sourceLineNo">352</span> }<a name="line.352"></a>
+<span class="sourceLineNo">353</span> }<a name="line.353"></a>
+<span class="sourceLineNo">354</span><a name="line.354"></a>
+<span class="sourceLineNo">355</span> @VisibleForTesting<a name="line.355"></a>
+<span class="sourceLineNo">356</span> public String getConnectString() {<a name="line.356"></a>
+<span class="sourceLineNo">357</span> return connectString;<a name="line.357"></a>
+<span class="sourceLineNo">358</span> }<a name="line.358"></a>
+<span class="sourceLineNo">359</span>}<a name="line.359"></a>