You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Saisai Shao <sa...@gmail.com> on 2015/11/16 04:26:45 UTC

Review Request 40337: [AMBARI-13899] Remove hdp.version configuration in Ambari Spark definition

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40337/
-----------------------------------------------------------

Review request for Ambari and Sumit Mohanty.


Repository: ambari


Description
-------

[AMBARI-13899] Remove hdp.version configuration in Ambari, now Spark has a self-finding mechanism, so the definition is not necessary yet.


Diffs
-----

  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/configuration/spark-defaults.xml 6def8b2 
  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/configuration/spark-javaopts-properties.xml f48d79b 
  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/metainfo.xml f84fb73 
  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py 7706650 
  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/setup_spark.py 9969a9b 
  ambari-server/src/main/resources/common-services/SPARK/1.3.1.2.3/metainfo.xml 306d16c 
  ambari-server/src/main/resources/common-services/SPARK/1.4.1.2.3/metainfo.xml 839bbac 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/SPARK/configuration/spark-thrift-sparkconf.xml 41d2e21 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/SPARK/metainfo.xml d86afdf 

Diff: https://reviews.apache.org/r/40337/diff/


Testing
-------

Local test is done.


Thanks,

Saisai Shao


Re: Review Request 40337: [AMBARI-13899] Remove hdp.version configuration in Ambari Spark definition

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40337/#review106593
-----------------------------------------------------------

Ship it!


Some test failures that I have fixed.

- Sumit Mohanty


On Nov. 16, 2015, 3:26 a.m., Saisai Shao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40337/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2015, 3:26 a.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> [AMBARI-13899] Remove hdp.version configuration in Ambari, now Spark has a self-finding mechanism, so the definition is not necessary yet.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/configuration/spark-defaults.xml 6def8b2 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/configuration/spark-javaopts-properties.xml f48d79b 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/metainfo.xml f84fb73 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py 7706650 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/setup_spark.py 9969a9b 
>   ambari-server/src/main/resources/common-services/SPARK/1.3.1.2.3/metainfo.xml 306d16c 
>   ambari-server/src/main/resources/common-services/SPARK/1.4.1.2.3/metainfo.xml 839bbac 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/SPARK/configuration/spark-thrift-sparkconf.xml 41d2e21 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/SPARK/metainfo.xml d86afdf 
> 
> Diff: https://reviews.apache.org/r/40337/diff/
> 
> 
> Testing
> -------
> 
> Local test is done.
> 
> 
> Thanks,
> 
> Saisai Shao
> 
>