You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2016/06/28 20:17:27 UTC

[GitHub] brooklyn-server pull request #223: VanillaSoftwareProcess tests

GitHub user aledsage opened a pull request:

    https://github.com/apache/brooklyn-server/pull/223

    VanillaSoftwareProcess tests

    For "	Don\u2019t call postInstallCommand if skipInstall=true", why did we previous still call postInstall @grkvlt ?
    
    The bulk of this PR is the unit testing of VanillaSoftwareProcess, using the `RecordSshTool` to stub out all the ssh commands.
    
    Note the "Adds EffectorUtilsTest" is unrelated - I meant to include it in a PR a while ago, but accidentally missed it! We previously didn't have any tests that covered these methods directly.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/brooklyn-server VanillaSoftwareProcess-tests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/223.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #223
    
----
commit bc7e0afe7495036019f9d1897e3961f0da4d6153
Author: Aled Sage <al...@gmail.com>
Date:   2016-06-28T20:11:44Z

    Don\u2019t call postInstallCommand if skipInstall=true

commit 13ce4cb8c5767a7a99aa77a09e1f91a9ebdee7a7
Author: Aled Sage <al...@gmail.com>
Date:   2016-06-28T20:14:37Z

    Adds VanillaSoftwareProcessTest (as non-integration)

commit 915ffa7fe957d80720f6f3392a7ecc49b7b68027
Author: Aled Sage <al...@gmail.com>
Date:   2016-06-28T20:15:04Z

    Adds EffectorUtilsTest

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #223: VanillaSoftwareProcess tests

Posted by neykov <gi...@git.apache.org>.

Github user neykov commented on the issue:

    https://github.com/apache/brooklyn-server/pull/223
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #223: VanillaSoftwareProcess tests

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-server/pull/223


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #223: VanillaSoftwareProcess tests

Posted by neykov <gi...@git.apache.org>.

Github user neykov commented on the issue:

    https://github.com/apache/brooklyn-server/pull/223
  
    It was something to do with entities setting object properties on `postInstall`, later required in the launch step. We got NPEs if `postInstall` isn't called.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #223: VanillaSoftwareProcess tests

Posted by grkvlt <gi...@git.apache.org>.

Github user grkvlt commented on the issue:

    https://github.com/apache/brooklyn-server/pull/223
  
    @aledsage not sure about `postInstall()` but I wonder if there was an entity that relied on that behaviour in Clocker? I will check before we merge this...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #223: VanillaSoftwareProcess tests

Posted by aledsage-tmp <gi...@git.apache.org>.

Github user aledsage-tmp commented on the issue:

    https://github.com/apache/brooklyn-server/pull/223
  
    @grkvlt any objections to me merging this? I'll do so later today, unless you say otherwise.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---