You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@solr.apache.org by no...@apache.org on 2022/10/12 04:14:19 UTC

[solr] branch jira/solr-16640 updated: ensure that intra process message is submitted properly

This is an automated email from the ASF dual-hosted git repository.

noble pushed a commit to branch jira/solr-16640
in repository https://gitbox.apache.org/repos/asf/solr.git


The following commit(s) were added to refs/heads/jira/solr-16640 by this push:
     new 963f33051d9 ensure that intra process message is submitted properly
963f33051d9 is described below

commit 963f33051d9af3c39d2cddb15a6f1e7a27d4b5f2
Author: Noble Paul <no...@gmail.com>
AuthorDate: Wed Oct 12 15:14:09 2022 +1100

    ensure that intra process message is submitted properly
---
 .../apache/solr/cloud/api/collections/CollectionCommandContext.java    | 3 +--
 .../org/apache/solr/cloud/api/collections/CreateCollectionCmd.java     | 1 +
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/solr/core/src/java/org/apache/solr/cloud/api/collections/CollectionCommandContext.java b/solr/core/src/java/org/apache/solr/cloud/api/collections/CollectionCommandContext.java
index 7bf58ee1c55..5714b76b8f8 100644
--- a/solr/core/src/java/org/apache/solr/cloud/api/collections/CollectionCommandContext.java
+++ b/solr/core/src/java/org/apache/solr/cloud/api/collections/CollectionCommandContext.java
@@ -99,7 +99,6 @@ public interface CollectionCommandContext {
    * updates are distributed.
    */
   default void submitIntraProcessMessage(Overseer.Message message) {
-    throw new IllegalStateException(
-        "Bug! submitIntraProcessMessage() should not be called when distributed state updates are enabled");
+    //this is ignored
   }
 }
diff --git a/solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java b/solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java
index f18713ea427..191c8fe4b7d 100644
--- a/solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java
+++ b/solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java
@@ -466,6 +466,7 @@ public class CreateCollectionCmd implements CollApiCmds.CollectionApiCommand {
             ErrorCode.BAD_REQUEST,
             "Underlying core creation failed while creating collection: " + collectionName);
       } else {
+        ccc.submitIntraProcessMessage(new RefreshCollectionMessage(collectionName));
         log.debug("Finished create command on all shards for collection: {}", collectionName);
         // Emit a warning about production use of data driven functionality
         // Note: isAutoGeneratedConfigSet is always a clone of the _default configset