[GitHub] dongjoon-hyun commented on a change in pull request #23442: [MINOR][NETWORK][TEST] Fix TransportFrameDecoderSuite to use ByteBuf instead of ByteBuffer

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #23442: [MINOR][NETWORK][TEST] Fix TransportFrameDecoderSuite to use ByteBuf instead of ByteBuffer
URL: https://github.com/apache/spark/pull/23442#discussion_r245160036
 
 

 ##########
 File path: common/network-common/src/test/java/org/apache/spark/network/util/TransportFrameDecoderSuite.java
 ##########
 @@ -69,7 +68,7 @@ public void testInterception() throws Exception {
       decoder.channelRead(ctx, len);
       decoder.channelRead(ctx, dataBuf);
       verify(interceptor, times(interceptedReads)).handle(any(ByteBuf.class));
-      verify(ctx).fireChannelRead(any(ByteBuffer.class));
+      verify(ctx).fireChannelRead(any(ByteBuf.class));
 
 Review comment:
   Hi, @vanzin .
   Could you review this? The other place seems to use `ByteBuf` consistently.
   ```
   $ git grep 'fireChannelRead(any(ByteBuf.class)'
   common/network-common/src/test/java/org/apache/spark/network/util/TransportFrameDecoderSuite.java:      verify(ctx, never()).fireChannelRead(any(ByteBuf.class));
   common/network-common/src/test/java/org/apache/spark/network/util/TransportFrameDecoderSuite.java:      verify(ctx).fireChannelRead(any(ByteBuf.class));
   common/network-common/src/test/java/org/apache/spark/network/util/TransportFrameDecoderSuite.java:      verify(ctx, times(frameCount)).fireChannelRead(any(ByteBuf.class));
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org