You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@avro.apache.org by mg...@apache.org on 2022/12/16 07:31:17 UTC
[avro] branch fix-minor-warnings-from-rust-1.66.0 created (now e0938ffa3)
This is an automated email from the ASF dual-hosted git repository.
mgrigorov pushed a change to branch fix-minor-warnings-from-rust-1.66.0
in repository https://gitbox.apache.org/repos/asf/avro.git
at e0938ffa3 Remove a non-existing label that dependabot tries to set when creating a PR
This branch includes the following new commits:
new b0088b8d9 Fix lint error in IT test
new 410c031e1 Fix lint warning in rustdoc
new e0938ffa3 Remove a non-existing label that dependabot tries to set when creating a PR
The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
[avro] 03/03: Remove a non-existing label that dependabot tries to set when creating a PR
Posted by mg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
mgrigorov pushed a commit to branch fix-minor-warnings-from-rust-1.66.0
in repository https://gitbox.apache.org/repos/asf/avro.git
commit e0938ffa3218e94412b43127c85e6a9c3e742e78
Author: Martin Tzvetanov Grigorov <mg...@apache.org>
AuthorDate: Fri Dec 16 09:30:20 2022 +0200
Remove a non-existing label that dependabot tries to set when creating a PR
Signed-off-by: Martin Tzvetanov Grigorov <mg...@apache.org>
---
.github/dependabot.yml | 1 -
1 file changed, 1 deletion(-)
diff --git a/.github/dependabot.yml b/.github/dependabot.yml
index 300539e2e..0059d8f55 100644
--- a/.github/dependabot.yml
+++ b/.github/dependabot.yml
@@ -85,7 +85,6 @@ updates:
interval: "daily"
open-pull-requests-limit: 20
target-branch: master
- labels: [auto-dependencies]
- package-ecosystem: "github-actions"
directory: "/"
[avro] 02/03: Fix lint warning in rustdoc
Posted by mg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
mgrigorov pushed a commit to branch fix-minor-warnings-from-rust-1.66.0
in repository https://gitbox.apache.org/repos/asf/avro.git
commit 410c031e1ecec2ab478f7f01efcec19dc86f02b1
Author: Martin Tzvetanov Grigorov <mg...@apache.org>
AuthorDate: Fri Dec 16 09:26:46 2022 +0200
Fix lint warning in rustdoc
warning: unclosed HTML tag `Value`
--> avro/src/writer.rs:459:23
|
459 | /// Write the Into<Value> to the provided Write object. Returns a result with the number
| ^^^^^^^
|
= note: `#[warn(rustdoc::invalid_html_tags)]` on by default
help: try marking as source code
|
459 | /// Write the `Into<Value>` to the provided Write object. Returns a result with the number
| + +
warning: `apache-avro` (lib doc) generated 1 warning
Signed-off-by: Martin Tzvetanov Grigorov <mg...@apache.org>
---
lang/rust/avro/src/writer.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lang/rust/avro/src/writer.rs b/lang/rust/avro/src/writer.rs
index 3bc5c5122..82a5b1387 100644
--- a/lang/rust/avro/src/writer.rs
+++ b/lang/rust/avro/src/writer.rs
@@ -456,7 +456,7 @@ impl<T> SpecificSingleObjectWriter<T>
where
T: AvroSchema + Into<Value>,
{
- /// Write the Into<Value> to the provided Write object. Returns a result with the number
+ /// Write the `Into<Value>` to the provided Write object. Returns a result with the number
/// of bytes written including the header
pub fn write_value<W: Write>(&mut self, data: T, writer: &mut W) -> AvroResult<usize> {
let v: Value = data.into();
[avro] 01/03: Fix lint error in IT test
Posted by mg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
mgrigorov pushed a commit to branch fix-minor-warnings-from-rust-1.66.0
in repository https://gitbox.apache.org/repos/asf/avro.git
commit b0088b8d9e6821f91ffa142dd57552c9fa2c03b2
Author: Martin Tzvetanov Grigorov <mg...@apache.org>
AuthorDate: Fri Dec 16 09:25:31 2022 +0200
Fix lint error in IT test
error: casting to the same type is unnecessary (`i64` -> `i64`)
--> avro/tests/io.rs:135:64
|
135 | let encoded = to_avro_datum(&Schema::Long, Value::Long(*number as i64)).unwrap();
| ^^^^^^^^^^^^^^ help: try: `*number`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `-D clippy::unnecessary-cast` implied by `-D clippy::all`
Signed-off-by: Martin Tzvetanov Grigorov <mg...@apache.org>
---
lang/rust/avro/tests/io.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lang/rust/avro/tests/io.rs b/lang/rust/avro/tests/io.rs
index e3d8a6836..fc316b060 100644
--- a/lang/rust/avro/tests/io.rs
+++ b/lang/rust/avro/tests/io.rs
@@ -132,7 +132,7 @@ fn test_binary_int_encoding() {
#[test]
fn test_binary_long_encoding() {
for (number, hex_encoding) in BINARY_ENCODINGS.iter() {
- let encoded = to_avro_datum(&Schema::Long, Value::Long(*number as i64)).unwrap();
+ let encoded = to_avro_datum(&Schema::Long, Value::Long(*number)).unwrap();
assert_eq!(&encoded, hex_encoding);
}
}