You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2024/12/23 05:02:03 UTC
[kudu-CR](branch-1.18.x) [tools] Run range aware cluster rebalance with multiple tables
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22259
Change subject: [tools] Run range aware cluster rebalance with multiple tables
......................................................................
[tools] Run range aware cluster rebalance with multiple tables
Previously when rebalancing cluster with kudu command line tool, the
`--enable_range_rebalancing` flag requires the `--tables` flag with exactly one
table specified.
This commit removes this restriction, allowing multiple tables to be passed to
the `--tables` flag when range rebalancing is enabled. Among them, range
partitioned tables will be rebalanced with ranges considered, while others are
rebalanced as usual. If the `--tables` flag is not set, all tables in the
cluster will be rebalanced.
This commit also optimizes the replica distribution details when range
rabalancing is applied to multiple tables with mixed partition schemas.
Change-Id: I7f6995496e6c28e6a3a8fa4b6f0e8efd05335267
Reviewed-on: http://gerrit.cloudera.org:8080/22239
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 1f89113a618a84d2610410600c012c6180332adc)
---
M src/kudu/rebalance/cluster_status.h
M src/kudu/rebalance/rebalance-test.cc
M src/kudu/rebalance/rebalancer.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/rebalancer_tool-test.cc
M src/kudu/tools/rebalancer_tool.cc
M src/kudu/tools/tool_action_cluster.cc
7 files changed, 133 insertions(+), 21 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/22259/1
--
To view, visit http://gerrit.cloudera.org:8080/22259
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7f6995496e6c28e6a3a8fa4b6f0e8efd05335267
Gerrit-Change-Number: 22259
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Derek Huang <xf...@gmail.com>
[kudu-CR](branch-1.18.x) [tools] Run range aware cluster rebalance with multiple tables
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22259 )
Change subject: [tools] Run range aware cluster rebalance with multiple tables
......................................................................
[tools] Run range aware cluster rebalance with multiple tables
Previously when rebalancing cluster with kudu command line tool, the
`--enable_range_rebalancing` flag requires the `--tables` flag with exactly one
table specified.
This commit removes this restriction, allowing multiple tables to be passed to
the `--tables` flag when range rebalancing is enabled. Among them, range
partitioned tables will be rebalanced with ranges considered, while others are
rebalanced as usual. If the `--tables` flag is not set, all tables in the
cluster will be rebalanced.
This commit also optimizes the replica distribution details when range
rabalancing is applied to multiple tables with mixed partition schemas.
Change-Id: I7f6995496e6c28e6a3a8fa4b6f0e8efd05335267
Reviewed-on: http://gerrit.cloudera.org:8080/22239
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 1f89113a618a84d2610410600c012c6180332adc)
Reviewed-on: http://gerrit.cloudera.org:8080/22259
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Marton Greber <gr...@gmail.com>
---
M src/kudu/rebalance/cluster_status.h
M src/kudu/rebalance/rebalance-test.cc
M src/kudu/rebalance/rebalancer.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/rebalancer_tool-test.cc
M src/kudu/tools/rebalancer_tool.cc
M src/kudu/tools/tool_action_cluster.cc
7 files changed, 133 insertions(+), 21 deletions(-)
Approvals:
Alexey Serbin: Verified
Marton Greber: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/22259
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I7f6995496e6c28e6a3a8fa4b6f0e8efd05335267
Gerrit-Change-Number: 22259
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Derek Huang <xf...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR](branch-1.18.x) [tools] Run range aware cluster rebalance with multiple tables
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/22259 )
Change subject: [tools] Run range aware cluster rebalance with multiple tables
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/22259
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f6995496e6c28e6a3a8fa4b6f0e8efd05335267
Gerrit-Change-Number: 22259
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Derek Huang <xf...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Mon, 30 Dec 2024 12:56:28 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.18.x) [tools] Run range aware cluster rebalance with multiple tables
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22259 )
Change subject: [tools] Run range aware cluster rebalance with multiple tables
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/878/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22259
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f6995496e6c28e6a3a8fa4b6f0e8efd05335267
Gerrit-Change-Number: 22259
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Derek Huang <xf...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 23 Dec 2024 05:59:13 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.18.x) [tools] Run range aware cluster rebalance with multiple tables
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22259 )
Change subject: [tools] Run range aware cluster rebalance with multiple tables
......................................................................
Patch Set 1: Verified+1
Unrelated test failures:
* RELEASE -- known Java flaky test org.apache.kudu.spark.kudu.DefaultSourceTest (KUDU-3194)
* ASAN: AutoRebalancerTest.TestMaxMovesPerServer (KUDU-3559), DeleteTabletITest.TestLeaderElectionDuringDeleteTablet (KUDU-2335)
--
To view, visit http://gerrit.cloudera.org:8080/22259
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f6995496e6c28e6a3a8fa4b6f0e8efd05335267
Gerrit-Change-Number: 22259
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Derek Huang <xf...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 24 Dec 2024 00:11:19 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.18.x) [tools] Run range aware cluster rebalance with multiple tables
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22259 )
Change subject: [tools] Run range aware cluster rebalance with multiple tables
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/878/
--
To view, visit http://gerrit.cloudera.org:8080/22259
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f6995496e6c28e6a3a8fa4b6f0e8efd05335267
Gerrit-Change-Number: 22259
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Derek Huang <xf...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 23 Dec 2024 05:02:13 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.18.x) [tools] Run range aware cluster rebalance with multiple tables
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [tools] Run range aware cluster rebalance with multiple tables
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/22259
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I7f6995496e6c28e6a3a8fa4b6f0e8efd05335267
Gerrit-Change-Number: 22259
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Derek Huang <xf...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)