You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "Till Rohrmann (Jira)" <ji...@apache.org> on 2020/05/14 09:21:00 UTC

[jira] [Commented] (FLINK-16754) Consider refactoring of ProcessMemoryUtilsTestBase to avoid inheritance

    [ https://issues.apache.org/jira/browse/FLINK-16754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107114#comment-17107114 ] 

Till Rohrmann commented on FLINK-16754:
---------------------------------------

Should we make this a follow-up issue for FLINK-16614 instead of a sub task [~azagrebin]? The difference is that now we have to fix this issue in order to close the umbrella issue.

> Consider refactoring of ProcessMemoryUtilsTestBase to avoid inheritance
> -----------------------------------------------------------------------
>
>                 Key: FLINK-16754
>                 URL: https://issues.apache.org/jira/browse/FLINK-16754
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Runtime / Configuration, Runtime / Coordination
>            Reporter: Andrey Zagrebin
>            Assignee: Andrey Zagrebin
>            Priority: Major
>             Fix For: 1.11.0
>
>
> After FLINK-16615 we have class structure of memory utils with isolation of responsibilities, mostly through composition. We should consider to refactor the tests as well to get more abstraction targeted tests with better isolation and w/o implicit test inheritance contracts.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)