You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "codecov-io (GitHub)" <gi...@apache.org> on 2020/01/18 04:32:25 UTC

[GitHub] [dubbo-go] codecov-io commented on issue #289: [WIP] kubernetes as registry

# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/289?src=pr&el=h1) Report
> Merging [#289](https://codecov.io/gh/apache/dubbo-go/pull/289?src=pr&el=desc) into [feature/k8s](https://codecov.io/gh/apache/dubbo-go/commit/11878c4d265a08013da96c5eb93aa60cdc29b0d1?src=pr&el=desc) will **decrease** coverage by `5.57%`.
> The diff coverage is `11.36%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/289/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/289?src=pr&el=tree)

```diff
@@               Coverage Diff               @@
##           feature/k8s     #289      +/-   ##
===============================================
- Coverage        66.01%   60.44%   -5.58%     
===============================================
  Files              105      111       +6     
  Lines             6792     7542     +750     
===============================================
+ Hits              4484     4559      +75     
- Misses            1858     2530     +672     
- Partials           450      453       +3
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/289?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/289/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `0% <0%> (ø)` | |
| [remoting/kubernetes/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/289/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9mYWNhZGUuZ28=) | `0% <0%> (ø)` | |
| [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/289/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `52.3% <0%> (+0.79%)` | :arrow_up: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/289/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `0% <0%> (ø)` | |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/289/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `2.17% <2.17%> (ø)` | |
| [registry/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/289/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `38.29% <38.29%> (ø)` | |
| [remoting/kubernetes/store.go](https://codecov.io/gh/apache/dubbo-go/pull/289/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9zdG9yZS5nbw==) | `62.13% <62.13%> (ø)` | |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/289/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `47.93% <0%> (-3.1%)` | :arrow_down: |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/289/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `64.45% <0%> (-1.74%)` | :arrow_down: |
| ... and [6 more](https://codecov.io/gh/apache/dubbo-go/pull/289/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/289?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/289?src=pr&el=footer). Last update [11878c4...04ee311](https://codecov.io/gh/apache/dubbo-go/pull/289?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/289 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org