You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/31 15:06:36 UTC
[GitHub] [airflow] potiuk opened a new pull request #7306: [AIRFLOW-6694]
Fixed import to print_stuff in kubernetes tests
potiuk opened a new pull request #7306: [AIRFLOW-6694] Fixed import to print_stuff in kubernetes tests
URL: https://github.com/apache/airflow/pull/7306
The import was missing helper.
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7306: [AIRFLOW-6694] Fixed
import to print_stuff in kubernetes tests
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7306: [AIRFLOW-6694] Fixed import to print_stuff in kubernetes tests
URL: https://github.com/apache/airflow/pull/7306#issuecomment-580770713
I hope at least Kubernetes failures will be finally solved this way!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb commented on a change in pull request #7306:
[AIRFLOW-6694] Fixed import to print_stuff in kubernetes tests
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #7306: [AIRFLOW-6694] Fixed import to print_stuff in kubernetes tests
URL: https://github.com/apache/airflow/pull/7306#discussion_r373765567
##########
File path: scripts/ci/in_container/kubernetes/docker/airflow-test-env-init.sh
##########
@@ -20,6 +20,7 @@ set -x
cd /opt/airflow/airflow && \
cp -R example_dags/* /root/airflow/dags/ && \
+find /root/airflow/dags/ && \
Review comment:
This is just to show what dags are there for debugging right? :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #7306: [AIRFLOW-6694] Fixed
import to print_stuff in kubernetes tests
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #7306: [AIRFLOW-6694] Fixed import to print_stuff in kubernetes tests
URL: https://github.com/apache/airflow/pull/7306
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #7306:
[AIRFLOW-6694] Fixed import to print_stuff in kubernetes tests
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7306: [AIRFLOW-6694] Fixed import to print_stuff in kubernetes tests
URL: https://github.com/apache/airflow/pull/7306#discussion_r373768608
##########
File path: scripts/ci/in_container/kubernetes/docker/airflow-test-env-init.sh
##########
@@ -20,6 +20,7 @@ set -x
cd /opt/airflow/airflow && \
cp -R example_dags/* /root/airflow/dags/ && \
+find /root/airflow/dags/ && \
Review comment:
Yel
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services