Re: Review Request 60766: Ignored containers that join CNI networks.

[Qian Zhang <zh...@gmail.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60766/#review184517
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/network/ports.cpp
Lines 405-408 (patched)
<https://reviews.apache.org/r/60766/#comment260685>

    We should call `update()` in this case as well.



src/slave/containerizer/mesos/isolators/network/ports.cpp
Lines 442-444 (patched)
<https://reviews.apache.org/r/60766/#comment260686>

    Better to merge these 3 lines into 2 lines.


- Qian Zhang


On Aug. 31, 2017, 7:26 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60766/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2017, 7:26 a.m.)
> 
> 
> Review request for mesos, Qian Zhang and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7675
>     https://issues.apache.org/jira/browse/MESOS-7675
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Working on the assumption that containers with CNI networks will
> get their own IP addresses and don't need port isolation, ignore
> any containers that are joining CNI networks.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp 5f9373a88819ae1e0ceae708dccbed5383684918 
>   src/slave/containerizer/mesos/isolators/network/ports.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/ports.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60766/diff/14/
> 
> 
> Testing
> -------
> 
> make check (Fedora 26).
> 
> 
> Thanks,
> 
> James Peach
> 
>