You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "hiroyuki-sato (via GitHub)" <gi...@apache.org> on 2025/05/22 13:05:08 UTC
[PR] GH-46556: [GLib] Add GArrowUuidDataType [arrow]
hiroyuki-sato opened a new pull request, #46558:
URL: https://github.com/apache/arrow/pull/46558
### Rationale for this change
GLib should be able to use `arrow::extension:UuidType`.
### What changes are included in this PR?
Add `GArrowUuidDataType`
### Are these changes tested?
Yes.
### Are there any user-facing changes?
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46556: [GLib] Add GArrowUUIDDataType [arrow]
Posted by "hiroyuki-sato (via GitHub)" <gi...@apache.org>.
hiroyuki-sato commented on code in PR #46558:
URL: https://github.com/apache/arrow/pull/46558#discussion_r2106515635
##########
c_glib/test/test-uuid-data-type.rb:
##########
@@ -0,0 +1,37 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+class TestUUIDDataType < Test::Unit::TestCase
+ def setup
+ @data_type = Arrow::UUIDDataType.new
+ end
+
+ def test_id
+ assert_equal(Arrow::Type::EXTENSION, @data_type.id)
+ end
+
+ def test_name
+ assert_equal(["extension", "arrow.uuid"],
+ [@data_type.name, @data_type.extension_name])
+ end
+
+ def test_to_s
+ assert do
+ @data_type.to_s.start_with?("extension<arrow.uuid")
Review Comment:
Thanks. Fixed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46556: [GLib] Add GArrowUUIDDataType [arrow]
Posted by "hiroyuki-sato (via GitHub)" <gi...@apache.org>.
hiroyuki-sato commented on PR #46558:
URL: https://github.com/apache/arrow/pull/46558#issuecomment-2908309932
I changed `Uuid` to `UUID`. Please take a look when you get a chance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46556: [GLib] Add GArrowUuidDataType [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #46558:
URL: https://github.com/apache/arrow/pull/46558#discussion_r2104031113
##########
c_glib/arrow-glib/basic-data-type.cpp:
##########
@@ -134,6 +135,8 @@ G_BEGIN_DECLS
* #GArrowBinaryViewDataType is a class for the binary view data type.
*
* #GArrowFixedShapeTensorDataType is a class for the fixed shape tensor data type.
+ *
+ * #GArrowUuidDataType is a class for UUID data type.
Review Comment:
Could you use "UUID" not "Uuid"?
```suggestion
* #GArrowUUIDDataType is a class for UUID data type.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46556: [GLib] Add GArrowUUIDDataType [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #46558:
URL: https://github.com/apache/arrow/pull/46558#issuecomment-2909730135
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit cfff4d5b848ba551959d92c2631c582e8508241e.
There weren't enough matching historic benchmark results to make a call on whether there were regressions.
The [full Conbench report](https://github.com/apache/arrow/runs/42900365129) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46556: [GLib] Add GArrowUuidDataType [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46558:
URL: https://github.com/apache/arrow/pull/46558#issuecomment-2901163286
:warning: GitHub issue #46556 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46556: [GLib] Add GArrowUUIDDataType [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #46558:
URL: https://github.com/apache/arrow/pull/46558#discussion_r2106409209
##########
c_glib/test/test-uuid-data-type.rb:
##########
@@ -0,0 +1,37 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+class TestUUIDDataType < Test::Unit::TestCase
+ def setup
+ @data_type = Arrow::UUIDDataType.new
+ end
+
+ def test_id
+ assert_equal(Arrow::Type::EXTENSION, @data_type.id)
+ end
+
+ def test_name
+ assert_equal(["extension", "arrow.uuid"],
+ [@data_type.name, @data_type.extension_name])
+ end
+
+ def test_to_s
+ assert do
+ @data_type.to_s.start_with?("extension<arrow.uuid")
Review Comment:
Can we use `assert_equal`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46556: [GLib] Add GArrowUUIDDataType [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #46558:
URL: https://github.com/apache/arrow/pull/46558
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org