You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "jiteshkhatri11 (via GitHub)" <gi...@apache.org> on 2026/09/01 13:02:38 UTC
[PR] docs: remove outdated assembly plugin consequences [maven-resolver]
jiteshkhatri11 opened a new pull request, #2105:
URL: https://github.com/apache/maven-resolver/pull/2105
## Description
Remove the outdated **Important Consequences** section from `common-misconceptions.md`.
The section references `MASSEMBLY-1008` and `MRESOLVER-391`, which are no longer appropriate for the current documentation.
## Changes
* Remove the outdated Assembly plugin discussion.
* Keep the current explanation of runtime and test dependency graphs unchanged.
* Remove the extra blank line before the code block.
## Verification
* `git diff --check` passes.
* Maven build passes successfully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: remove outdated assembly plugin consequences [maven-resolver]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas closed pull request #2105: docs: remove outdated assembly plugin consequences
URL: https://github.com/apache/maven-resolver/pull/2105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: remove outdated assembly plugin consequences [maven-resolver]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on code in PR #2105:
URL: https://github.com/apache/maven-resolver/pull/2105#discussion_r3905174814
##########
src/site/markdown/common-misconceptions.md:
##########
@@ -1,5 +1,4 @@
-# Common Misconceptions
-<!--
+# Common Misconceptions`r`n<!--
Review Comment:
this is wrong, revert it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: remove outdated assembly plugin consequences [maven-resolver]
Posted by "jiteshkhatri11 (via GitHub)" <gi...@apache.org>.
jiteshkhatri11 commented on PR #2105:
URL: https://github.com/apache/maven-resolver/pull/2105#issuecomment-5512860542
Thanks for the clarification. I misunderstood the applicability of the documented Assembly Plugin behavior and treated the referenced issues as making the section outdated.
I'll restore the section and update the PR accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: remove outdated assembly plugin consequences [maven-resolver]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #2105:
URL: https://github.com/apache/maven-resolver/pull/2105#issuecomment-5495603990
The documented behaviour is still true, also depends on what Maven and plugin versions are used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org