You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "vinx13 (via GitHub)" <gi...@apache.org> on 2023/01/25 18:48:52 UTC

[GitHub] [tvm] vinx13 commented on a diff in pull request #13569: [tir][testing] Enable intra-IRModule primfunc call

vinx13 commented on code in PR #13569:
URL: https://github.com/apache/tvm/pull/13569#discussion_r1087050536


##########
src/tir/transforms/plan_update_buffer_allocation_location.cc:
##########
@@ -111,6 +112,12 @@ class BufferAllocationLocator : public StmtExprMutator {
     collector(func->body);
     unmanaged_allocations_ = collector.unmanaged_allocations;
 
+    for (Var param : func->params) {

Review Comment:
   Need test case for this



##########
src/tir/transforms/plan_update_buffer_allocation_location.cc:
##########
@@ -27,6 +27,7 @@
 #include <tvm/tir/transform.h>
 
 #include "ir_utils.h"
+#include "tvm/tir/var.h"

Review Comment:
   ```suggestion
   #include <tvm/tir/var.h>
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org