You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "He-Pin (via GitHub)" <gi...@apache.org> on 2026/07/17 04:07:43 UTC

[PR] Invoke lifecycle signal handlers during snapshot recovery [pekko]

He-Pin opened a new pull request, #3358:
URL: https://github.com/apache/pekko/pull/3358

   ### Motivation
   During snapshot loading, the internal recovery-permit handler intercepted `PostStop` and `PreRestart` before the registered user signal handler could observe them.
   
   ### Modification
   Forward `PostStop` and `PreRestart` to the user signal handler after returning the recovery permit. Add deterministic regression coverage using a blocking snapshot store for both stop and restart paths.
   
   ### Result
   Lifecycle signal handlers now run consistently while an `EventSourcedBehavior` is loading a snapshot, and recovery permits continue to be released.
   
   ### Tests
   - `sbt "persistence-typed-tests / Test / testOnly org.apache.pekko.persistence.typed.scaladsl.EventSourcedBehaviorRecoverySignalSpec"` — passed, 2 tests
   - `sbt "persistence-typed-tests / Test / testOnly org.apache.pekko.persistence.typed.scaladsl.EventSourcedBehaviorFailureSpec org.apache.pekko.persistence.typed.scaladsl.EventSourcedBehaviorStashSpec"` — passed, 27 tests
   - `sbt "persistence-typed / Test / testOnly org.apache.pekko.persistence.typed.internal.RecoveryPermitterSpec"` — passed, 6 tests
   - `sbt +headerCheckAll` — passed
   - `sbt checkCodeStyle` — passed
   - Native `scalafmt --list` on changed Scala files — passed
   - `git diff --check` — passed
   - `sbt sortImports` — not completed because the existing rule failed with a Scalafix/Scalameta `NoSuchMethodError`; `checkCodeStyle` passed
   - `sbt validatePullRequest` — not completed locally per request; delegated to remote CI
   
   ### References
   Fixes #3250
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] Invoke lifecycle signal handlers during snapshot recovery [pekko]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin merged PR #3358:
URL: https://github.com/apache/pekko/pull/3358


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org