You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "ekaterinadimitrova2 (via GitHub)" <gi...@apache.org> on 2023/02/10 19:17:54 UTC
[GitHub] [cassandra] ekaterinadimitrova2 opened a new pull request, #2154: 18252 trunk 4
ekaterinadimitrova2 opened a new pull request, #2154:
URL: https://github.com/apache/cassandra/pull/2154
CASSANDRA-18252 Remove Scripted UDFs from trunk to enable easier JDK17 testing on current trunk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] ekaterinadimitrova2 commented on a diff in pull request #2154: 18252 trunk 4
Posted by "ekaterinadimitrova2 (via GitHub)" <gi...@apache.org>.
ekaterinadimitrova2 commented on code in PR #2154:
URL: https://github.com/apache/cassandra/pull/2154#discussion_r1103166968
##########
src/java/org/apache/cassandra/cql3/functions/UDFunction.java:
##########
@@ -266,13 +266,7 @@ public static UDFunction create(FunctionName name,
{
assertUdfsEnabled(language);
- switch (language)
- {
- case "java":
- return new JavaBasedUDFunction(name, argNames, argTypes, returnType, calledOnNullInput, body);
- default:
- return new ScriptBasedUDFunction(name, argNames, argTypes, returnType, calledOnNullInput, language, body);
Review Comment:
Totally... forgotten... I will take care, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] michaelsembwever commented on a diff in pull request #2154: 18252 trunk 4
Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on code in PR #2154:
URL: https://github.com/apache/cassandra/pull/2154#discussion_r1103165489
##########
src/java/org/apache/cassandra/cql3/functions/UDFunction.java:
##########
@@ -266,13 +266,7 @@ public static UDFunction create(FunctionName name,
{
assertUdfsEnabled(language);
- switch (language)
- {
- case "java":
- return new JavaBasedUDFunction(name, argNames, argTypes, returnType, calledOnNullInput, body);
- default:
- return new ScriptBasedUDFunction(name, argNames, argTypes, returnType, calledOnNullInput, language, body);
Review Comment:
should the `src/java/org/apache/cassandra/cql3/functions/ScriptBasedUDFunction.java` file also be deleted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] michaelsembwever commented on a diff in pull request #2154: 18252 trunk 4
Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on code in PR #2154:
URL: https://github.com/apache/cassandra/pull/2154#discussion_r1103226291
##########
test/conf/cassandra-murmur.yaml:
##########
@@ -39,6 +39,6 @@ compaction_throughput: 0MiB/s
row_cache_class_name: org.apache.cassandra.cache.OHCProvider
row_cache_size: 16MiB
user_defined_functions_enabled: true
-scripted_user_defined_functions_enabled: true
+scripted_user_defined_functions_enabled: false
Review Comment:
ok to leave. i trust your judgement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] ekaterinadimitrova2 commented on a diff in pull request #2154: 18252 trunk 4
Posted by "ekaterinadimitrova2 (via GitHub)" <gi...@apache.org>.
ekaterinadimitrova2 commented on code in PR #2154:
URL: https://github.com/apache/cassandra/pull/2154#discussion_r1103166968
##########
src/java/org/apache/cassandra/cql3/functions/UDFunction.java:
##########
@@ -266,13 +266,7 @@ public static UDFunction create(FunctionName name,
{
assertUdfsEnabled(language);
- switch (language)
- {
- case "java":
- return new JavaBasedUDFunction(name, argNames, argTypes, returnType, calledOnNullInput, body);
- default:
- return new ScriptBasedUDFunction(name, argNames, argTypes, returnType, calledOnNullInput, language, body);
Review Comment:
Totally... just it was forgotten... I will take care, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] ekaterinadimitrova2 closed pull request #2154: 18252 trunk 4
Posted by "ekaterinadimitrova2 (via GitHub)" <gi...@apache.org>.
ekaterinadimitrova2 closed pull request #2154: 18252 trunk 4
URL: https://github.com/apache/cassandra/pull/2154
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] michaelsembwever commented on a diff in pull request #2154: 18252 trunk 4
Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on code in PR #2154:
URL: https://github.com/apache/cassandra/pull/2154#discussion_r1103166326
##########
test/conf/cassandra-murmur.yaml:
##########
@@ -39,6 +39,6 @@ compaction_throughput: 0MiB/s
row_cache_class_name: org.apache.cassandra.cache.OHCProvider
row_cache_size: 16MiB
user_defined_functions_enabled: true
-scripted_user_defined_functions_enabled: true
+scripted_user_defined_functions_enabled: false
Review Comment:
should we just delete all these lines from test cassandra*.yaml files?
(since the deprecated default is `false` )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] ekaterinadimitrova2 commented on a diff in pull request #2154: 18252 trunk 4
Posted by "ekaterinadimitrova2 (via GitHub)" <gi...@apache.org>.
ekaterinadimitrova2 commented on code in PR #2154:
URL: https://github.com/apache/cassandra/pull/2154#discussion_r1103231936
##########
test/conf/cassandra-murmur.yaml:
##########
@@ -39,6 +39,6 @@ compaction_throughput: 0MiB/s
row_cache_class_name: org.apache.cassandra.cache.OHCProvider
row_cache_size: 16MiB
user_defined_functions_enabled: true
-scripted_user_defined_functions_enabled: true
+scripted_user_defined_functions_enabled: false
Review Comment:
Thanks, I will put a note on the other ticket that depending on how it goes we might want to remove them (we should if there are no more reasons to keep them, decluttering is important)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] ekaterinadimitrova2 commented on a diff in pull request #2154: 18252 trunk 4
Posted by "ekaterinadimitrova2 (via GitHub)" <gi...@apache.org>.
ekaterinadimitrova2 commented on code in PR #2154:
URL: https://github.com/apache/cassandra/pull/2154#discussion_r1103193909
##########
test/conf/cassandra-murmur.yaml:
##########
@@ -39,6 +39,6 @@ compaction_throughput: 0MiB/s
row_cache_class_name: org.apache.cassandra.cache.OHCProvider
row_cache_size: 16MiB
user_defined_functions_enabled: true
-scripted_user_defined_functions_enabled: true
+scripted_user_defined_functions_enabled: false
Review Comment:
We can but I wasn't completely sure how things will go in the other ticket as this is only deprecated now in Config class. (And in general there is this tendancy to leave config in the Config class deprecated, maybe even forever? I hear different opinions)
Also, wanted to be sure during testing we don't get sabotaged getting the value from somewhere else that I miss, so flipping at first to be sure they are disabled and fail sounded as a good first choice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] michaelsembwever commented on a diff in pull request #2154: 18252 trunk 4
Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on code in PR #2154:
URL: https://github.com/apache/cassandra/pull/2154#discussion_r1103166326
##########
test/conf/cassandra-murmur.yaml:
##########
@@ -39,6 +39,6 @@ compaction_throughput: 0MiB/s
row_cache_class_name: org.apache.cassandra.cache.OHCProvider
row_cache_size: 16MiB
user_defined_functions_enabled: true
-scripted_user_defined_functions_enabled: true
+scripted_user_defined_functions_enabled: false
Review Comment:
should we just delete all these `scripted_user_defined_functions_enabled: false` lines from test cassandra*.yaml files?
(since the deprecated default is `false` )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org